automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| pw67414 [PATCH 4/6] net/sfc/base: refactor mcast filters reconfiguration
       [not found] <1585563945-9537-5-git-send-email-arybchenko@solarflare.com>
@ 2020-03-30 10:26 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-03-30 10:26 UTC (permalink / raw)
  To: test-report; +Cc: Andrew Rybchenko

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/67414

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#106: FILE: drivers/net/sfc/base/ef10_filter.c:1854:
+static	__checkReturn	efx_rc_t

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#107: FILE: drivers/net/sfc/base/ef10_filter.c:1855:
+ef10_filter_insert_renew_mulcst_filters(

CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#112: FILE: drivers/net/sfc/base/ef10_filter.c:1860:
+	__in_ecount(6*count)		uint8_t const *addrs,
 	             ^

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table->eft_using_all_mulcst == B_FALSE'
#153: FILE: drivers/net/sfc/base/ef10_filter.c:1901:
+			if ((table->eft_using_all_mulcst == B_FALSE) &&
+			    (encp->enc_bug26807_workaround == B_TRUE)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'encp->enc_bug26807_workaround == B_TRUE'
#153: FILE: drivers/net/sfc/base/ef10_filter.c:1901:
+			if ((table->eft_using_all_mulcst == B_FALSE) &&
+			    (encp->enc_bug26807_workaround == B_TRUE)) {

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#186: FILE: drivers/net/sfc/base/ef10_filter.c:1934:
+	return (rc);

total: 1 errors, 0 warnings, 5 checks, 172 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-03-30 10:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1585563945-9537-5-git-send-email-arybchenko@solarflare.com>
2020-03-30 10:26 ` [dpdk-test-report] |WARNING| pw67414 [PATCH 4/6] net/sfc/base: refactor mcast filters reconfiguration checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).