From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CBE3AA0562
	for <public@inbox.dpdk.org>; Mon, 30 Mar 2020 12:26:35 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id EDCA42BEA;
	Mon, 30 Mar 2020 12:26:34 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 8E7851C0BC; Mon, 30 Mar 2020 12:26:33 +0200 (CEST)
In-Reply-To: <1585563945-9537-5-git-send-email-arybchenko@solarflare.com>
References: <1585563945-9537-5-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20200330102633.8E7851C0BC@dpdk.org>
Date: Mon, 30 Mar 2020 12:26:33 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw67414 [PATCH 4/6] net/sfc/base:
	refactor mcast filters reconfiguration
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/67414

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#106: FILE: drivers/net/sfc/base/ef10_filter.c:1854:
+static	__checkReturn	efx_rc_t

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#107: FILE: drivers/net/sfc/base/ef10_filter.c:1855:
+ef10_filter_insert_renew_mulcst_filters(

CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#112: FILE: drivers/net/sfc/base/ef10_filter.c:1860:
+	__in_ecount(6*count)		uint8_t const *addrs,
 	             ^

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'table->eft_using_all_mulcst == B_FALSE'
#153: FILE: drivers/net/sfc/base/ef10_filter.c:1901:
+			if ((table->eft_using_all_mulcst == B_FALSE) &&
+			    (encp->enc_bug26807_workaround == B_TRUE)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'encp->enc_bug26807_workaround == B_TRUE'
#153: FILE: drivers/net/sfc/base/ef10_filter.c:1901:
+			if ((table->eft_using_all_mulcst == B_FALSE) &&
+			    (encp->enc_bug26807_workaround == B_TRUE)) {

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#186: FILE: drivers/net/sfc/base/ef10_filter.c:1934:
+	return (rc);

total: 1 errors, 0 warnings, 5 checks, 172 lines checked