From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw67416 [PATCH 3/6] net/sfc/base: refactor unicast filters reconfiguration
Date: Mon, 30 Mar 2020 12:28:16 +0200 (CEST) [thread overview]
Message-ID: <20200330102816.7154A1C033@dpdk.org> (raw)
In-Reply-To: <1585563945-9537-4-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/67416
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#107: FILE: drivers/net/sfc/base/ef10_filter.c:1806:
+static __checkReturn efx_rc_t
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#108: FILE: drivers/net/sfc/base/ef10_filter.c:1807:
+ef10_filter_insert_renew_unicst_filters(
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rc != 0'
#136: FILE: drivers/net/sfc/base/ef10_filter.c:1835:
+ if (all_unicst || (rc != 0)) {
WARNING:BRACES: braces {} are not necessary for any arm of this statement
#141: FILE: drivers/net/sfc/base/ef10_filter.c:1840:
+ if (all_unicst_rc == 0) {
[...]
+ } else if (rc != 0)
[...]
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#152: FILE: drivers/net/sfc/base/ef10_filter.c:1851:
+ return (rc);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'all_unicst != B_FALSE'
#210: FILE: drivers/net/sfc/base/ef10_filter.c:2006:
+ if (((all_unicst != B_FALSE) && (all_unicst_inserted == B_FALSE)) ||
((all_mulcst != B_FALSE) && (all_mulcst_rc != 0))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'all_unicst_inserted == B_FALSE'
#210: FILE: drivers/net/sfc/base/ef10_filter.c:2006:
+ if (((all_unicst != B_FALSE) && (all_unicst_inserted == B_FALSE)) ||
((all_mulcst != B_FALSE) && (all_mulcst_rc != 0))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'all_mulcst != B_FALSE'
#210: FILE: drivers/net/sfc/base/ef10_filter.c:2006:
+ if (((all_unicst != B_FALSE) && (all_unicst_inserted == B_FALSE)) ||
((all_mulcst != B_FALSE) && (all_mulcst_rc != 0))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'all_mulcst_rc != 0'
#210: FILE: drivers/net/sfc/base/ef10_filter.c:2006:
+ if (((all_unicst != B_FALSE) && (all_unicst_inserted == B_FALSE)) ||
((all_mulcst != B_FALSE) && (all_mulcst_rc != 0))) {
total: 1 errors, 1 warnings, 7 checks, 107 lines checked
parent reply other threads:[~2020-03-30 10:28 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1585563945-9537-4-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330102816.7154A1C033@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).