* [dpdk-test-report] |WARNING| pw67416 [PATCH 3/6] net/sfc/base: refactor unicast filters reconfiguration
[not found] <1585563945-9537-4-git-send-email-arybchenko@solarflare.com>
@ 2020-03-30 10:28 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-03-30 10:28 UTC (permalink / raw)
To: test-report; +Cc: Andrew Rybchenko
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/67416
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#107: FILE: drivers/net/sfc/base/ef10_filter.c:1806:
+static __checkReturn efx_rc_t
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#108: FILE: drivers/net/sfc/base/ef10_filter.c:1807:
+ef10_filter_insert_renew_unicst_filters(
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rc != 0'
#136: FILE: drivers/net/sfc/base/ef10_filter.c:1835:
+ if (all_unicst || (rc != 0)) {
WARNING:BRACES: braces {} are not necessary for any arm of this statement
#141: FILE: drivers/net/sfc/base/ef10_filter.c:1840:
+ if (all_unicst_rc == 0) {
[...]
+ } else if (rc != 0)
[...]
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#152: FILE: drivers/net/sfc/base/ef10_filter.c:1851:
+ return (rc);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'all_unicst != B_FALSE'
#210: FILE: drivers/net/sfc/base/ef10_filter.c:2006:
+ if (((all_unicst != B_FALSE) && (all_unicst_inserted == B_FALSE)) ||
((all_mulcst != B_FALSE) && (all_mulcst_rc != 0))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'all_unicst_inserted == B_FALSE'
#210: FILE: drivers/net/sfc/base/ef10_filter.c:2006:
+ if (((all_unicst != B_FALSE) && (all_unicst_inserted == B_FALSE)) ||
((all_mulcst != B_FALSE) && (all_mulcst_rc != 0))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'all_mulcst != B_FALSE'
#210: FILE: drivers/net/sfc/base/ef10_filter.c:2006:
+ if (((all_unicst != B_FALSE) && (all_unicst_inserted == B_FALSE)) ||
((all_mulcst != B_FALSE) && (all_mulcst_rc != 0))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'all_mulcst_rc != 0'
#210: FILE: drivers/net/sfc/base/ef10_filter.c:2006:
+ if (((all_unicst != B_FALSE) && (all_unicst_inserted == B_FALSE)) ||
((all_mulcst != B_FALSE) && (all_mulcst_rc != 0))) {
total: 1 errors, 1 warnings, 7 checks, 107 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-03-30 10:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1585563945-9537-4-git-send-email-arybchenko@solarflare.com>
2020-03-30 10:28 ` [dpdk-test-report] |WARNING| pw67416 [PATCH 3/6] net/sfc/base: refactor unicast filters reconfiguration checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).