From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 6A15BA057B
	for <public@inbox.dpdk.org>; Mon, 30 Mar 2020 12:28:18 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 610FA1BFD4;
	Mon, 30 Mar 2020 12:28:18 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 7154A1C033; Mon, 30 Mar 2020 12:28:16 +0200 (CEST)
In-Reply-To: <1585563945-9537-4-git-send-email-arybchenko@solarflare.com>
References: <1585563945-9537-4-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20200330102816.7154A1C033@dpdk.org>
Date: Mon, 30 Mar 2020 12:28:16 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw67416 [PATCH 3/6] net/sfc/base:
	refactor unicast filters reconfiguration
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/67416

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#107: FILE: drivers/net/sfc/base/ef10_filter.c:1806:
+static	__checkReturn	efx_rc_t

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#108: FILE: drivers/net/sfc/base/ef10_filter.c:1807:
+ef10_filter_insert_renew_unicst_filters(

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rc != 0'
#136: FILE: drivers/net/sfc/base/ef10_filter.c:1835:
+	if (all_unicst || (rc != 0)) {

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#141: FILE: drivers/net/sfc/base/ef10_filter.c:1840:
+		if (all_unicst_rc == 0) {
[...]
+		} else if (rc != 0)
[...]

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#152: FILE: drivers/net/sfc/base/ef10_filter.c:1851:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'all_unicst != B_FALSE'
#210: FILE: drivers/net/sfc/base/ef10_filter.c:2006:
+	if (((all_unicst != B_FALSE) && (all_unicst_inserted == B_FALSE)) ||
 	    ((all_mulcst != B_FALSE) && (all_mulcst_rc != 0))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'all_unicst_inserted == B_FALSE'
#210: FILE: drivers/net/sfc/base/ef10_filter.c:2006:
+	if (((all_unicst != B_FALSE) && (all_unicst_inserted == B_FALSE)) ||
 	    ((all_mulcst != B_FALSE) && (all_mulcst_rc != 0))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'all_mulcst != B_FALSE'
#210: FILE: drivers/net/sfc/base/ef10_filter.c:2006:
+	if (((all_unicst != B_FALSE) && (all_unicst_inserted == B_FALSE)) ||
 	    ((all_mulcst != B_FALSE) && (all_mulcst_rc != 0))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'all_mulcst_rc != 0'
#210: FILE: drivers/net/sfc/base/ef10_filter.c:2006:
+	if (((all_unicst != B_FALSE) && (all_unicst_inserted == B_FALSE)) ||
 	    ((all_mulcst != B_FALSE) && (all_mulcst_rc != 0))) {

total: 1 errors, 1 warnings, 7 checks, 107 lines checked