From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jakub Neruda <neruda@netcope.com>
Subject: [dpdk-test-report] |WARNING| pw67443 net/nfb: check rxmac array size
Date: Mon, 30 Mar 2020 18:04:19 +0200 (CEST) [thread overview]
Message-ID: <20200330160419.8DEFC1C06D@dpdk.org> (raw)
In-Reply-To: <1585576438-19715-1-git-send-email-neruda@netcope.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/67443
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#74:
The driver wrongly assumed the presence of at least one rxmac in every firmware
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#89: FILE: drivers/net/nfb/nfb_rxmode.c:57:
+ if (internals->max_rxmac > 0)$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#89: FILE: drivers/net/nfb/nfb_rxmode.c:57:
+ if (internals->max_rxmac > 0)
+ nc_rxmac_read_status(internals->rxmac[0], &status);
ERROR:CODE_INDENT: code indent should use tabs where possible
#90: FILE: drivers/net/nfb/nfb_rxmode.c:58:
+ nc_rxmac_read_status(internals->rxmac[0], &status);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#90: FILE: drivers/net/nfb/nfb_rxmode.c:58:
+ nc_rxmac_read_status(internals->rxmac[0], &status);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#100: FILE: drivers/net/nfb/nfb_rxmode.c:107:
+ if (internals->max_rxmac > 0)$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#100: FILE: drivers/net/nfb/nfb_rxmode.c:107:
+ if (internals->max_rxmac > 0)
+ nc_rxmac_read_status(internals->rxmac[0], &status);
ERROR:CODE_INDENT: code indent should use tabs where possible
#101: FILE: drivers/net/nfb/nfb_rxmode.c:108:
+ nc_rxmac_read_status(internals->rxmac[0], &status);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#101: FILE: drivers/net/nfb/nfb_rxmode.c:108:
+ nc_rxmac_read_status(internals->rxmac[0], &status);$
total: 2 errors, 7 warnings, 0 checks, 19 lines checked
parent reply other threads:[~2020-03-30 16:04 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1585576438-19715-1-git-send-email-neruda@netcope.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330160419.8DEFC1C06D@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=neruda@netcope.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).