From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 47E03A0562
	for <public@inbox.dpdk.org>; Fri,  3 Apr 2020 08:20:59 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 3351B1C06D;
	Fri,  3 Apr 2020 08:20:59 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 3AE161C0B2; Fri,  3 Apr 2020 08:20:58 +0200 (CEST)
In-Reply-To: <20200403062001.2728-1-ssardar@amd.com>
References: <20200403062001.2728-1-ssardar@amd.com>
To: test-report@dpdk.org
Cc: ssardar@amd.com
Message-Id: <20200403062058.3AE161C0B2@dpdk.org>
Date: Fri,  3 Apr 2020 08:20:58 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw67740 [PATCH v2] net/axgbe: vlan
	support enabling in axgbe
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/67740

_coding style issues_

Must be a reply to the first patch (--in-reply-to).


WARNING:TYPECAST_INT_CONSTANT: Unnecessary typecast of c90 int constant
#172: FILE: drivers/net/axgbe/axgbe_common.h:295:
+#define VLAN_TABLE_BIT(vlan_id)	((unsigned long)1 << ((vlan_id) & 0x3F))

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct axgbe_port *' should also have an identifier name
#660: FILE: drivers/net/axgbe/axgbe_ethdev.h:295:
+	int (*enable_rx_vlan_stripping)(struct axgbe_port *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct axgbe_port *' should also have an identifier name
#661: FILE: drivers/net/axgbe/axgbe_ethdev.h:296:
+	int (*disable_rx_vlan_stripping)(struct axgbe_port *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct axgbe_port *' should also have an identifier name
#662: FILE: drivers/net/axgbe/axgbe_ethdev.h:297:
+	int (*enable_rx_vlan_filtering)(struct axgbe_port *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct axgbe_port *' should also have an identifier name
#663: FILE: drivers/net/axgbe/axgbe_ethdev.h:298:
+	int (*disable_rx_vlan_filtering)(struct axgbe_port *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct axgbe_port *' should also have an identifier name
#664: FILE: drivers/net/axgbe/axgbe_ethdev.h:299:
+	int (*update_vlan_hash_table)(struct axgbe_port *);

total: 0 errors, 6 warnings, 0 checks, 529 lines checked