From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1F7E7A0597
	for <public@inbox.dpdk.org>; Wed,  8 Apr 2020 08:32:40 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 4A5DC1C0CC;
	Wed,  8 Apr 2020 08:32:39 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id DFDAF1C0BE; Wed,  8 Apr 2020 08:32:37 +0200 (CEST)
In-Reply-To: <20200408062210.34003-7-leyi.rong@intel.com>
References: <20200408062210.34003-7-leyi.rong@intel.com>
To: test-report@dpdk.org
Cc: Leyi Rong <leyi.rong@intel.com>
Message-Id: <20200408063237.DFDAF1C0BE@dpdk.org>
Date: Wed,  8 Apr 2020 08:32:37 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw67959 [PATCH v3 06/11] net/iavf: add
	flow director enabled switch value
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/67959

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ad' - possible side-effects?
#99: FILE: drivers/net/iavf/iavf_rxtx.h:494:
+#define FDIR_PROC_ENABLE_PER_QUEUE(ad, on) do { \
+	for (int i = 0; i < ad->eth_dev->data->nb_rx_queues; i++) { \
+		struct iavf_rx_queue *rxq = ad->eth_dev->data->rx_queues[i]; \
+		if (!rxq) \
+			continue; \
+		rxq->fdir_enabled = on; \
+	} \
+	PMD_DRV_LOG(DEBUG, "FDIR processing on RX set to %d", on); \
+} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'ad' may be better as '(ad)' to avoid precedence issues
#99: FILE: drivers/net/iavf/iavf_rxtx.h:494:
+#define FDIR_PROC_ENABLE_PER_QUEUE(ad, on) do { \
+	for (int i = 0; i < ad->eth_dev->data->nb_rx_queues; i++) { \
+		struct iavf_rx_queue *rxq = ad->eth_dev->data->rx_queues[i]; \
+		if (!rxq) \
+			continue; \
+		rxq->fdir_enabled = on; \
+	} \
+	PMD_DRV_LOG(DEBUG, "FDIR processing on RX set to %d", on); \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'on' - possible side-effects?
#99: FILE: drivers/net/iavf/iavf_rxtx.h:494:
+#define FDIR_PROC_ENABLE_PER_QUEUE(ad, on) do { \
+	for (int i = 0; i < ad->eth_dev->data->nb_rx_queues; i++) { \
+		struct iavf_rx_queue *rxq = ad->eth_dev->data->rx_queues[i]; \
+		if (!rxq) \
+			continue; \
+		rxq->fdir_enabled = on; \
+	} \
+	PMD_DRV_LOG(DEBUG, "FDIR processing on RX set to %d", on); \
+} while (0)

total: 0 errors, 0 warnings, 3 checks, 48 lines checked