From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Christos Ricudis <ricudis@niometrics.com>
Subject: [dpdk-test-report] |WARNING| pw68257 [PATCH] eal: Place EAL thread stack in a reserved per-lcore memzone
Date: Mon, 13 Apr 2020 11:10:06 +0200 (CEST) [thread overview]
Message-ID: <20200413091006.2DEAD1BED7@dpdk.org> (raw)
In-Reply-To: <1586768952-10554-1-git-send-email-ricudis@niometrics.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/68257
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#76:
Reserve a per-lcore 4MB memzone and allocate thread stack of EAL threads there for better NUMA locality of stack-allocated variables
WARNING:LONG_LINE: line over 90 characters
#104: FILE: lib/librte_eal/linux/eal.c:1233:
+ snprintf(thread_stack_name, sizeof thread_stack_name, "rte:lcore:%s:%d:threadstack", rte_eal_process_type() == RTE_PROC_PRIMARY ? "p" : "s", i);
WARNING:SIZEOF_PARENTHESIS: sizeof thread_stack_name should be sizeof(thread_stack_name)
#104: FILE: lib/librte_eal/linux/eal.c:1233:
+ snprintf(thread_stack_name, sizeof thread_stack_name, "rte:lcore:%s:%d:threadstack", rte_eal_process_type() == RTE_PROC_PRIMARY ? "p" : "s", i);
WARNING:LONG_LINE: line over 90 characters
#107: FILE: lib/librte_eal/linux/eal.c:1236:
+ if ((mz = rte_memzone_reserve(thread_stack_name, thread_stack_size, lcore_config[i].socket_id, 0)) == NULL) {
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#107: FILE: lib/librte_eal/linux/eal.c:1236:
+ if ((mz = rte_memzone_reserve(thread_stack_name, thread_stack_size, lcore_config[i].socket_id, 0)) == NULL) {
WARNING:BRACES: braces {} are not necessary for single statement blocks
#107: FILE: lib/librte_eal/linux/eal.c:1236:
+ if ((mz = rte_memzone_reserve(thread_stack_name, thread_stack_size, lcore_config[i].socket_id, 0)) == NULL) {
+ rte_panic("Cannot allocate memzone for thread stack");
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#113: FILE: lib/librte_eal/linux/eal.c:1242:
+ if (pthread_attr_setstack(&attr, thread_stack, thread_stack_size) < 0) {
+ rte_panic("Cannot set thread stack
");
+ }
WARNING:LONG_LINE: line over 90 characters
#116: FILE: lib/librte_eal/linux/eal.c:1245:
+ RTE_LOG(DEBUG, EAL, "Thread stack for lcore %d on socket %d set to %p
", i, lcore_config[i].socket_id, thread_stack);
total: 1 errors, 7 warnings, 32 lines checked
Warning in /lib/librte_eal/linux/eal.c:
Using rte_panic/rte_exit
next parent reply other threads:[~2020-04-13 9:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1586768952-10554-1-git-send-email-ricudis@niometrics.com>
2020-04-13 9:10 ` checkpatch [this message]
2020-04-13 11:10 ` [dpdk-test-report] |SUCCESS| pw68257 " 0-day Robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413091006.2DEAD1BED7@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=ricudis@niometrics.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).