From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>
Subject: [dpdk-test-report] |WARNING| pw68330 [PATCH v2 07/34] net/bnxt: add initial tf core resource mgmt support
Date: Mon, 13 Apr 2020 21:44:37 +0200 (CEST) [thread overview]
Message-ID: <20200413194437.605971C066@dpdk.org> (raw)
In-Reply-To: <1586806811-21736-8-git-send-email-venkatkumar.duvvuru@broadcom.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/68330
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hquery' - possible side-effects?
#347: FILE: drivers/net/bnxt/tf_core/tf_rm.c:29:
+#define TF_RM_CHECK_HW_ALLOC(hquery, dir, hcapi_type, def_value, eflag) do { \
+ if ((dir) == TF_DIR_RX) { \
+ if ((hquery)->hw_query[(hcapi_type)].max != def_value ## _RX) \
+ *(eflag) |= 1 << (hcapi_type); \
+ } else { \
+ if ((hquery)->hw_query[(hcapi_type)].max != def_value ## _TX) \
+ *(eflag) |= 1 << (hcapi_type); \
+ } \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hcapi_type' - possible side-effects?
#347: FILE: drivers/net/bnxt/tf_core/tf_rm.c:29:
+#define TF_RM_CHECK_HW_ALLOC(hquery, dir, hcapi_type, def_value, eflag) do { \
+ if ((dir) == TF_DIR_RX) { \
+ if ((hquery)->hw_query[(hcapi_type)].max != def_value ## _RX) \
+ *(eflag) |= 1 << (hcapi_type); \
+ } else { \
+ if ((hquery)->hw_query[(hcapi_type)].max != def_value ## _TX) \
+ *(eflag) |= 1 << (hcapi_type); \
+ } \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eflag' - possible side-effects?
#347: FILE: drivers/net/bnxt/tf_core/tf_rm.c:29:
+#define TF_RM_CHECK_HW_ALLOC(hquery, dir, hcapi_type, def_value, eflag) do { \
+ if ((dir) == TF_DIR_RX) { \
+ if ((hquery)->hw_query[(hcapi_type)].max != def_value ## _RX) \
+ *(eflag) |= 1 << (hcapi_type); \
+ } else { \
+ if ((hquery)->hw_query[(hcapi_type)].max != def_value ## _TX) \
+ *(eflag) |= 1 << (hcapi_type); \
+ } \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'squery' - possible side-effects?
#369: FILE: drivers/net/bnxt/tf_core/tf_rm.c:51:
+#define TF_RM_CHECK_SRAM_ALLOC(squery, dir, hcapi_type, def_value, eflag) do { \
+ if ((dir) == TF_DIR_RX) { \
+ if ((squery)->sram_query[(hcapi_type)].max != def_value ## _RX)\
+ *(eflag) |= 1 << (hcapi_type); \
+ } else { \
+ if ((squery)->sram_query[(hcapi_type)].max != def_value ## _TX)\
+ *(eflag) |= 1 << (hcapi_type); \
+ } \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hcapi_type' - possible side-effects?
#369: FILE: drivers/net/bnxt/tf_core/tf_rm.c:51:
+#define TF_RM_CHECK_SRAM_ALLOC(squery, dir, hcapi_type, def_value, eflag) do { \
+ if ((dir) == TF_DIR_RX) { \
+ if ((squery)->sram_query[(hcapi_type)].max != def_value ## _RX)\
+ *(eflag) |= 1 << (hcapi_type); \
+ } else { \
+ if ((squery)->sram_query[(hcapi_type)].max != def_value ## _TX)\
+ *(eflag) |= 1 << (hcapi_type); \
+ } \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eflag' - possible side-effects?
#369: FILE: drivers/net/bnxt/tf_core/tf_rm.c:51:
+#define TF_RM_CHECK_SRAM_ALLOC(squery, dir, hcapi_type, def_value, eflag) do { \
+ if ((dir) == TF_DIR_RX) { \
+ if ((squery)->sram_query[(hcapi_type)].max != def_value ## _RX)\
+ *(eflag) |= 1 << (hcapi_type); \
+ } else { \
+ if ((squery)->sram_query[(hcapi_type)].max != def_value ## _TX)\
+ *(eflag) |= 1 << (hcapi_type); \
+ } \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dtype' - possible side-effects?
#390: FILE: drivers/net/bnxt/tf_core/tf_rm.c:72:
+#define TF_RESC_RSVD(dir, type, dtype) do { \
+ if ((dir) == TF_DIR_RX) \
+ (dtype) = type ## _RX; \
+ else \
+ (dtype) = type ## _TX; \
+ } while (0)
total: 0 errors, 0 warnings, 7 checks, 2339 lines checked
parent reply other threads:[~2020-04-13 19:44 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1586806811-21736-8-git-send-email-venkatkumar.duvvuru@broadcom.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413194437.605971C066@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=venkatkumar.duvvuru@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).