automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Simei Su <simei.su@intel.com>
Subject: [dpdk-test-report] |WARNING| pw68462 [PATCH v4 1/5] net/iavf: add support for FDIR basic rule
Date: Wed, 15 Apr 2020 04:59:22 +0200 (CEST)	[thread overview]
Message-ID: <20200415025922.2F9541D515@dpdk.org> (raw)
In-Reply-To: <1586919319-221220-2-git-send-email-simei.su@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/68462

_coding style issues_


WARNING:LONG_LINE: line over 90 characters
#216: FILE: drivers/net/iavf/iavf_fdir.c:71:
+	{iavf_pattern_ethertype,		IAVF_FDIR_INSET_ETH,			IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#217: FILE: drivers/net/iavf/iavf_fdir.c:72:
+	{iavf_pattern_eth_ipv4,			IAVF_FDIR_INSET_ETH_IPV4,		IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#218: FILE: drivers/net/iavf/iavf_fdir.c:73:
+	{iavf_pattern_eth_ipv4_udp,		IAVF_FDIR_INSET_ETH_IPV4_UDP,		IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#219: FILE: drivers/net/iavf/iavf_fdir.c:74:
+	{iavf_pattern_eth_ipv4_tcp,		IAVF_FDIR_INSET_ETH_IPV4_TCP,		IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#220: FILE: drivers/net/iavf/iavf_fdir.c:75:
+	{iavf_pattern_eth_ipv4_sctp,		IAVF_FDIR_INSET_ETH_IPV4_SCTP,		IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#221: FILE: drivers/net/iavf/iavf_fdir.c:76:
+	{iavf_pattern_eth_ipv6,			IAVF_FDIR_INSET_ETH_IPV6,		IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#222: FILE: drivers/net/iavf/iavf_fdir.c:77:
+	{iavf_pattern_eth_ipv6_udp,		IAVF_FDIR_INSET_ETH_IPV6_UDP,		IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#223: FILE: drivers/net/iavf/iavf_fdir.c:78:
+	{iavf_pattern_eth_ipv6_tcp,		IAVF_FDIR_INSET_ETH_IPV6_TCP,		IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#224: FILE: drivers/net/iavf/iavf_fdir.c:79:
+	{iavf_pattern_eth_ipv6_sctp,		IAVF_FDIR_INSET_ETH_IPV6_SCTP,		IAVF_INSET_NONE},

WARNING:LONG_LINE: line over 90 characters
#418: FILE: drivers/net/iavf/iavf_fdir.c:273:
+			filter_action = &filter->add_fltr.rule_cfg.action_set.actions[number];

WARNING:LONG_LINE: line over 90 characters
#428: FILE: drivers/net/iavf/iavf_fdir.c:283:
+			filter_action = &filter->add_fltr.rule_cfg.action_set.actions[number];

WARNING:LONG_LINE: line over 90 characters
#439: FILE: drivers/net/iavf/iavf_fdir.c:294:
+			filter_action = &filter->add_fltr.rule_cfg.action_set.actions[number];

WARNING:LONG_LINE: line over 90 characters
#458: FILE: drivers/net/iavf/iavf_fdir.c:313:
+			filter_action = &filter->add_fltr.rule_cfg.action_set.actions[number];

WARNING:LONG_LINE: line over 90 characters
#668: FILE: drivers/net/iavf/iavf_fdir.c:523:
+					VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, IPV6, HOP_LIMIT);

WARNING:LONG_LINE: line over 90 characters
#710: FILE: drivers/net/iavf/iavf_fdir.c:565:
+					VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, UDP, SRC_PORT);

WARNING:LONG_LINE: line over 90 characters
#714: FILE: drivers/net/iavf/iavf_fdir.c:569:
+					VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, UDP, DST_PORT);

WARNING:LONG_LINE: line over 90 characters
#754: FILE: drivers/net/iavf/iavf_fdir.c:609:
+					VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, TCP, SRC_PORT);

WARNING:LONG_LINE: line over 90 characters
#758: FILE: drivers/net/iavf/iavf_fdir.c:613:
+					VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, TCP, DST_PORT);

WARNING:LONG_LINE: line over 90 characters
#792: FILE: drivers/net/iavf/iavf_fdir.c:647:
+					VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, SCTP, SRC_PORT);

WARNING:LONG_LINE: line over 90 characters
#796: FILE: drivers/net/iavf/iavf_fdir.c:651:
+					VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, SCTP, DST_PORT);

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#963: FILE: drivers/net/iavf/iavf_vchnl.c:921:
+		return -1;
+	} else {

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1010: FILE: drivers/net/iavf/iavf_vchnl.c:968:
+		return -1;
+	} else {

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1054: FILE: drivers/net/iavf/iavf_vchnl.c:1012:
+		return -1;
+	} else {

total: 0 errors, 23 warnings, 0 checks, 964 lines checked

           reply	other threads:[~2020-04-15  2:59 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1586919319-221220-2-git-send-email-simei.su@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200415025922.2F9541D515@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=simei.su@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).