From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 306FEA0563 for ; Wed, 15 Apr 2020 10:22:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 49D651D572; Wed, 15 Apr 2020 10:22:19 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id CB0351D56D; Wed, 15 Apr 2020 10:22:17 +0200 (CEST) In-Reply-To: <1586938751-32808-6-git-send-email-venkatkumar.duvvuru@broadcom.com> References: <1586938751-32808-6-git-send-email-venkatkumar.duvvuru@broadcom.com> To: test-report@dpdk.org Cc: Venkat Duvvuru Message-Id: <20200415082217.CB0351D56D@dpdk.org> Date: Wed, 15 Apr 2020 10:22:17 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw68491 [PATCH v4 05/34] net/bnxt: add initial tf core session close support X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/68491 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'size' - possible side-effects? #514: FILE: drivers/net/bnxt/tf_core/bitalloc.h:26: +#define BITALLOC_SIZEOF(size) \ + (sizeof(struct bitalloc) * \ + (((sizeof(struct bitalloc) + \ + sizeof(struct bitalloc) - 1 + \ + (sizeof(bitalloc_word_t) * \ + ((BA_L0(size) - 1) + \ + ((BA_L0(size) == 1) ? 0 : (BA_L1(size) + 1)) + \ + ((BA_L1(size) == 1) ? 0 : (BA_L2(size) + 1)) + \ + ((BA_L2(size) == 1) ? 0 : (BA_L3(size) + 1)) + \ + ((BA_L3(size) == 1) ? 0 : (BA_L4(size) + 1)))))) / \ + sizeof(struct bitalloc))) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'query' - possible side-effects? #725: FILE: drivers/net/bnxt/tf_core/tf_msg.c:23: +#define TF_HW_RESP_TO_QUERY(query, index, response, element) do { \ + (query)->hw_query[index].min = \ + tfp_le_to_cpu_16(response. element ## _min); \ + (query)->hw_query[index].max = \ + tfp_le_to_cpu_16(response. element ## _max); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects? #725: FILE: drivers/net/bnxt/tf_core/tf_msg.c:23: +#define TF_HW_RESP_TO_QUERY(query, index, response, element) do { \ + (query)->hw_query[index].min = \ + tfp_le_to_cpu_16(response. element ## _min); \ + (query)->hw_query[index].max = \ + tfp_le_to_cpu_16(response. element ## _max); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'response' - possible side-effects? #725: FILE: drivers/net/bnxt/tf_core/tf_msg.c:23: +#define TF_HW_RESP_TO_QUERY(query, index, response, element) do { \ + (query)->hw_query[index].min = \ + tfp_le_to_cpu_16(response. element ## _min); \ + (query)->hw_query[index].max = \ + tfp_le_to_cpu_16(response. element ## _max); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw_entry' - possible side-effects? #741: FILE: drivers/net/bnxt/tf_core/tf_msg.c:39: +#define TF_HW_FREE_TO_REQ(hw_entry, index, request, element) do { \ + request.element ## _start = \ + tfp_cpu_to_le_16(hw_entry[index].start); \ + request.element ## _stride = \ + tfp_cpu_to_le_16(hw_entry[index].stride); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects? #741: FILE: drivers/net/bnxt/tf_core/tf_msg.c:39: +#define TF_HW_FREE_TO_REQ(hw_entry, index, request, element) do { \ + request.element ## _start = \ + tfp_cpu_to_le_16(hw_entry[index].start); \ + request.element ## _stride = \ + tfp_cpu_to_le_16(hw_entry[index].stride); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'request' - possible side-effects? #741: FILE: drivers/net/bnxt/tf_core/tf_msg.c:39: +#define TF_HW_FREE_TO_REQ(hw_entry, index, request, element) do { \ + request.element ## _start = \ + tfp_cpu_to_le_16(hw_entry[index].start); \ + request.element ## _stride = \ + tfp_cpu_to_le_16(hw_entry[index].stride); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw_entry' - possible side-effects? #752: FILE: drivers/net/bnxt/tf_core/tf_msg.c:50: +#define TF_HW_RESP_TO_ALLOC(hw_entry, index, response, element) do { \ + hw_entry[index].start = \ + tfp_le_to_cpu_16(response.element ## _start); \ + hw_entry[index].stride = \ + tfp_le_to_cpu_16(response.element ## _stride); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects? #752: FILE: drivers/net/bnxt/tf_core/tf_msg.c:50: +#define TF_HW_RESP_TO_ALLOC(hw_entry, index, response, element) do { \ + hw_entry[index].start = \ + tfp_le_to_cpu_16(response.element ## _start); \ + hw_entry[index].stride = \ + tfp_le_to_cpu_16(response.element ## _stride); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'response' - possible side-effects? #752: FILE: drivers/net/bnxt/tf_core/tf_msg.c:50: +#define TF_HW_RESP_TO_ALLOC(hw_entry, index, response, element) do { \ + hw_entry[index].start = \ + tfp_le_to_cpu_16(response.element ## _start); \ + hw_entry[index].stride = \ + tfp_le_to_cpu_16(response.element ## _stride); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'query' - possible side-effects? #763: FILE: drivers/net/bnxt/tf_core/tf_msg.c:61: +#define TF_SRAM_RESP_TO_QUERY(query, index, response, element) do { \ + (query)->sram_query[index].min = \ + tfp_le_to_cpu_16(response.element ## _min); \ + (query)->sram_query[index].max = \ + tfp_le_to_cpu_16(response.element ## _max); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects? #763: FILE: drivers/net/bnxt/tf_core/tf_msg.c:61: +#define TF_SRAM_RESP_TO_QUERY(query, index, response, element) do { \ + (query)->sram_query[index].min = \ + tfp_le_to_cpu_16(response.element ## _min); \ + (query)->sram_query[index].max = \ + tfp_le_to_cpu_16(response.element ## _max); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'response' - possible side-effects? #763: FILE: drivers/net/bnxt/tf_core/tf_msg.c:61: +#define TF_SRAM_RESP_TO_QUERY(query, index, response, element) do { \ + (query)->sram_query[index].min = \ + tfp_le_to_cpu_16(response.element ## _min); \ + (query)->sram_query[index].max = \ + tfp_le_to_cpu_16(response.element ## _max); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sram_entry' - possible side-effects? #780: FILE: drivers/net/bnxt/tf_core/tf_msg.c:78: +#define TF_SRAM_FREE_TO_REQ(sram_entry, index, request, element) do { \ + request.element ## _start = \ + tfp_cpu_to_le_16(sram_entry[index].start); \ + request.element ## _stride = \ + tfp_cpu_to_le_16(sram_entry[index].stride); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects? #780: FILE: drivers/net/bnxt/tf_core/tf_msg.c:78: +#define TF_SRAM_FREE_TO_REQ(sram_entry, index, request, element) do { \ + request.element ## _start = \ + tfp_cpu_to_le_16(sram_entry[index].start); \ + request.element ## _stride = \ + tfp_cpu_to_le_16(sram_entry[index].stride); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'request' - possible side-effects? #780: FILE: drivers/net/bnxt/tf_core/tf_msg.c:78: +#define TF_SRAM_FREE_TO_REQ(sram_entry, index, request, element) do { \ + request.element ## _start = \ + tfp_cpu_to_le_16(sram_entry[index].start); \ + request.element ## _stride = \ + tfp_cpu_to_le_16(sram_entry[index].stride); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sram_entry' - possible side-effects? #791: FILE: drivers/net/bnxt/tf_core/tf_msg.c:89: +#define TF_SRAM_RESP_TO_ALLOC(sram_entry, index, response, element) do { \ + sram_entry[index].start = \ + tfp_le_to_cpu_16(response.element ## _start); \ + sram_entry[index].stride = \ + tfp_le_to_cpu_16(response.element ## _stride); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects? #791: FILE: drivers/net/bnxt/tf_core/tf_msg.c:89: +#define TF_SRAM_RESP_TO_ALLOC(sram_entry, index, response, element) do { \ + sram_entry[index].start = \ + tfp_le_to_cpu_16(response.element ## _start); \ + sram_entry[index].stride = \ + tfp_le_to_cpu_16(response.element ## _stride); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'response' - possible side-effects? #791: FILE: drivers/net/bnxt/tf_core/tf_msg.c:89: +#define TF_SRAM_RESP_TO_ALLOC(sram_entry, index, response, element) do { \ + sram_entry[index].start = \ + tfp_le_to_cpu_16(response.element ## _start); \ + sram_entry[index].stride = \ + tfp_le_to_cpu_16(response.element ## _stride); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tfs' - possible side-effects? #1273: FILE: drivers/net/bnxt/tf_core/tf_rm.h:40: +#define TF_RM_GET_POOLS(tfs, direction, session_pool, pool_name, rc) do { \ + (rc) = 0; \ + if ((direction) == TF_DIR_RX) { \ + *(session_pool) = (tfs)->pool_name ## _RX; \ + } else if ((direction) == TF_DIR_TX) { \ + *(session_pool) = (tfs)->pool_name ## _TX; \ + } else { \ + rc = -1; \ + } \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'direction' - possible side-effects? #1273: FILE: drivers/net/bnxt/tf_core/tf_rm.h:40: +#define TF_RM_GET_POOLS(tfs, direction, session_pool, pool_name, rc) do { \ + (rc) = 0; \ + if ((direction) == TF_DIR_RX) { \ + *(session_pool) = (tfs)->pool_name ## _RX; \ + } else if ((direction) == TF_DIR_TX) { \ + *(session_pool) = (tfs)->pool_name ## _TX; \ + } else { \ + rc = -1; \ + } \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'session_pool' - possible side-effects? #1273: FILE: drivers/net/bnxt/tf_core/tf_rm.h:40: +#define TF_RM_GET_POOLS(tfs, direction, session_pool, pool_name, rc) do { \ + (rc) = 0; \ + if ((direction) == TF_DIR_RX) { \ + *(session_pool) = (tfs)->pool_name ## _RX; \ + } else if ((direction) == TF_DIR_TX) { \ + *(session_pool) = (tfs)->pool_name ## _TX; \ + } else { \ + rc = -1; \ + } \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'rc' - possible side-effects? #1273: FILE: drivers/net/bnxt/tf_core/tf_rm.h:40: +#define TF_RM_GET_POOLS(tfs, direction, session_pool, pool_name, rc) do { \ + (rc) = 0; \ + if ((direction) == TF_DIR_RX) { \ + *(session_pool) = (tfs)->pool_name ## _RX; \ + } else if ((direction) == TF_DIR_TX) { \ + *(session_pool) = (tfs)->pool_name ## _TX; \ + } else { \ + rc = -1; \ + } \ + } while (0) total: 0 errors, 0 warnings, 23 checks, 1233 lines checked