automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| pw68493 [PATCH v4 07/34] net/bnxt: add initial tf core resource mgmt support
       [not found] <1586938751-32808-8-git-send-email-venkatkumar.duvvuru@broadcom.com>
@ 2020-04-15  8:22 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-04-15  8:22 UTC (permalink / raw)
  To: test-report; +Cc: Venkat Duvvuru

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/68493

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hquery' - possible side-effects?
#349: FILE: drivers/net/bnxt/tf_core/tf_rm.c:29:
+#define TF_RM_CHECK_HW_ALLOC(hquery, dir, hcapi_type, def_value, eflag) do {  \
+	if ((dir) == TF_DIR_RX) {					      \
+		if ((hquery)->hw_query[(hcapi_type)].max != def_value ## _RX) \
+			*(eflag) |= 1 << (hcapi_type);			      \
+	} else {							      \
+		if ((hquery)->hw_query[(hcapi_type)].max != def_value ## _TX) \
+			*(eflag) |= 1 << (hcapi_type);			      \
+	}								      \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hcapi_type' - possible side-effects?
#349: FILE: drivers/net/bnxt/tf_core/tf_rm.c:29:
+#define TF_RM_CHECK_HW_ALLOC(hquery, dir, hcapi_type, def_value, eflag) do {  \
+	if ((dir) == TF_DIR_RX) {					      \
+		if ((hquery)->hw_query[(hcapi_type)].max != def_value ## _RX) \
+			*(eflag) |= 1 << (hcapi_type);			      \
+	} else {							      \
+		if ((hquery)->hw_query[(hcapi_type)].max != def_value ## _TX) \
+			*(eflag) |= 1 << (hcapi_type);			      \
+	}								      \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eflag' - possible side-effects?
#349: FILE: drivers/net/bnxt/tf_core/tf_rm.c:29:
+#define TF_RM_CHECK_HW_ALLOC(hquery, dir, hcapi_type, def_value, eflag) do {  \
+	if ((dir) == TF_DIR_RX) {					      \
+		if ((hquery)->hw_query[(hcapi_type)].max != def_value ## _RX) \
+			*(eflag) |= 1 << (hcapi_type);			      \
+	} else {							      \
+		if ((hquery)->hw_query[(hcapi_type)].max != def_value ## _TX) \
+			*(eflag) |= 1 << (hcapi_type);			      \
+	}								      \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'squery' - possible side-effects?
#371: FILE: drivers/net/bnxt/tf_core/tf_rm.c:51:
+#define TF_RM_CHECK_SRAM_ALLOC(squery, dir, hcapi_type, def_value, eflag) do { \
+	if ((dir) == TF_DIR_RX) {					       \
+		if ((squery)->sram_query[(hcapi_type)].max != def_value ## _RX)\
+			*(eflag) |= 1 << (hcapi_type);			       \
+	} else {							       \
+		if ((squery)->sram_query[(hcapi_type)].max != def_value ## _TX)\
+			*(eflag) |= 1 << (hcapi_type);			       \
+	}								       \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hcapi_type' - possible side-effects?
#371: FILE: drivers/net/bnxt/tf_core/tf_rm.c:51:
+#define TF_RM_CHECK_SRAM_ALLOC(squery, dir, hcapi_type, def_value, eflag) do { \
+	if ((dir) == TF_DIR_RX) {					       \
+		if ((squery)->sram_query[(hcapi_type)].max != def_value ## _RX)\
+			*(eflag) |= 1 << (hcapi_type);			       \
+	} else {							       \
+		if ((squery)->sram_query[(hcapi_type)].max != def_value ## _TX)\
+			*(eflag) |= 1 << (hcapi_type);			       \
+	}								       \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eflag' - possible side-effects?
#371: FILE: drivers/net/bnxt/tf_core/tf_rm.c:51:
+#define TF_RM_CHECK_SRAM_ALLOC(squery, dir, hcapi_type, def_value, eflag) do { \
+	if ((dir) == TF_DIR_RX) {					       \
+		if ((squery)->sram_query[(hcapi_type)].max != def_value ## _RX)\
+			*(eflag) |= 1 << (hcapi_type);			       \
+	} else {							       \
+		if ((squery)->sram_query[(hcapi_type)].max != def_value ## _TX)\
+			*(eflag) |= 1 << (hcapi_type);			       \
+	}								       \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dtype' - possible side-effects?
#392: FILE: drivers/net/bnxt/tf_core/tf_rm.c:72:
+#define TF_RESC_RSVD(dir, type, dtype) do {	\
+		if ((dir) == TF_DIR_RX)		\
+			(dtype) = type ## _RX;	\
+		else				\
+			(dtype) = type ## _TX;	\
+	} while (0)

total: 0 errors, 0 warnings, 7 checks, 2332 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-04-15  8:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1586938751-32808-8-git-send-email-venkatkumar.duvvuru@broadcom.com>
2020-04-15  8:22 ` [dpdk-test-report] |WARNING| pw68493 [PATCH v4 07/34] net/bnxt: add initial tf core resource mgmt support checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).