From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Marvin Liu <yong.liu@intel.com>
Subject: [dpdk-test-report] |WARNING| pw68543 [PATCH v4 3/8] net/virtio: add vectorized packed ring Rx function
Date: Wed, 15 Apr 2020 11:14:14 +0200 (CEST) [thread overview]
Message-ID: <20200415091414.A7A1E1D675@dpdk.org> (raw)
In-Reply-To: <20200415164733.75416-4-yong.liu@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/68543
_coding style issues_
CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#169: FILE: drivers/net/virtio/virtio_rxtx.c:2332:
+virtio_recv_pkts_packed_vec(void __rte_unused *rx_queue,
^
CHECK:SPACING: spaces preferred around that '*' (ctx:WxO)
#170: FILE: drivers/net/virtio/virtio_rxtx.c:2333:
+ struct rte_mbuf __rte_unused **rx_pkts,
^
CHECK:CAMELCASE: Avoid CamelCase: <_Pragma>
#205: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:25:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#205: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:25:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \
+ for (iter = val; iter < size; iter++)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#205: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:25:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \
+ for (iter = val; iter < size; iter++)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues
#205: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:25:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \
+ for (iter = val; iter < size; iter++)
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#210: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:30:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \
+ for (iter = val; iter < size; iter++)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#210: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:30:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \
+ for (iter = val; iter < size; iter++)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues
#210: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:30:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \
+ for (iter = val; iter < size; iter++)
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#215: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:35:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \
+ for (iter = val; iter < size; iter++)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#215: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:35:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \
+ for (iter = val; iter < size; iter++)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues
#215: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:35:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \
+ for (iter = val; iter < size; iter++)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#220: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:40:
+#define virtio_for_each_try_unroll(iter, val, num) \
+ for (iter = val; iter < num; iter++)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'num' may be better as '(num)' to avoid precedence issues
#220: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:40:
+#define virtio_for_each_try_unroll(iter, val, num) \
+ for (iter = val; iter < num; iter++)
total: 3 errors, 0 warnings, 11 checks, 460 lines checked
parent reply other threads:[~2020-04-15 9:14 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200415164733.75416-4-yong.liu@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415091414.A7A1E1D675@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=yong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).