From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C57BA0563 for ; Wed, 15 Apr 2020 11:14:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C31D81D675; Wed, 15 Apr 2020 11:14:16 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id A7A1E1D675; Wed, 15 Apr 2020 11:14:14 +0200 (CEST) In-Reply-To: <20200415164733.75416-4-yong.liu@intel.com> References: <20200415164733.75416-4-yong.liu@intel.com> To: test-report@dpdk.org Cc: Marvin Liu Message-Id: <20200415091414.A7A1E1D675@dpdk.org> Date: Wed, 15 Apr 2020 11:14:14 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw68543 [PATCH v4 3/8] net/virtio: add vectorized packed ring Rx function X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/68543 _coding style issues_ CHECK:SPACING: spaces preferred around that '*' (ctx:WxV) #169: FILE: drivers/net/virtio/virtio_rxtx.c:2332: +virtio_recv_pkts_packed_vec(void __rte_unused *rx_queue, ^ CHECK:SPACING: spaces preferred around that '*' (ctx:WxO) #170: FILE: drivers/net/virtio/virtio_rxtx.c:2333: + struct rte_mbuf __rte_unused **rx_pkts, ^ CHECK:CAMELCASE: Avoid CamelCase: <_Pragma> #205: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:25: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #205: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:25: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects? #205: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:25: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues #205: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:25: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \ + for (iter = val; iter < size; iter++) ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #210: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:30: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects? #210: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:30: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues #210: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:30: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \ + for (iter = val; iter < size; iter++) ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #215: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:35: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects? #215: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:35: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues #215: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:35: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects? #220: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:40: +#define virtio_for_each_try_unroll(iter, val, num) \ + for (iter = val; iter < num; iter++) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'num' may be better as '(num)' to avoid precedence issues #220: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:40: +#define virtio_for_each_try_unroll(iter, val, num) \ + for (iter = val; iter < num; iter++) total: 3 errors, 0 warnings, 11 checks, 460 lines checked