From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F1B8A0588 for ; Thu, 16 Apr 2020 10:21:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6A6A71DB3D; Thu, 16 Apr 2020 10:21:53 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 42BC61DB38; Thu, 16 Apr 2020 10:21:51 +0200 (CEST) In-Reply-To: <20200416080947.55005-7-leyi.rong@intel.com> References: <20200416080947.55005-7-leyi.rong@intel.com> To: test-report@dpdk.org Cc: Leyi Rong Message-Id: <20200416082151.42BC61DB38@dpdk.org> Date: Thu, 16 Apr 2020 10:21:51 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw68640 [PATCH v5 06/11] net/iavf: add flow director enabled switch value X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/68640 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ad' - possible side-effects? #99: FILE: drivers/net/iavf/iavf_rxtx.h:495: +#define FDIR_PROC_ENABLE_PER_QUEUE(ad, on) do { \ + int i; \ + for (i = 0; i < (ad)->eth_dev->data->nb_rx_queues; i++) { \ + struct iavf_rx_queue *rxq = (ad)->eth_dev->data->rx_queues[i]; \ + if (!rxq) \ + continue; \ + rxq->fdir_enabled = on; \ + } \ + PMD_DRV_LOG(DEBUG, "FDIR processing on RX set to %d", on); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'on' - possible side-effects? #99: FILE: drivers/net/iavf/iavf_rxtx.h:495: +#define FDIR_PROC_ENABLE_PER_QUEUE(ad, on) do { \ + int i; \ + for (i = 0; i < (ad)->eth_dev->data->nb_rx_queues; i++) { \ + struct iavf_rx_queue *rxq = (ad)->eth_dev->data->rx_queues[i]; \ + if (!rxq) \ + continue; \ + rxq->fdir_enabled = on; \ + } \ + PMD_DRV_LOG(DEBUG, "FDIR processing on RX set to %d", on); \ +} while (0) total: 0 errors, 0 warnings, 2 checks, 49 lines checked