automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Nithin Dabilpuram <nithind1988@gmail.com>
Subject: [dpdk-test-report] |WARNING| pw68735 [PATCH 3/3] net/octeontx2: add Tx packet marking offload support
Date: Fri, 17 Apr 2020 09:24:25 +0200 (CEST)	[thread overview]
Message-ID: <20200417072425.CC3AC1DD4A@dpdk.org> (raw)
In-Reply-To: <20200417072254.11455-3-nithind1988@gmail.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/68735

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'flags' - possible side-effects?
#334: FILE: drivers/net/octeontx2/otx2_tx.c:992:
+#define T(name, f7, f6, f5, f4, f3, f2, f1, f0, sz, flags)		\
 static uint16_t __rte_noinline	__hot					\
 otx2_nix_xmit_pkts_vec_ ## name(void *tx_queue,				\
 			struct rte_mbuf **tx_pkts, uint16_t pkts)	\
 {									\
 	uint64_t cmd[sz];						\
 									\
+	/* VLAN, TSTMP, TSO, MARK is not supported by vec */		\
 	if ((flags) & NIX_TX_OFFLOAD_VLAN_QINQ_F ||			\
 	    (flags) & NIX_TX_OFFLOAD_TSTAMP_F ||			\
+	    (flags) & NIX_TX_OFFLOAD_TSO_F ||				\
+	    (flags) & NIX_TX_OFFLOAD_MARK_F)				\
 		return 0;						\
 	return nix_xmit_pkts_vector(tx_queue, tx_pkts, pkts, cmd, (flags)); \
 }

total: 0 errors, 0 warnings, 1 checks, 1001 lines checked

           reply	other threads:[~2020-04-17  7:24 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20200417072254.11455-3-nithind1988@gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200417072425.CC3AC1DD4A@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=nithind1988@gmail.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).