From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Kiran KN <kirankn@juniper.net>
Subject: [dpdk-test-report] |WARNING| pw68993 [PATCH] net/bonding: Support configuration for LACP fast timers
Date: Tue, 21 Apr 2020 09:54:10 +0200 (CEST) [thread overview]
Message-ID: <20200421075410.297E01D8FD@dpdk.org> (raw)
In-Reply-To: <41992913-213C-4922-9893-35F3B516A872@juniper.net>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/68993
_coding style issues_
WARNING:BAD_SIGN_OFF: 'Signed-off-by:' is the preferred signature form
#146:
signed-off-by: Kiran KN <kirankn@juniper.net>
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#286: FILE: drivers/net/bonding/rte_eth_bond_api.c:1057:
+ struct bond_dev_private *internals;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#288: FILE: drivers/net/bonding/rte_eth_bond_api.c:1059:
+ if (valid_bonded_port_id(bonded_port_id) != 0)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#289: FILE: drivers/net/bonding/rte_eth_bond_api.c:1060:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#289: FILE: drivers/net/bonding/rte_eth_bond_api.c:1060:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#291: FILE: drivers/net/bonding/rte_eth_bond_api.c:1062:
+ internals = rte_eth_devices[bonded_port_id].data->dev_private;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#292: FILE: drivers/net/bonding/rte_eth_bond_api.c:1063:
+ internals->lacp_rate = lacp_rate;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#294: FILE: drivers/net/bonding/rte_eth_bond_api.c:1065:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#300: FILE: drivers/net/bonding/rte_eth_bond_api.c:1071:
+ struct bond_dev_private *internals;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#302: FILE: drivers/net/bonding/rte_eth_bond_api.c:1073:
+ if (valid_bonded_port_id(bonded_port_id) != 0)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#303: FILE: drivers/net/bonding/rte_eth_bond_api.c:1074:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#303: FILE: drivers/net/bonding/rte_eth_bond_api.c:1074:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#305: FILE: drivers/net/bonding/rte_eth_bond_api.c:1076:
+ internals = rte_eth_devices[bonded_port_id].data->dev_private;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#307: FILE: drivers/net/bonding/rte_eth_bond_api.c:1078:
+ return internals->lacp_rate;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#328: FILE: drivers/net/bonding/rte_eth_bond_args.c:306:
+ const char *value, void *extra_args)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#328: FILE: drivers/net/bonding/rte_eth_bond_args.c:306:
+ const char *value, void *extra_args)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#330: FILE: drivers/net/bonding/rte_eth_bond_args.c:308:
+ uint8_t lacp_rate;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#332: FILE: drivers/net/bonding/rte_eth_bond_args.c:310:
+ if (value == NULL || extra_args == NULL)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#333: FILE: drivers/net/bonding/rte_eth_bond_args.c:311:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#333: FILE: drivers/net/bonding/rte_eth_bond_args.c:311:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#335: FILE: drivers/net/bonding/rte_eth_bond_args.c:313:
+ if (strcmp(PMD_BOND_LACP_RATE_FAST_KVARG, value) == 0)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#336: FILE: drivers/net/bonding/rte_eth_bond_args.c:314:
+ lacp_rate = LACP_RATE_FAST;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#336: FILE: drivers/net/bonding/rte_eth_bond_args.c:314:
+ lacp_rate = LACP_RATE_FAST;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#337: FILE: drivers/net/bonding/rte_eth_bond_args.c:315:
+ else if (strcmp("1", value) == 0)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#338: FILE: drivers/net/bonding/rte_eth_bond_args.c:316:
+ lacp_rate = LACP_RATE_FAST;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#338: FILE: drivers/net/bonding/rte_eth_bond_args.c:316:
+ lacp_rate = LACP_RATE_FAST;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#339: FILE: drivers/net/bonding/rte_eth_bond_args.c:317:
+ else if (strcmp(PMD_BOND_LACP_RATE_SLOW_KVARG, value) == 0)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#340: FILE: drivers/net/bonding/rte_eth_bond_args.c:318:
+ lacp_rate = LACP_RATE_SLOW;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#340: FILE: drivers/net/bonding/rte_eth_bond_args.c:318:
+ lacp_rate = LACP_RATE_SLOW;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#341: FILE: drivers/net/bonding/rte_eth_bond_args.c:319:
+ else if (strcmp("0", value) == 0)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#342: FILE: drivers/net/bonding/rte_eth_bond_args.c:320:
+ lacp_rate = LACP_RATE_SLOW;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#342: FILE: drivers/net/bonding/rte_eth_bond_args.c:320:
+ lacp_rate = LACP_RATE_SLOW;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#343: FILE: drivers/net/bonding/rte_eth_bond_args.c:321:
+ else$
ERROR:CODE_INDENT: code indent should use tabs where possible
#344: FILE: drivers/net/bonding/rte_eth_bond_args.c:322:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#344: FILE: drivers/net/bonding/rte_eth_bond_args.c:322:
+ return -1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#346: FILE: drivers/net/bonding/rte_eth_bond_args.c:324:
+ *(uint8_t *)extra_args = lacp_rate;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#347: FILE: drivers/net/bonding/rte_eth_bond_args.c:325:
+ return 0;$
WARNING:LONG_LINE: line over 90 characters
#375: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:3748:
+ "Failed to set lacp rate on bonded device %s
", name);
WARNING:LONG_LINE: line over 90 characters
#380: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:3753:
+ "Lacp rate can be specified only once for bonded device %s
", name);
ERROR:CODE_INDENT: code indent should use tabs where possible
#393: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:3779:
+ "lacp_rate=[fast | slow]");$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#393: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:3779:
+ "lacp_rate=[fast | slow]");$
total: 10 errors, 31 warnings, 0 checks, 200 lines checked
next parent reply other threads:[~2020-04-21 7:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <41992913-213C-4922-9893-35F3B516A872@juniper.net>
2020-04-21 7:54 ` checkpatch [this message]
2020-04-21 10:15 ` [dpdk-test-report] |SUCCESS| pw68993 " 0-day Robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421075410.297E01D8FD@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=kirankn@juniper.net \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).