From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92CE3A0561 for ; Tue, 21 Apr 2020 09:54:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 877A31D8F3; Tue, 21 Apr 2020 09:54:11 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 297E01D8FD; Tue, 21 Apr 2020 09:54:10 +0200 (CEST) In-Reply-To: <41992913-213C-4922-9893-35F3B516A872@juniper.net> References: <41992913-213C-4922-9893-35F3B516A872@juniper.net> To: test-report@dpdk.org Cc: Kiran KN Message-Id: <20200421075410.297E01D8FD@dpdk.org> Date: Tue, 21 Apr 2020 09:54:10 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw68993 [PATCH] net/bonding: Support configuration for LACP fast timers X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/68993 _coding style issues_ WARNING:BAD_SIGN_OFF: 'Signed-off-by:' is the preferred signature form #146: signed-off-by: Kiran KN WARNING:LEADING_SPACE: please, no spaces at the start of a line #286: FILE: drivers/net/bonding/rte_eth_bond_api.c:1057: + struct bond_dev_private *internals;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #288: FILE: drivers/net/bonding/rte_eth_bond_api.c:1059: + if (valid_bonded_port_id(bonded_port_id) != 0)$ ERROR:CODE_INDENT: code indent should use tabs where possible #289: FILE: drivers/net/bonding/rte_eth_bond_api.c:1060: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #289: FILE: drivers/net/bonding/rte_eth_bond_api.c:1060: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #291: FILE: drivers/net/bonding/rte_eth_bond_api.c:1062: + internals = rte_eth_devices[bonded_port_id].data->dev_private;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #292: FILE: drivers/net/bonding/rte_eth_bond_api.c:1063: + internals->lacp_rate = lacp_rate;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #294: FILE: drivers/net/bonding/rte_eth_bond_api.c:1065: + return 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #300: FILE: drivers/net/bonding/rte_eth_bond_api.c:1071: + struct bond_dev_private *internals;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #302: FILE: drivers/net/bonding/rte_eth_bond_api.c:1073: + if (valid_bonded_port_id(bonded_port_id) != 0)$ ERROR:CODE_INDENT: code indent should use tabs where possible #303: FILE: drivers/net/bonding/rte_eth_bond_api.c:1074: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #303: FILE: drivers/net/bonding/rte_eth_bond_api.c:1074: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #305: FILE: drivers/net/bonding/rte_eth_bond_api.c:1076: + internals = rte_eth_devices[bonded_port_id].data->dev_private;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #307: FILE: drivers/net/bonding/rte_eth_bond_api.c:1078: + return internals->lacp_rate;$ ERROR:CODE_INDENT: code indent should use tabs where possible #328: FILE: drivers/net/bonding/rte_eth_bond_args.c:306: + const char *value, void *extra_args)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #328: FILE: drivers/net/bonding/rte_eth_bond_args.c:306: + const char *value, void *extra_args)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #330: FILE: drivers/net/bonding/rte_eth_bond_args.c:308: + uint8_t lacp_rate;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #332: FILE: drivers/net/bonding/rte_eth_bond_args.c:310: + if (value == NULL || extra_args == NULL)$ ERROR:CODE_INDENT: code indent should use tabs where possible #333: FILE: drivers/net/bonding/rte_eth_bond_args.c:311: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #333: FILE: drivers/net/bonding/rte_eth_bond_args.c:311: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #335: FILE: drivers/net/bonding/rte_eth_bond_args.c:313: + if (strcmp(PMD_BOND_LACP_RATE_FAST_KVARG, value) == 0)$ ERROR:CODE_INDENT: code indent should use tabs where possible #336: FILE: drivers/net/bonding/rte_eth_bond_args.c:314: + lacp_rate = LACP_RATE_FAST;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #336: FILE: drivers/net/bonding/rte_eth_bond_args.c:314: + lacp_rate = LACP_RATE_FAST;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #337: FILE: drivers/net/bonding/rte_eth_bond_args.c:315: + else if (strcmp("1", value) == 0)$ ERROR:CODE_INDENT: code indent should use tabs where possible #338: FILE: drivers/net/bonding/rte_eth_bond_args.c:316: + lacp_rate = LACP_RATE_FAST;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #338: FILE: drivers/net/bonding/rte_eth_bond_args.c:316: + lacp_rate = LACP_RATE_FAST;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #339: FILE: drivers/net/bonding/rte_eth_bond_args.c:317: + else if (strcmp(PMD_BOND_LACP_RATE_SLOW_KVARG, value) == 0)$ ERROR:CODE_INDENT: code indent should use tabs where possible #340: FILE: drivers/net/bonding/rte_eth_bond_args.c:318: + lacp_rate = LACP_RATE_SLOW;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #340: FILE: drivers/net/bonding/rte_eth_bond_args.c:318: + lacp_rate = LACP_RATE_SLOW;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #341: FILE: drivers/net/bonding/rte_eth_bond_args.c:319: + else if (strcmp("0", value) == 0)$ ERROR:CODE_INDENT: code indent should use tabs where possible #342: FILE: drivers/net/bonding/rte_eth_bond_args.c:320: + lacp_rate = LACP_RATE_SLOW;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #342: FILE: drivers/net/bonding/rte_eth_bond_args.c:320: + lacp_rate = LACP_RATE_SLOW;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #343: FILE: drivers/net/bonding/rte_eth_bond_args.c:321: + else$ ERROR:CODE_INDENT: code indent should use tabs where possible #344: FILE: drivers/net/bonding/rte_eth_bond_args.c:322: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #344: FILE: drivers/net/bonding/rte_eth_bond_args.c:322: + return -1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #346: FILE: drivers/net/bonding/rte_eth_bond_args.c:324: + *(uint8_t *)extra_args = lacp_rate;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #347: FILE: drivers/net/bonding/rte_eth_bond_args.c:325: + return 0;$ WARNING:LONG_LINE: line over 90 characters #375: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:3748: + "Failed to set lacp rate on bonded device %s ", name); WARNING:LONG_LINE: line over 90 characters #380: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:3753: + "Lacp rate can be specified only once for bonded device %s ", name); ERROR:CODE_INDENT: code indent should use tabs where possible #393: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:3779: + "lacp_rate=[fast | slow]");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #393: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:3779: + "lacp_rate=[fast | slow]");$ total: 10 errors, 31 warnings, 0 checks, 200 lines checked