From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E332CA00C2
	for <public@inbox.dpdk.org>; Thu, 23 Apr 2020 06:57:26 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 7DBB21D5C9;
	Thu, 23 Apr 2020 06:57:26 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 9DE931D57B; Thu, 23 Apr 2020 06:57:23 +0200 (CEST)
In-Reply-To: <20200423123106.78513-6-yong.liu@intel.com>
References: <20200423123106.78513-6-yong.liu@intel.com>
To: test-report@dpdk.org
Cc: Marvin Liu <yong.liu@intel.com>
Message-Id: <20200423045723.9DE931D57B@dpdk.org>
Date: Thu, 23 Apr 2020 06:57:23 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw69174 [PATCH v8 5/9] net/virtio: add
	vectorized packed ring Rx path
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/69174

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <_Pragma>
#213: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:31:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#213: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:31:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#213: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:31:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues
#213: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:31:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \
+	for (iter = val; iter < size; iter++)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#218: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:36:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#218: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:36:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues
#218: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:36:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \
+	for (iter = val; iter < size; iter++)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#223: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:41:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#223: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:41:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues
#223: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:41:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#228: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:46:
+#define virtio_for_each_try_unroll(iter, val, num) \
+	for (iter = val; iter < num; iter++)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'num' may be better as '(num)' to avoid precedence issues
#228: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:46:
+#define virtio_for_each_try_unroll(iter, val, num) \
+	for (iter = val; iter < num; iter++)

total: 3 errors, 0 warnings, 9 checks, 478 lines checked