From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Fady Bader <fady@mellanox.com>
Subject: [dpdk-test-report] |WARNING| pw69188 [PATCH 2/2] timer: support EAL functions on Windows
Date: Thu, 23 Apr 2020 16:45:18 +0200 (CEST) [thread overview]
Message-ID: <20200423144518.C98B31C22C@dpdk.org> (raw)
In-Reply-To: <20200423144350.4016-3-fady@mellanox.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/69188
_coding style issues_
ERROR:SPACING: space required before the open brace '{'
#122: FILE: lib/librte_eal/windows/eal_timer.c:25:
+ if(!timer){
ERROR:SPACING: space required before the open parenthesis '('
#122: FILE: lib/librte_eal/windows/eal_timer.c:25:
+ if(!timer){
WARNING:TYPO_SPELLING: 'didnt' may be misspelled - perhaps 'didn't'?
#123: FILE: lib/librte_eal/windows/eal_timer.c:26:
+ /* didnt find any better errno val */
ERROR:SPACING: space required before the open brace '{'
#130: FILE: lib/librte_eal/windows/eal_timer.c:33:
+ if(!SetWaitableTimer(timer, &liDueTime, 0, NULL, NULL, FALSE)){
ERROR:SPACING: space required before the open parenthesis '('
#130: FILE: lib/librte_eal/windows/eal_timer.c:33:
+ if(!SetWaitableTimer(timer, &liDueTime, 0, NULL, NULL, FALSE)){
WARNING:TYPO_SPELLING: 'didnt' may be misspelled - perhaps 'didn't'?
#132: FILE: lib/librte_eal/windows/eal_timer.c:35:
+ /* didnt find any better errno val */
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#149: FILE: lib/librte_eal/windows/eal_timer.c:52:
+ /*
+ QueryPerformanceFrequency output is in khz.
total: 4 errors, 3 warnings, 101 lines checked
parent reply other threads:[~2020-04-23 14:45 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200423144350.4016-3-fady@mellanox.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423144518.C98B31C22C@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=fady@mellanox.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).