From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 298BBA034E
	for <public@inbox.dpdk.org>; Thu, 23 Apr 2020 16:45:20 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 136B51C1F0;
	Thu, 23 Apr 2020 16:45:20 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id C98B31C22C; Thu, 23 Apr 2020 16:45:18 +0200 (CEST)
In-Reply-To: <20200423144350.4016-3-fady@mellanox.com>
References: <20200423144350.4016-3-fady@mellanox.com>
To: test-report@dpdk.org
Cc: Fady Bader <fady@mellanox.com>
Message-Id: <20200423144518.C98B31C22C@dpdk.org>
Date: Thu, 23 Apr 2020 16:45:18 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw69188 [PATCH 2/2] timer: support EAL
	functions on Windows
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/69188

_coding style issues_


ERROR:SPACING: space required before the open brace '{'
#122: FILE: lib/librte_eal/windows/eal_timer.c:25:
+	if(!timer){

ERROR:SPACING: space required before the open parenthesis '('
#122: FILE: lib/librte_eal/windows/eal_timer.c:25:
+	if(!timer){

WARNING:TYPO_SPELLING: 'didnt' may be misspelled - perhaps 'didn't'?
#123: FILE: lib/librte_eal/windows/eal_timer.c:26:
+		/* didnt find any better errno val */

ERROR:SPACING: space required before the open brace '{'
#130: FILE: lib/librte_eal/windows/eal_timer.c:33:
+	if(!SetWaitableTimer(timer, &liDueTime, 0, NULL, NULL, FALSE)){

ERROR:SPACING: space required before the open parenthesis '('
#130: FILE: lib/librte_eal/windows/eal_timer.c:33:
+	if(!SetWaitableTimer(timer, &liDueTime, 0, NULL, NULL, FALSE)){

WARNING:TYPO_SPELLING: 'didnt' may be misspelled - perhaps 'didn't'?
#132: FILE: lib/librte_eal/windows/eal_timer.c:35:
+		/* didnt find any better errno val */

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#149: FILE: lib/librte_eal/windows/eal_timer.c:52:
+	/*
+	QueryPerformanceFrequency output is in khz.

total: 4 errors, 3 warnings, 101 lines checked