From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 20321A00C5 for ; Sun, 26 Apr 2020 04:22:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1517B1C023; Sun, 26 Apr 2020 04:22:04 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 11A381C022; Sun, 26 Apr 2020 04:21:54 +0200 (CEST) In-Reply-To: <20200426021943.43158-7-yong.liu@intel.com> References: <20200426021943.43158-7-yong.liu@intel.com> To: test-report@dpdk.org Cc: Marvin Liu Message-Id: <20200426022154.11A381C022@dpdk.org> Date: Sun, 26 Apr 2020 04:21:54 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw69322 [PATCH v10 6/9] net/virtio: add vectorized packed ring Rx path X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/69322 _coding style issues_ CHECK:CAMELCASE: Avoid CamelCase: <_Pragma> #205: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:31: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #205: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:31: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects? #205: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:31: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues #205: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:31: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \ + for (iter = val; iter < size; iter++) ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #210: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:36: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects? #210: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:36: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues #210: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:36: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \ + for (iter = val; iter < size; iter++) ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #215: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:41: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects? #215: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:41: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues #215: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:41: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects? #220: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:46: +#define virtio_for_each_try_unroll(iter, val, num) \ + for (iter = val; iter < num; iter++) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'num' may be better as '(num)' to avoid precedence issues #220: FILE: drivers/net/virtio/virtio_rxtx_packed_avx.c:46: +#define virtio_for_each_try_unroll(iter, val, num) \ + for (iter = val; iter < num; iter++) total: 3 errors, 0 warnings, 9 checks, 492 lines checked