From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-test-report] |WARNING| pw69472 [PATCH v2 3/8] eal: alarm: close file on cleanup
Date: Wed, 29 Apr 2020 01:16:34 +0200 (CEST) [thread overview]
Message-ID: <20200428231634.201C31D63E@dpdk.org> (raw)
In-Reply-To: <20200428231415.17985-4-stephen@networkplumber.org>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/69472
_coding style issues_
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#135: FILE: lib/librte_eal/freebsd/eal_alarm.c:67:
+ if (intr_handle.fd == -1)$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#135: FILE: lib/librte_eal/freebsd/eal_alarm.c:67:
+ if (intr_handle.fd == -1)
+ return;
ERROR:CODE_INDENT: code indent should use tabs where possible
#136: FILE: lib/librte_eal/freebsd/eal_alarm.c:68:
+ return;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#136: FILE: lib/librte_eal/freebsd/eal_alarm.c:68:
+ return;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#138: FILE: lib/librte_eal/freebsd/eal_alarm.c:70:
+ close(intr_handle.fd);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#139: FILE: lib/librte_eal/freebsd/eal_alarm.c:71:
+ intr_handle.fd = -1;$
total: 1 errors, 5 warnings, 66 lines checked
parent reply other threads:[~2020-04-28 23:16 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200428231415.17985-4-stephen@networkplumber.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428231634.201C31D63E@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).