From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9D9DBA04B2
	for <public@inbox.dpdk.org>; Mon,  4 May 2020 19:28:29 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 996B01D531;
	Mon,  4 May 2020 19:28:27 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id D5C951D446; Mon,  4 May 2020 19:28:26 +0200 (CEST)
In-Reply-To: <20200501132749.130120-1-583493798@qq.com>
References: <20200501132749.130120-1-583493798@qq.com>
To: test-report@dpdk.org
Cc: Pu Xu <583493798@qq.com>
Message-Id: <20200504172826.D5C951D446@dpdk.org>
Date: Mon,  4 May 2020 19:28:26 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw69715 [PATCH] ip_frag: fix
	fragmenting ipv4 packet with header option
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/69715

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#63: 
When fragmenting ipv4 packet, the data offset should be calculated through the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr).

ERROR:CODE_INDENT: code indent should use tabs where possible
#85: FILE: lib/librte_ip_frag/rte_ipv4_fragmentation.c:27:
+        uint16_t len, uint16_t fofs, uint16_t dofs, uint32_t mf)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#85: FILE: lib/librte_ip_frag/rte_ipv4_fragmentation.c:27:
+        uint16_t len, uint16_t fofs, uint16_t dofs, uint32_t mf)$

WARNING:LONG_LINE: line over 90 characters
#106: FILE: lib/librte_ip_frag/rte_ipv4_fragmentation.c:90:
+	header_len = (in_hdr->version_ihl & RTE_IPV4_HDR_IHL_MASK) * RTE_IPV4_IHL_MULTIPLIER;

total: 1 errors, 3 warnings, 84 lines checked