From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7A3AA00C5 for ; Thu, 7 May 2020 11:47:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C09191DB88; Thu, 7 May 2020 11:47:30 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id D0C481DB75; Thu, 7 May 2020 11:47:28 +0200 (CEST) In-Reply-To: <1588844756-10086-5-git-send-email-orika@mellanox.com> References: <1588844756-10086-5-git-send-email-orika@mellanox.com> To: test-report@dpdk.org Cc: Ori Kam Message-Id: <20200507094728.D0C481DB75@dpdk.org> Date: Thu, 7 May 2020 11:47:28 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw69923 [PATCH v3 4/4] regexdev: implement regex rte level functions X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/69923 _coding style issues_ WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #579: FILE: lib/librte_regexdev/rte_regexdev.h:217: +#define RTE_REGEXDEV_VALID_DEV_ID_OR_ERR_RET(dev_id, retval) do { \ + if (!rte_regexdev_is_valid_dev(dev_id)) { \ + RTE_REGEXDEV_LOG(ERR, "Invalid dev_id=%u ", dev_id); \ + return retval; \ + } \ +} while (0) WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #586: FILE: lib/librte_regexdev/rte_regexdev.h:224: +#define RTE_REGEXDEV_VALID_DEV_ID_OR_RET(dev_id) do { \ + if (!rte_regexdev_is_valid_dev(dev_id)) { \ + RTE_REGEXDEV_LOG(ERR, "Invalid dev_id=%u ", dev_id); \ + return; \ + } \ +} while (0) total: 0 errors, 2 warnings, 597 lines checked