From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D3F8A00C5 for ; Fri, 8 May 2020 07:00:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2FADB1DC28; Fri, 8 May 2020 07:00:22 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 219901DC51; Fri, 8 May 2020 07:00:20 +0200 (CEST) In-Reply-To: <20200508044618.70535-3-guinanx.sun@intel.com> References: <20200508044618.70535-3-guinanx.sun@intel.com> To: test-report@dpdk.org Cc: Guinan Sun Message-Id: <20200508050020.219901DC51@dpdk.org> Date: Fri, 8 May 2020 07:00:20 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw69975 [PATCH v2 2/2] net/e1000: fix defects of macro in VF X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/69975 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'last' - possible side-effects? #96: FILE: drivers/net/e1000/igb_ethdev.c:266: +#define UPDATE_VF_STAT(reg, last, cur) \ +{ \ + uint64_t latest = E1000_READ_REG(hw, reg); \ + uint64_t stat = 0; \ + if (latest >= last) \ + stat = latest - last; \ + else \ + stat = (uint64_t)((latest + \ + ((uint64_t)1 << IGB_32_BIT_WIDTH)) - last);\ + cur += stat & IGB_32_BIT_MASK; \ + last = latest; \ } CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'last' may be better as '(last)' to avoid precedence issues #96: FILE: drivers/net/e1000/igb_ethdev.c:266: +#define UPDATE_VF_STAT(reg, last, cur) \ +{ \ + uint64_t latest = E1000_READ_REG(hw, reg); \ + uint64_t stat = 0; \ + if (latest >= last) \ + stat = latest - last; \ + else \ + stat = (uint64_t)((latest + \ + ((uint64_t)1 << IGB_32_BIT_WIDTH)) - last);\ + cur += stat & IGB_32_BIT_MASK; \ + last = latest; \ } CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'cur' may be better as '(cur)' to avoid precedence issues #96: FILE: drivers/net/e1000/igb_ethdev.c:266: +#define UPDATE_VF_STAT(reg, last, cur) \ +{ \ + uint64_t latest = E1000_READ_REG(hw, reg); \ + uint64_t stat = 0; \ + if (latest >= last) \ + stat = latest - last; \ + else \ + stat = (uint64_t)((latest + \ + ((uint64_t)1 << IGB_32_BIT_WIDTH)) - last);\ + cur += stat & IGB_32_BIT_MASK; \ + last = latest; \ } total: 0 errors, 0 warnings, 3 checks, 30 lines checked