From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Shiri Kuzin <shirik@mellanox.com>
Subject: [dpdk-test-report] |WARNING| pw70733 [RFC 2/3] net/mlx5: add default miss action to flow engine
Date: Tue, 2 Jun 2020 11:40:15 +0200 (CEST) [thread overview]
Message-ID: <20200602094015.EE5A51BF98@dpdk.org> (raw)
In-Reply-To: <a604fc5f82757272eeb7141ca252b50f9bea359c.1591088325.git.shirik@mellanox.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/70733
_coding style issues_
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#177: FILE: drivers/net/mlx5/mlx5_flow.c:1259:
+{
+
WARNING:TYPO_SPELLING: 'Deafult' may be misspelled - perhaps 'Default'?
#194: FILE: drivers/net/mlx5/mlx5_flow.c:5015:
+ * Deafult miss flow
ERROR:TRAILING_WHITESPACE: trailing whitespace
#230: FILE: drivers/net/mlx5/mlx5_flow.c:5051:
+^I$
ERROR:TRAILING_WHITESPACE: trailing whitespace
#233: FILE: drivers/net/mlx5/mlx5_flow.c:5054:
+^I$
ERROR:TRAILING_WHITESPACE: trailing whitespace
#326: FILE: drivers/net/mlx5/mlx5_flow_dv.c:2699:
+^I$
ERROR:SPACING: space required before the open brace '{'
#328: FILE: drivers/net/mlx5/mlx5_flow_dv.c:2701:
+ if (!cnt){
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 16)
#331: FILE: drivers/net/mlx5/mlx5_flow_dv.c:2704:
+ if (sh->default_miss_action)
+ return rte_flow_error_set(error, ENOMEM,
ERROR:TRAILING_WHITESPACE: trailing whitespace
#351: FILE: drivers/net/mlx5/mlx5_flow_dv.c:5257:
+^I^I^Iret = $
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (24, 24)
#367: FILE: drivers/net/mlx5/mlx5_flow_dv.c:8229:
+ if (flow_dv_default_miss_resource_register
[...]
+ return -rte_errno;
ERROR:TRAILING_WHITESPACE: trailing whitespace
#371: FILE: drivers/net/mlx5/mlx5_flow_dv.c:8233:
+^I^I^Idev_flow->handle->fate_action = $
ERROR:SPACING: space required before the open brace '{'
#411: FILE: drivers/net/mlx5/mlx5_flow_dv.c:8811:
+ if (rte_atomic32_dec_and_test(&sh->default_miss_refcnt)){
total: 7 errors, 3 warnings, 1 checks, 271 lines checked
parent reply other threads:[~2020-06-02 9:40 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <a604fc5f82757272eeb7141ca252b50f9bea359c.1591088325.git.shirik@mellanox.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602094015.EE5A51BF98@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=shirik@mellanox.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).