automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Patrick Keroulas <patrick.keroulas@radio-canada.ca>
Subject: [dpdk-test-report] |WARNING| pw71063 [RFC] [PATCH v1 2/3] ethdev: add API to convert raw timestamps to nsec
Date: Wed, 10 Jun 2020 09:59:14 +0200 (CEST)	[thread overview]
Message-ID: <20200610075914.082B2F94@dpdk.org> (raw)
In-Reply-To: <20200609141713.11614-3-patrick.keroulas@radio-canada.ca>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/71063

_coding style issues_


WARNING:TYPO_SPELLING: 'usefull' may be misspelled - perhaps 'useful'?
#80: 
counter in real time unit  which is usefull in a pdump application.

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#205: FILE: lib/librte_pdump/rte_pdump.c:106:
+	unsigned i;

ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#207: FILE: lib/librte_pdump/rte_pdump.c:108:
+	for (i=0; i < nb_pkts; i++) {
 	      ^

WARNING:BRACES: braces {} are not necessary for single statement blocks
#208: FILE: lib/librte_pdump/rte_pdump.c:109:
+		if (pkts[i]->ol_flags & PKT_RX_TIMESTAMP) {
+			rte_eth_convert_ts_to_ns(port_id, &pkts[i]->timestamp);
+		}

total: 1 errors, 3 warnings, 99 lines checked

           reply	other threads:[~2020-06-10  7:59 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20200609141713.11614-3-patrick.keroulas@radio-canada.ca>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200610075914.082B2F94@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=patrick.keroulas@radio-canada.ca \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).