From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBD16A00BE for ; Fri, 12 Jun 2020 15:41:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2FCD71BF73; Fri, 12 Jun 2020 15:41:10 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id C02641BF7A; Fri, 12 Jun 2020 15:41:09 +0200 (CEST) In-Reply-To: <20200612132934.16488-14-somnath.kotur@broadcom.com> References: <20200612132934.16488-14-somnath.kotur@broadcom.com> To: test-report@dpdk.org Cc: Somnath Kotur Message-Id: <20200612134109.C02641BF7A@dpdk.org> Date: Fri, 12 Jun 2020 15:41:09 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw71405 [PATCH 13/50] net/bnxt: update multi device design support X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/71405 _coding style issues_ WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #494: FILE: drivers/net/bnxt/tf_core/tf_common.h:55: +#define TF_CHECK_PARMS1(parms) do { \ + if ((parms) == NULL) { \ + TFP_DRV_LOG(ERR, "Invalid Argument(s) "); \ + return -EINVAL; \ + } \ + } while (0) WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #501: FILE: drivers/net/bnxt/tf_core/tf_common.h:62: +#define TF_CHECK_PARMS2(parms1, parms2) do { \ + if ((parms1) == NULL || (parms2) == NULL) { \ + TFP_DRV_LOG(ERR, "Invalid Argument(s) "); \ + return -EINVAL; \ + } \ + } while (0) WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #508: FILE: drivers/net/bnxt/tf_core/tf_common.h:69: +#define TF_CHECK_PARMS3(parms1, parms2, parms3) do { \ + if ((parms1) == NULL || \ + (parms2) == NULL || \ + (parms3) == NULL) { \ + TFP_DRV_LOG(ERR, "Invalid Argument(s) "); \ + return -EINVAL; \ + } \ + } while (0) WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif #2983: FILE: drivers/net/bnxt/tf_core/tf_session.c:132: +#if 0 total: 0 errors, 4 warnings, 0 checks, 3433 lines checked