From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Somnath Kotur <somnath.kotur@broadcom.com>
Subject: [dpdk-test-report] |WARNING| pw71414 [PATCH 22/50] net/bnxt: support EM and TCAM lookup with table scope
Date: Fri, 12 Jun 2020 15:44:51 +0200 (CEST) [thread overview]
Message-ID: <20200612134451.264FE1BFEF@dpdk.org> (raw)
In-Reply-To: <20200612132934.16488-23-somnath.kotur@broadcom.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/71414
_coding style issues_
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#2615: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:50:
+extern void *eem_db[TF_DIR_MAX];
CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#2631: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:66:
+ "No mapping for page: %d table: %016" PRIu64 "
",
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'parms->rx_num_flows_in_k != 0'
#3274: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:709:
+ if ((parms->rx_num_flows_in_k != 0) &&
+ (parms->rx_max_key_sz_in_bits / 8 == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'parms->tx_num_flows_in_k != 0'
#3282: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:717:
+ if ((parms->tx_num_flows_in_k != 0) &&
+ (parms->tx_max_key_sz_in_bits / 8 == 0)) {
CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#3301: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:736:
+ tbl_scope_cb->em_ctx_info[TF_DIR_RX].em_tables[TF_RECORD_TABLE].num_entries
+ = parms->rx_num_flows_in_k * TF_KILOBYTE;
CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#3303: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:738:
+ tbl_scope_cb->em_ctx_info[TF_DIR_RX].em_tables[TF_RECORD_TABLE].entry_size
+ = parms->rx_max_action_entry_sz_in_bits / 8;
CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#3306: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:741:
+ tbl_scope_cb->em_ctx_info[TF_DIR_RX].em_tables[TF_EFC_TABLE].num_entries
+ = 0;
CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#3320: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:755:
+ tbl_scope_cb->em_ctx_info[TF_DIR_TX].em_tables[TF_RECORD_TABLE].num_entries
+ = parms->tx_num_flows_in_k * TF_KILOBYTE;
CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#3322: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:757:
+ tbl_scope_cb->em_ctx_info[TF_DIR_TX].em_tables[TF_RECORD_TABLE].entry_size
+ = parms->tx_max_action_entry_sz_in_bits / 8;
CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#3325: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:760:
+ tbl_scope_cb->em_ctx_info[TF_DIR_TX].em_tables[TF_EFC_TABLE].num_entries
+ = 0;
WARNING:LONG_LINE: line over 90 characters
#3361: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:796:
+ mask = tf_em_get_key_mask(tbl_scope_cb->em_ctx_info[parms->dir].em_tables[TF_KEY0_TABLE].num_entries);
WARNING:LONG_LINE: line over 90 characters
#3398: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:833:
+ (uint8_t *)&tbl_scope_cb->em_ctx_info[parms->dir].em_tables[TF_KEY0_TABLE];
WARNING:LONG_LINE: line over 90 characters
#3414: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:849:
+ (uint8_t *)&tbl_scope_cb->em_ctx_info[parms->dir].em_tables[TF_KEY1_TABLE];
CHECK:OPEN_ENDED_LINE: Lines should not end with a '['
#3479: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:914:
+ (uint8_t *)&tbl_scope_cb->em_ctx_info[parms->dir].em_tables[
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#3508: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:943:
+ tbl_scope_cb = tbl_scope_cb_find(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#3516: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:951:
+ return tf_insert_eem_entry(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#3533: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:968:
+ tbl_scope_cb = tbl_scope_cb_find(
total: 0 errors, 4 warnings, 13 checks, 6669 lines checked
parent reply other threads:[~2020-06-12 13:44 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200612132934.16488-23-somnath.kotur@broadcom.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200612134451.264FE1BFEF@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=somnath.kotur@broadcom.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).