From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45EF9A00C5 for ; Fri, 12 Jun 2020 15:44:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 351211BFEC; Fri, 12 Jun 2020 15:44:52 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 264FE1BFEF; Fri, 12 Jun 2020 15:44:51 +0200 (CEST) In-Reply-To: <20200612132934.16488-23-somnath.kotur@broadcom.com> References: <20200612132934.16488-23-somnath.kotur@broadcom.com> To: test-report@dpdk.org Cc: Somnath Kotur Message-Id: <20200612134451.264FE1BFEF@dpdk.org> Date: Fri, 12 Jun 2020 15:44:51 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw71414 [PATCH 22/50] net/bnxt: support EM and TCAM lookup with table scope X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/71414 _coding style issues_ WARNING:AVOID_EXTERNS: externs should be avoided in .c files #2615: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:50: +extern void *eem_db[TF_DIR_MAX]; CHECK:CAMELCASE: Avoid CamelCase: #2631: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:66: + "No mapping for page: %d table: %016" PRIu64 " ", CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'parms->rx_num_flows_in_k != 0' #3274: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:709: + if ((parms->rx_num_flows_in_k != 0) && + (parms->rx_max_key_sz_in_bits / 8 == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'parms->tx_num_flows_in_k != 0' #3282: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:717: + if ((parms->tx_num_flows_in_k != 0) && + (parms->tx_max_key_sz_in_bits / 8 == 0)) { CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line #3301: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:736: + tbl_scope_cb->em_ctx_info[TF_DIR_RX].em_tables[TF_RECORD_TABLE].num_entries + = parms->rx_num_flows_in_k * TF_KILOBYTE; CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line #3303: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:738: + tbl_scope_cb->em_ctx_info[TF_DIR_RX].em_tables[TF_RECORD_TABLE].entry_size + = parms->rx_max_action_entry_sz_in_bits / 8; CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line #3306: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:741: + tbl_scope_cb->em_ctx_info[TF_DIR_RX].em_tables[TF_EFC_TABLE].num_entries + = 0; CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line #3320: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:755: + tbl_scope_cb->em_ctx_info[TF_DIR_TX].em_tables[TF_RECORD_TABLE].num_entries + = parms->tx_num_flows_in_k * TF_KILOBYTE; CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line #3322: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:757: + tbl_scope_cb->em_ctx_info[TF_DIR_TX].em_tables[TF_RECORD_TABLE].entry_size + = parms->tx_max_action_entry_sz_in_bits / 8; CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line #3325: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:760: + tbl_scope_cb->em_ctx_info[TF_DIR_TX].em_tables[TF_EFC_TABLE].num_entries + = 0; WARNING:LONG_LINE: line over 90 characters #3361: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:796: + mask = tf_em_get_key_mask(tbl_scope_cb->em_ctx_info[parms->dir].em_tables[TF_KEY0_TABLE].num_entries); WARNING:LONG_LINE: line over 90 characters #3398: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:833: + (uint8_t *)&tbl_scope_cb->em_ctx_info[parms->dir].em_tables[TF_KEY0_TABLE]; WARNING:LONG_LINE: line over 90 characters #3414: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:849: + (uint8_t *)&tbl_scope_cb->em_ctx_info[parms->dir].em_tables[TF_KEY1_TABLE]; CHECK:OPEN_ENDED_LINE: Lines should not end with a '[' #3479: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:914: + (uint8_t *)&tbl_scope_cb->em_ctx_info[parms->dir].em_tables[ CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #3508: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:943: + tbl_scope_cb = tbl_scope_cb_find( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #3516: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:951: + return tf_insert_eem_entry( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #3533: FILE: drivers/net/bnxt/tf_core/tf_em_host.c:968: + tbl_scope_cb = tbl_scope_cb_find( total: 0 errors, 4 warnings, 13 checks, 6669 lines checked