From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Guinan Sun <guinanx.sun@intel.com>
Subject: [dpdk-test-report] |WARNING| pw71869 [PATCH 02/70] net/e1000/base: add initial support for Foxville
Date: Mon, 22 Jun 2020 09:06:17 +0200 (CEST) [thread overview]
Message-ID: <20200622070617.6AC0C1D524@dpdk.org> (raw)
In-Reply-To: <20200622064634.70941-3-guinanx.sun@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/71869
_coding style issues_
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#116: FILE: drivers/net/e1000/base/e1000_82575.c:438:
else
[...]
+ if (mac->type == e1000_i225)
CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#162: FILE: drivers/net/e1000/base/e1000_api.h:23:
+extern void e1000_init_function_pointers_i225(struct e1000_hw *hw);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#326: FILE: drivers/net/e1000/base/e1000_i225.c:13:
+STATIC void e1000_release_nvm_i225(struct e1000_hw *hw);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#327: FILE: drivers/net/e1000/base/e1000_i225.c:14:
+STATIC s32 e1000_get_hw_semaphore_i225(struct e1000_hw *hw);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#332: FILE: drivers/net/e1000/base/e1000_i225.c:19:
+STATIC s32 e1000_pool_flash_update_done_i225(struct e1000_hw *hw);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#333: FILE: drivers/net/e1000/base/e1000_i225.c:20:
+STATIC s32 e1000_valid_led_default_i225(struct e1000_hw *hw, u16 *data);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'offset >= nvm->word_size'
#617: FILE: drivers/net/e1000/base/e1000_i225.c:304:
+ if ((offset >= nvm->word_size) || (words > (nvm->word_size - offset)) ||
+ (words == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'words == 0'
#617: FILE: drivers/net/e1000/base/e1000_i225.c:304:
+ if ((offset >= nvm->word_size) || (words > (nvm->word_size - offset)) ||
+ (words == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i == 1'
#809: FILE: drivers/net/e1000/base/e1000_i225.c:496:
+ if ((i == 1) && ((*record & E1000_INVM_VER_FIELD_ONE) == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i == 1'
#854: FILE: drivers/net/e1000/base/e1000_i225.c:541:
+ if ((i == 1) && ((*record & E1000_INVM_IMGTYPE_FIELD) == 0)) {
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct e1000_hw *' should also have an identifier name
#882: FILE: drivers/net/e1000/base/e1000_i225.c:569:
+ s32 (*read_op_ptr)(struct e1000_hw *, u16, u16, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#882: FILE: drivers/net/e1000/base/e1000_i225.c:569:
+ s32 (*read_op_ptr)(struct e1000_hw *, u16, u16, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#882: FILE: drivers/net/e1000/base/e1000_i225.c:569:
+ s32 (*read_op_ptr)(struct e1000_hw *, u16, u16, u16 *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#882: FILE: drivers/net/e1000/base/e1000_i225.c:569:
+ s32 (*read_op_ptr)(struct e1000_hw *, u16, u16, u16 *);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->phy.media_type == e1000_media_type_copper'
#1097: FILE: drivers/net/e1000/base/e1000_i225.c:784:
+ if ((hw->phy.media_type == e1000_media_type_copper) &&
+ !(hw->dev_spec._82575.eee_disable) &&
+ (speed != SPEED_10)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'speed != SPEED_10'
#1097: FILE: drivers/net/e1000/base/e1000_i225.c:784:
+ if ((hw->phy.media_type == e1000_media_type_copper) &&
+ !(hw->dev_spec._82575.eee_disable) &&
+ (speed != SPEED_10)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->mac.type >= e1000_i225'
#1423: FILE: drivers/net/e1000/base/e1000_i225.c:1110:
+ if ((hw->mac.type >= e1000_i225) &&
+ !(e1000_get_flash_presence_i225(hw))) {
total: 0 errors, 9 warnings, 8 checks, 1431 lines checked
parent reply other threads:[~2020-06-22 7:06 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200622064634.70941-3-guinanx.sun@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622070617.6AC0C1D524@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=guinanx.sun@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).