From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28D03A0350 for ; Mon, 22 Jun 2020 09:06:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 626871D51E; Mon, 22 Jun 2020 09:06:21 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 6AC0C1D524; Mon, 22 Jun 2020 09:06:17 +0200 (CEST) In-Reply-To: <20200622064634.70941-3-guinanx.sun@intel.com> References: <20200622064634.70941-3-guinanx.sun@intel.com> To: test-report@dpdk.org Cc: Guinan Sun Message-Id: <20200622070617.6AC0C1D524@dpdk.org> Date: Mon, 22 Jun 2020 09:06:17 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw71869 [PATCH 02/70] net/e1000/base: add initial support for Foxville X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/71869 _coding style issues_ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8) #116: FILE: drivers/net/e1000/base/e1000_82575.c:438: else [...] + if (mac->type == e1000_i225) CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #162: FILE: drivers/net/e1000/base/e1000_api.h:23: +extern void e1000_init_function_pointers_i225(struct e1000_hw *hw); WARNING:AVOID_EXTERNS: externs should be avoided in .c files #326: FILE: drivers/net/e1000/base/e1000_i225.c:13: +STATIC void e1000_release_nvm_i225(struct e1000_hw *hw); WARNING:AVOID_EXTERNS: externs should be avoided in .c files #327: FILE: drivers/net/e1000/base/e1000_i225.c:14: +STATIC s32 e1000_get_hw_semaphore_i225(struct e1000_hw *hw); WARNING:AVOID_EXTERNS: externs should be avoided in .c files #332: FILE: drivers/net/e1000/base/e1000_i225.c:19: +STATIC s32 e1000_pool_flash_update_done_i225(struct e1000_hw *hw); WARNING:AVOID_EXTERNS: externs should be avoided in .c files #333: FILE: drivers/net/e1000/base/e1000_i225.c:20: +STATIC s32 e1000_valid_led_default_i225(struct e1000_hw *hw, u16 *data); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'offset >= nvm->word_size' #617: FILE: drivers/net/e1000/base/e1000_i225.c:304: + if ((offset >= nvm->word_size) || (words > (nvm->word_size - offset)) || + (words == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'words == 0' #617: FILE: drivers/net/e1000/base/e1000_i225.c:304: + if ((offset >= nvm->word_size) || (words > (nvm->word_size - offset)) || + (words == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i == 1' #809: FILE: drivers/net/e1000/base/e1000_i225.c:496: + if ((i == 1) && ((*record & E1000_INVM_VER_FIELD_ONE) == 0)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i == 1' #854: FILE: drivers/net/e1000/base/e1000_i225.c:541: + if ((i == 1) && ((*record & E1000_INVM_IMGTYPE_FIELD) == 0)) { WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct e1000_hw *' should also have an identifier name #882: FILE: drivers/net/e1000/base/e1000_i225.c:569: + s32 (*read_op_ptr)(struct e1000_hw *, u16, u16, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #882: FILE: drivers/net/e1000/base/e1000_i225.c:569: + s32 (*read_op_ptr)(struct e1000_hw *, u16, u16, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name #882: FILE: drivers/net/e1000/base/e1000_i225.c:569: + s32 (*read_op_ptr)(struct e1000_hw *, u16, u16, u16 *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name #882: FILE: drivers/net/e1000/base/e1000_i225.c:569: + s32 (*read_op_ptr)(struct e1000_hw *, u16, u16, u16 *); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->phy.media_type == e1000_media_type_copper' #1097: FILE: drivers/net/e1000/base/e1000_i225.c:784: + if ((hw->phy.media_type == e1000_media_type_copper) && + !(hw->dev_spec._82575.eee_disable) && + (speed != SPEED_10)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'speed != SPEED_10' #1097: FILE: drivers/net/e1000/base/e1000_i225.c:784: + if ((hw->phy.media_type == e1000_media_type_copper) && + !(hw->dev_spec._82575.eee_disable) && + (speed != SPEED_10)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->mac.type >= e1000_i225' #1423: FILE: drivers/net/e1000/base/e1000_i225.c:1110: + if ((hw->mac.type >= e1000_i225) && + !(e1000_get_flash_presence_i225(hw))) { total: 0 errors, 9 warnings, 8 checks, 1431 lines checked