automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Guinan Sun <guinanx.sun@intel.com>
Subject: [dpdk-test-report] |WARNING| pw72071 [PATCH v2 17/42] net/e1000/base: remove duplicated codes from 82575
Date: Wed, 24 Jun 2020 10:05:23 +0200 (CEST)	[thread overview]
Message-ID: <20200624080523.8D9591D943@dpdk.org> (raw)
In-Reply-To: <20200624075337.6768-18-guinanx.sun@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/72071

_coding style issues_


WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#116: FILE: drivers/net/e1000/base/e1000_82575.c:31:
+STATIC s32 e1000_init_hw_82575(struct e1000_hw *hw);

WARNING:RETURN_VOID: void function return statements are not generally useful
#1007: FILE: drivers/net/e1000/base/e1000_base.c:114:
+	return;
+}

CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#1102: FILE: drivers/net/e1000/base/e1000_base.h:11:
+extern void e1000_rx_fifo_flush_base(struct e1000_hw *hw);

total: 0 errors, 2 warnings, 1 checks, 1120 lines checked

           reply	other threads:[~2020-06-24  8:05 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20200624075337.6768-18-guinanx.sun@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200624080523.8D9591D943@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=guinanx.sun@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).