From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35F32A0350 for ; Wed, 24 Jun 2020 16:24:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0A37D1D99D; Wed, 24 Jun 2020 16:24:36 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id B40E81D9A0; Wed, 24 Jun 2020 16:24:34 +0200 (CEST) In-Reply-To: <20200624142344.3152-1-arkadiuszx.kusztal@intel.com> References: <20200624142344.3152-1-arkadiuszx.kusztal@intel.com> To: test-report@dpdk.org Cc: Arek Kusztal Message-Id: <20200624142434.B40E81D9A0@dpdk.org> Date: Wed, 24 Jun 2020 16:24:34 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw72156 [PATCH v2] examples: add multi process crypto application X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/72156 _coding style issues_ Must be a reply to the first patch (--in-reply-to). ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #346: FILE: examples/mp_crypto/main.c:16: +int +mp_crypto_init_devs(void) { WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 32) #566: FILE: examples/mp_crypto/main.c:236: + if (mp_app_params->enq_param.vector_number[i] >= [...] + MP_APP_LOG(ERR, COL_RED, WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #598: FILE: examples/mp_crypto/main.c:268: + "Session %d not yet created. - Press 'w' to wait until other process will create it - Press 'n' to create local session", WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring #708: FILE: examples/mp_crypto/main.c:378: + while (__timeout <= __counter) { WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 32) #748: FILE: examples/mp_crypto/main.c:418: + for (qp_id = last_qp_on_device; qp_id < MP_APP_QUEUE_PAIRS_NUM; [...] + if (mp_app_devs[dev_id].queue_pair_flag[qp_id] WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'mp_app_init', this function's name, in a string #1008: FILE: examples/mp_crypto/main.c:678: + "mp_app_init: cannot create memzone for process"); WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return #1192: FILE: examples/mp_crypto/main.c:862: + break; + else WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return #1204: FILE: examples/mp_crypto/main.c:874: + break; + else WARNING:LONG_LINE: line over 90 characters #1241: FILE: examples/mp_crypto/main.c:911: + livesign_print_char[livesign_print_idx]); WARNING:LONG_LINE: line over 90 characters #1247: FILE: examples/mp_crypto/main.c:917: + livesign_print_char[livesign_deq_print_idx]); WARNING:LONG_LINE: line over 90 characters #1280: FILE: examples/mp_crypto/main.c:950: + livesign_print_char[livesign_deq_print_idx]); WARNING:LONG_LINE: line over 90 characters #1286: FILE: examples/mp_crypto/main.c:956: + livesign_print_char[livesign_deq_print_idx]); WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'session_vectors[vectors[vector_number].session' #1573: FILE: examples/mp_crypto/mp_crypto.c:104: + RTE_ALIGN_CEIL(session_vectors[vectors[vector_number]. + session].aad_len, 16); WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #1910: FILE: examples/mp_crypto/mp_crypto_parser.c:28: + " across all processes. --Example: --devtype=crypto_qat" WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #1914: FILE: examples/mp_crypto/mp_crypto_parser.c:32: + " first. --Example: -w 03:01.2 -w 03:01.1 -w 03:01.3 --config-dev 0,2" ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #1955: FILE: examples/mp_crypto/mp_crypto_parser.c:73: +static void dump_test_data_options(struct mp_crypto_app_parameters + *test_data __rte_unused) { ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #1959: FILE: examples/mp_crypto/mp_crypto_parser.c:77: +int16_t +get_options(int argc, char *argv[]) { WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8) #2425: FILE: examples/mp_crypto/mp_crypto_parser.h:26: + do { \ + printf("%s", color); \ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8) #2432: FILE: examples/mp_crypto/mp_crypto_parser.h:33: + do { \ + printf("%s", color); \ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8) #2439: FILE: examples/mp_crypto/mp_crypto_parser.h:40: + do { \ + printf(" %s", color); \ total: 3 errors, 17 warnings, 2641 lines checked