From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
Subject: [dpdk-test-report] |WARNING| pw72731 [PATCH v3 12/51] net/bnxt: support bulk table get and mirror
Date: Thu, 2 Jul 2020 06:14:53 +0200 (CEST) [thread overview]
Message-ID: <20200702041453.2501E1D5B4@dpdk.org> (raw)
In-Reply-To: <20200702041134.43198-13-ajit.khaparde@broadcom.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/72731
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tfp' - possible side-effects?
#170: FILE: drivers/net/bnxt/tf_core/tf_common.h:10:
+#define TF_CHECK_PARMS_SESSION(tfp, parms) do { \
+ if ((parms) == NULL || (tfp) == NULL) { \
+ TFP_DRV_LOG(ERR, "Invalid Argument(s)
"); \
+ return -EINVAL; \
+ } \
+ if ((tfp)->session == NULL || \
+ (tfp)->session->core_data == NULL) { \
+ TFP_DRV_LOG(ERR, "%s: session error
", \
+ tf_dir_2_str((parms)->dir)); \
+ return -EINVAL; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'parms' - possible side-effects?
#170: FILE: drivers/net/bnxt/tf_core/tf_common.h:10:
+#define TF_CHECK_PARMS_SESSION(tfp, parms) do { \
+ if ((parms) == NULL || (tfp) == NULL) { \
+ TFP_DRV_LOG(ERR, "Invalid Argument(s)
"); \
+ return -EINVAL; \
+ } \
+ if ((tfp)->session == NULL || \
+ (tfp)->session->core_data == NULL) { \
+ TFP_DRV_LOG(ERR, "%s: session error
", \
+ tf_dir_2_str((parms)->dir)); \
+ return -EINVAL; \
+ } \
+ } while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#170: FILE: drivers/net/bnxt/tf_core/tf_common.h:10:
+#define TF_CHECK_PARMS_SESSION(tfp, parms) do { \
+ if ((parms) == NULL || (tfp) == NULL) { \
+ TFP_DRV_LOG(ERR, "Invalid Argument(s)
"); \
+ return -EINVAL; \
+ } \
+ if ((tfp)->session == NULL || \
+ (tfp)->session->core_data == NULL) { \
+ TFP_DRV_LOG(ERR, "%s: session error
", \
+ tf_dir_2_str((parms)->dir)); \
+ return -EINVAL; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tfp' - possible side-effects?
#183: FILE: drivers/net/bnxt/tf_core/tf_common.h:23:
+#define TF_CHECK_PARMS_SESSION_NO_DIR(tfp, parms) do { \
+ if ((parms) == NULL || (tfp) == NULL) { \
+ TFP_DRV_LOG(ERR, "Invalid Argument(s)
"); \
+ return -EINVAL; \
+ } \
+ if ((tfp)->session == NULL || \
+ (tfp)->session->core_data == NULL) { \
+ TFP_DRV_LOG(ERR, "Session error
"); \
+ return -EINVAL; \
+ } \
+ } while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#183: FILE: drivers/net/bnxt/tf_core/tf_common.h:23:
+#define TF_CHECK_PARMS_SESSION_NO_DIR(tfp, parms) do { \
+ if ((parms) == NULL || (tfp) == NULL) { \
+ TFP_DRV_LOG(ERR, "Invalid Argument(s)
"); \
+ return -EINVAL; \
+ } \
+ if ((tfp)->session == NULL || \
+ (tfp)->session->core_data == NULL) { \
+ TFP_DRV_LOG(ERR, "Session error
"); \
+ return -EINVAL; \
+ } \
+ } while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#195: FILE: drivers/net/bnxt/tf_core/tf_common.h:35:
+#define TF_CHECK_PARMS(tfp, parms) do { \
+ if ((parms) == NULL || (tfp) == NULL) { \
+ TFP_DRV_LOG(ERR, "Invalid Argument(s)
"); \
+ return -EINVAL; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tfp' - possible side-effects?
#202: FILE: drivers/net/bnxt/tf_core/tf_common.h:42:
+#define TF_CHECK_TFP_SESSION(tfp) do { \
+ if ((tfp) == NULL) { \
+ TFP_DRV_LOG(ERR, "Invalid Argument(s)
"); \
+ return -EINVAL; \
+ } \
+ if ((tfp)->session == NULL || \
+ (tfp)->session->core_data == NULL) { \
+ TFP_DRV_LOG(ERR, "Session error
"); \
+ return -EINVAL; \
+ } \
+ } while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#202: FILE: drivers/net/bnxt/tf_core/tf_common.h:42:
+#define TF_CHECK_TFP_SESSION(tfp) do { \
+ if ((tfp) == NULL) { \
+ TFP_DRV_LOG(ERR, "Invalid Argument(s)
"); \
+ return -EINVAL; \
+ } \
+ if ((tfp)->session == NULL || \
+ (tfp)->session->core_data == NULL) { \
+ TFP_DRV_LOG(ERR, "Session error
"); \
+ return -EINVAL; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tfp' - possible side-effects?
#384: FILE: drivers/net/bnxt/tf_core/tf_msg.c:1282:
+#define NUM_SLICES(tfp, bytes) \
+ (((bytes) + TF_BYTES_PER_SLICE(tfp) - 1) / TF_BYTES_PER_SLICE(tfp))
total: 0 errors, 4 warnings, 5 checks, 461 lines checked
parent reply other threads:[~2020-07-02 4:14 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200702041134.43198-13-ajit.khaparde@broadcom.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702041453.2501E1D5B4@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=ajit.khaparde@broadcom.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).