From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Zhike Wang <wangzhike@jd.com>
Subject: [dpdk-test-report] |WARNING| pw72938 [PATCH] net/pcap: support snaplen option to truncate packet
Date: Fri, 3 Jul 2020 08:20:42 +0200 (CEST) [thread overview]
Message-ID: <20200703062042.9B6131D9D2@dpdk.org> (raw)
In-Reply-To: <1593757152-4113-1-git-send-email-wangzhike@jd.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/72938
_coding style issues_
WARNING:TYPO_SPELLING: 'convinient' may be misspelled - perhaps 'convenient'?
#59:
Introduced "snaplen=<length>" option. It is convinient to truncate
WARNING:LONG_LINE: line over 90 characters
#135: FILE: app/pdump/main.c:713:
+ snprintf(vdev_args + strlen(vdev_args), sizeof(vdev_args) - strlen(vdev_args),
WARNING:LONG_LINE: line over 90 characters
#144: FILE: app/pdump/main.c:745:
+ snprintf(vdev_args + strlen(vdev_args), sizeof(vdev_args) - strlen(vdev_args),
WARNING:LONG_LINE: line over 90 characters
#153: FILE: app/pdump/main.c:787:
+ snprintf(vdev_args + strlen(vdev_args), sizeof(vdev_args) - strlen(vdev_args),
WARNING:LONG_LINE: line over 90 characters
#162: FILE: app/pdump/main.c:826:
+ snprintf(vdev_args + strlen(vdev_args), sizeof(vdev_args) - strlen(vdev_args),
ERROR:CODE_INDENT: code indent should use tabs where possible
#207: FILE: drivers/net/pcap/rte_eth_pcap.c:346:
+ if ((pp->snaplen > 0) && (caplen > pp->snaplen))$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#207: FILE: drivers/net/pcap/rte_eth_pcap.c:346:
+ if ((pp->snaplen > 0) && (caplen > pp->snaplen))$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23)
#207: FILE: drivers/net/pcap/rte_eth_pcap.c:346:
+ if ((pp->snaplen > 0) && (caplen > pp->snaplen))
+ caplen = pp->snaplen;
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pp->snaplen > 0'
#207: FILE: drivers/net/pcap/rte_eth_pcap.c:346:
+ if ((pp->snaplen > 0) && (caplen > pp->snaplen))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'caplen > pp->snaplen'
#207: FILE: drivers/net/pcap/rte_eth_pcap.c:346:
+ if ((pp->snaplen > 0) && (caplen > pp->snaplen))
ERROR:CODE_INDENT: code indent should use tabs where possible
#208: FILE: drivers/net/pcap/rte_eth_pcap.c:347:
+ caplen = pp->snaplen;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#208: FILE: drivers/net/pcap/rte_eth_pcap.c:347:
+ caplen = pp->snaplen;$
total: 2 errors, 8 warnings, 2 checks, 186 lines checked
next parent reply other threads:[~2020-07-03 6:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1593757152-4113-1-git-send-email-wangzhike@jd.com>
2020-07-03 6:20 ` checkpatch [this message]
2020-07-03 11:13 ` [dpdk-test-report] |WARNING| pw72938 " 0-day Robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200703062042.9B6131D9D2@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=wangzhike@jd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).