From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C1995A0519
	for <public@inbox.dpdk.org>; Fri,  3 Jul 2020 08:20:44 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id A50241D9A6;
	Fri,  3 Jul 2020 08:20:44 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 9B6131D9D2; Fri,  3 Jul 2020 08:20:42 +0200 (CEST)
In-Reply-To: <1593757152-4113-1-git-send-email-wangzhike@jd.com>
References: <1593757152-4113-1-git-send-email-wangzhike@jd.com>
To: test-report@dpdk.org
Cc: Zhike Wang <wangzhike@jd.com>
Message-Id: <20200703062042.9B6131D9D2@dpdk.org>
Date: Fri,  3 Jul 2020 08:20:42 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw72938 [PATCH] net/pcap: support
	snaplen option to truncate packet
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/72938

_coding style issues_


WARNING:TYPO_SPELLING: 'convinient' may be misspelled - perhaps 'convenient'?
#59: 
Introduced "snaplen=<length>" option. It is convinient to truncate

WARNING:LONG_LINE: line over 90 characters
#135: FILE: app/pdump/main.c:713:
+			snprintf(vdev_args + strlen(vdev_args), sizeof(vdev_args) - strlen(vdev_args),

WARNING:LONG_LINE: line over 90 characters
#144: FILE: app/pdump/main.c:745:
+				snprintf(vdev_args + strlen(vdev_args), sizeof(vdev_args) - strlen(vdev_args),

WARNING:LONG_LINE: line over 90 characters
#153: FILE: app/pdump/main.c:787:
+			snprintf(vdev_args + strlen(vdev_args), sizeof(vdev_args) - strlen(vdev_args),

WARNING:LONG_LINE: line over 90 characters
#162: FILE: app/pdump/main.c:826:
+			snprintf(vdev_args + strlen(vdev_args), sizeof(vdev_args) - strlen(vdev_args),

ERROR:CODE_INDENT: code indent should use tabs where possible
#207: FILE: drivers/net/pcap/rte_eth_pcap.c:346:
+               if ((pp->snaplen > 0) && (caplen > pp->snaplen))$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#207: FILE: drivers/net/pcap/rte_eth_pcap.c:346:
+               if ((pp->snaplen > 0) && (caplen > pp->snaplen))$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23)
#207: FILE: drivers/net/pcap/rte_eth_pcap.c:346:
+               if ((pp->snaplen > 0) && (caplen > pp->snaplen))
+                       caplen = pp->snaplen;

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pp->snaplen > 0'
#207: FILE: drivers/net/pcap/rte_eth_pcap.c:346:
+               if ((pp->snaplen > 0) && (caplen > pp->snaplen))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'caplen > pp->snaplen'
#207: FILE: drivers/net/pcap/rte_eth_pcap.c:346:
+               if ((pp->snaplen > 0) && (caplen > pp->snaplen))

ERROR:CODE_INDENT: code indent should use tabs where possible
#208: FILE: drivers/net/pcap/rte_eth_pcap.c:347:
+                       caplen = pp->snaplen;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#208: FILE: drivers/net/pcap/rte_eth_pcap.c:347:
+                       caplen = pp->snaplen;$

total: 2 errors, 8 warnings, 2 checks, 186 lines checked