automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Subject: [dpdk-test-report] |WARNING| pw73263 [PATCH v3] crypto/qat: add handling of multi process
Date: Mon,  6 Jul 2020 19:22:56 +0200 (CEST)	[thread overview]
Message-ID: <20200706172256.A19E61DB5B@dpdk.org> (raw)
In-Reply-To: <20200706171925.7092-1-arkadiuszx.kusztal@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/73263

_coding style issues_

Must be a reply to the first patch (--in-reply-to).


WARNING:TYPO_SPELLING: 'uint' may be misspelled - perhaps 'unit'?
#152: FILE: drivers/common/qat/qat_device.c:85:
+		uint8_t dev_id;

WARNING:TYPO_SPELLING: 'uint' may be misspelled - perhaps 'unit'?
#173: FILE: drivers/common/qat/qat_device.c:167:
+	uint8_t qat_dev_id = 0;

WARNING:TYPO_SPELLING: 'uint' may be misspelled - perhaps 'unit'?
#514: FILE: drivers/compress/qat/qat_comp_pmd.c:674:
+	uint64_t capa_size;

WARNING:TYPO_SPELLING: 'uint' may be misspelled - perhaps 'unit'?
#649: FILE: drivers/crypto/qat/qat_asym_pmd.c:14:
+uint8_t qat_asym_driver_id;

WARNING:TYPO_SPELLING: 'uint' may be misspelled - perhaps 'unit'?
#800: FILE: drivers/crypto/qat/qat_asym_pmd.h:16:
+extern uint8_t qat_asym_driver_id;

WARNING:TYPO_SPELLING: 'uint' may be misspelled - perhaps 'unit'?
#848: FILE: drivers/crypto/qat/qat_sym_pmd.c:22:
+uint8_t qat_sym_driver_id;

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#857: FILE: drivers/crypto/qat/qat_sym_pmd.c:36:
+       QAT_BASE_GEN1_SYM_CAPABILITIES,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#858: FILE: drivers/crypto/qat/qat_sym_pmd.c:37:
+       QAT_EXTRA_GEN2_SYM_CAPABILITIES,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#859: FILE: drivers/crypto/qat/qat_sym_pmd.c:38:
+       RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST()$

ERROR:CODE_INDENT: code indent should use tabs where possible
#879: FILE: drivers/crypto/qat/qat_sym_pmd.c:314:
+                       &qat_pci_devs[qat_pci_dev->qat_dev_id];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#879: FILE: drivers/crypto/qat/qat_sym_pmd.c:314:
+                       &qat_pci_devs[qat_pci_dev->qat_dev_id];$

WARNING:TYPO_SPELLING: 'uint' may be misspelled - perhaps 'unit'?
#893: FILE: drivers/crypto/qat/qat_sym_pmd.c:327:
+	uint64_t capa_size;

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#895: FILE: drivers/crypto/qat/qat_sym_pmd.c:329:
+	/*
+	* All processes must use same driver id so they can share sessions.

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1008: FILE: drivers/crypto/qat/qat_sym_pmd.c:450:
+       memcpy(internals->capa_mz->addr, capabilities, capa_size);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1009: FILE: drivers/crypto/qat/qat_sym_pmd.c:451:
+       internals->qat_dev_capabilities = internals->capa_mz->addr;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1029: FILE: drivers/crypto/qat/qat_sym_pmd.c:478:
+       if (rte_eal_process_type() == RTE_PROC_PRIMARY)$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#1029: FILE: drivers/crypto/qat/qat_sym_pmd.c:478:
+       if (rte_eal_process_type() == RTE_PROC_PRIMARY)
+               rte_memzone_free(qat_pci_dev->sym_dev->capa_mz);

ERROR:CODE_INDENT: code indent should use tabs where possible
#1030: FILE: drivers/crypto/qat/qat_sym_pmd.c:479:
+               rte_memzone_free(qat_pci_dev->sym_dev->capa_mz);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1030: FILE: drivers/crypto/qat/qat_sym_pmd.c:479:
+               rte_memzone_free(qat_pci_dev->sym_dev->capa_mz);$

WARNING:TYPO_SPELLING: 'uint' may be misspelled - perhaps 'unit'?
#1058: FILE: drivers/crypto/qat/qat_sym_pmd.h:26:
+extern uint8_t qat_sym_driver_id;

total: 2 errors, 18 warnings, 885 lines checked

           reply	other threads:[~2020-07-06 17:22 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20200706171925.7092-1-arkadiuszx.kusztal@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200706172256.A19E61DB5B@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=arkadiuszx.kusztal@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).