From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Rasesh Mody <rmody@marvell.com>
Subject: [dpdk-test-report] |WARNING| pw73565 [PATCH v5 3/4] net/qede: add infrastructure for debug data collection
Date: Thu, 9 Jul 2020 00:53:24 +0200 (CEST) [thread overview]
Message-ID: <20200708225324.91E361E545@dpdk.org> (raw)
In-Reply-To: <20200708225054.19665-4-rmody@marvell.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/73565
_coding style issues_
WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'?
#178: FILE: drivers/net/qede/qede_debug.c:11:
+#include "base/ecore_hsi_common.h"
WARNING:TYPO_SPELLING: '2ST' may be misspelled - perhaps '2nd'?
#371: FILE: drivers/net/qede/qede_debug.c:204:
+ DBG_BUS_FRAME_MODE_2ST_2HW = 1, /* 2 Storm dwords, 2 HW dwords */
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'field' - possible side-effects?
#506: FILE: drivers/net/qede/qede_debug.c:339:
+#define FIELD_BIT_MASK(type, field) \
+ (((1 << FIELD_BIT_SIZE(type, field)) - 1) << \
+ FIELD_DWORD_SHIFT(type, field))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'var' - possible side-effects?
#510: FILE: drivers/net/qede/qede_debug.c:343:
+#define SET_VAR_FIELD(var, type, field, val) \
+ do { \
+ var[FIELD_DWORD_OFFSET(type, field)] &= \
+ (~FIELD_BIT_MASK(type, field)); \
+ var[FIELD_DWORD_OFFSET(type, field)] |= \
+ (val) << FIELD_DWORD_SHIFT(type, field); \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'field' - possible side-effects?
#510: FILE: drivers/net/qede/qede_debug.c:343:
+#define SET_VAR_FIELD(var, type, field, val) \
+ do { \
+ var[FIELD_DWORD_OFFSET(type, field)] &= \
+ (~FIELD_BIT_MASK(type, field)); \
+ var[FIELD_DWORD_OFFSET(type, field)] |= \
+ (val) << FIELD_DWORD_SHIFT(type, field); \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'block' - possible side-effects?
#530: FILE: drivers/net/qede/qede_debug.c:363:
+#define NUM_DBG_LINES(block) \
+ ((block)->num_of_dbg_bus_lines + NUM_EXTRA_DBG_LINES(block))
WARNING:TYPO_SPELLING: 'UNSTALL' may be misspelled - perhaps 'INSTALL'?
#842: FILE: drivers/net/qede/qede_debug.c:675:
+ /* DBG_GRC_PARAM_UNSTALL */
WARNING:TYPO_SPELLING: 'Unstall' may be misspelled - perhaps 'Install'?
#3709: FILE: drivers/net/qede/qede_debug.c:3542:
+ /* Unstall storms */
WARNING:TYPO_SPELLING: 'UNSTALL' may be misspelled - perhaps 'INSTALL'?
#3710: FILE: drivers/net/qede/qede_debug.c:3543:
+ if (qed_grc_get_param(p_hwfn, DBG_GRC_PARAM_UNSTALL))
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#5624: FILE: drivers/net/qede/qede_debug.c:5457:
+#define REG_FIFO_ELEMENT_MASTER_SHIFT 43
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#5625: FILE: drivers/net/qede/qede_debug.c:5458:
+#define REG_FIFO_ELEMENT_MASTER_MASK 0xf
WARNING:TYPO_SPELLING: 'CANT' may be misspelled - perhaps 'CAN'T'?
#5814: FILE: drivers/net/qede/qede_debug.c:5647:
+ /* DBG_STATUS_CANT_ADD_CONSTRAINT */
WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'?
#5969: FILE: drivers/net/qede/qede_debug.c:5802:
+/* Master type names array */
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#5970: FILE: drivers/net/qede/qede_debug.c:5803:
+static const char * const s_master_strs[] = {
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#6909: FILE: drivers/net/qede/qede_debug.c:6742:
+ "raw: 0x%016lx, address: 0x%07x, access: %-5s, pf: %2d, vf: %s, port: %d, privilege: %-3s, protection: %-12s, master: %-4s, error: %s
",
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#6925: FILE: drivers/net/qede/qede_debug.c:6758:
+ s_master_strs[GET_FIELD(elements[i].data,
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#6926: FILE: drivers/net/qede/qede_debug.c:6759:
+ REG_FIFO_ELEMENT_MASTER)],
WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'?
#7761: FILE: drivers/net/qede/qede_debug.c:7594:
+ /* Get buffer size from hsi, allocate accordingly, and perform the
total: 0 errors, 14 warnings, 4 checks, 9037 lines checked
parent reply other threads:[~2020-07-08 22:53 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200708225054.19665-4-rmody@marvell.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708225324.91E361E545@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=rmody@marvell.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).