From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-test-report] |WARNING| pw73982 [PATCH v4 06/11] eal: replace pci-whitelist/pci-blacklist options
Date: Tue, 14 Jul 2020 07:41:17 +0200 (CEST) [thread overview]
Message-ID: <20200714054117.D96431D165@dpdk.org> (raw)
In-Reply-To: <20200714053919.5609-7-stephen@networkplumber.org>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/73982
_coding style issues_
WARNING:TYPO_SPELLING: 'whitelist' may be misspelled - perhaps 'allowlist'?
#81:
Replace pci-whitelist with pci-include and pci-blacklist with
WARNING:TYPO_SPELLING: 'blacklist' may be misspelled - perhaps 'blocklist'?
#81:
Replace pci-whitelist with pci-include and pci-blacklist with
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#127: FILE: lib/librte_eal/common/eal_common_options.c:92:
+^I{OPT_PCI_EXCLUDE, ^I1, NULL, OPT_PCI_EXCLUDE_NUM^I },$
WARNING:TYPO_SPELLING: 'BLACKLIST' may be misspelled - perhaps 'BLOCKLIST'?
#138: FILE: lib/librte_eal/common/eal_common_options.c:109:
+ {OPT_PCI_BLACKLIST, 1, NULL, OPT_PCI_BLACKLIST_NUM },
WARNING:TYPO_SPELLING: 'BLACKLIST' may be misspelled - perhaps 'BLOCKLIST'?
#138: FILE: lib/librte_eal/common/eal_common_options.c:109:
+ {OPT_PCI_BLACKLIST, 1, NULL, OPT_PCI_BLACKLIST_NUM },
WARNING:TYPO_SPELLING: 'WHITELIST' may be misspelled - perhaps 'ALLOWLIST'?
#139: FILE: lib/librte_eal/common/eal_common_options.c:110:
+ {OPT_PCI_WHITELIST, 1, NULL, OPT_PCI_WHITELIST_NUM },
WARNING:TYPO_SPELLING: 'WHITELIST' may be misspelled - perhaps 'ALLOWLIST'?
#139: FILE: lib/librte_eal/common/eal_common_options.c:110:
+ {OPT_PCI_WHITELIST, 1, NULL, OPT_PCI_WHITELIST_NUM },
WARNING:TYPO_SPELLING: 'blacklist' may be misspelled - perhaps 'blocklist'?
#159: FILE: lib/librte_eal/common/eal_common_options.c:1429:
+ fprintf(stderr, "Option -b, --blacklist is deprecated, use -x, --pci-exclude option instead
");
WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#160: FILE: lib/librte_eal/common/eal_common_options.c:1430:
+ /* fallthrough */
WARNING:TYPO_SPELLING: 'whitelist' may be misspelled - perhaps 'allowlist'?
#178: FILE: lib/librte_eal/common/eal_common_options.c:1443:
+ fprintf(stderr, "Option -w, --whitelist is deprecated, use -i, --pci-include option instead
");
WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#179: FILE: lib/librte_eal/common/eal_common_options.c:1444:
+ /* fallthrough */
WARNING:LONG_LINE: line over 100 characters
#221: FILE: lib/librte_eal/common/eal_common_options.c:1951:
+ " [NOTE: " OPT_PCI_INCLUDE " cannot be used with "OPT_PCI_EXCLUDE" option]
"
ERROR:TRAILING_WHITESPACE: trailing whitespace
#244: FILE: lib/librte_eal/common/eal_options.h:26:
+^I$
total: 1 errors, 12 warnings, 139 lines checked
parent reply other threads:[~2020-07-14 5:41 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200714053919.5609-7-stephen@networkplumber.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714054117.D96431D165@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).