automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
Subject: [dpdk-test-report] |WARNING| pw75524 [PATCH 08/22] doc: remove lower bound on mapped address from Windows UIO driver
Date: Fri, 14 Aug 2020 01:23:50 +0200 (CEST)	[thread overview]
Message-ID: <20200813232350.7E08F1C0D5@dpdk.org> (raw)
In-Reply-To: <1597360905-74106-9-git-send-email-navasile@linux.microsoft.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/75524

_coding style issues_


WARNING:LEADING_SPACE: please, no spaces at the start of a line
#69: FILE: kernel/windows/netuio/netuio_dev.c:31:
+    WDFDEVICE device = NULL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#76: FILE: kernel/windows/netuio/netuio_dev.c:36:
+    // Ensure that only administrators can access our device object.$

ERROR:C99_COMMENTS: do not use C99 // comments
#76: FILE: kernel/windows/netuio/netuio_dev.c:36:
+    // Ensure that only administrators can access our device object.

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#77: FILE: kernel/windows/netuio/netuio_dev.c:37:
+    status = WdfDeviceInitAssignSDDLString(DeviceInit, &SDDL_DEVOBJ_SYS_ALL_ADM_ALL);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#81: FILE: kernel/windows/netuio/netuio_dev.c:39:
+    if (NT_SUCCESS(status)) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#82: FILE: kernel/windows/netuio/netuio_dev.c:40:
+        WDF_OBJECT_ATTRIBUTES_INIT_CONTEXT_TYPE(&deviceAttributes, NETUIO_CONTEXT_DATA);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#82: FILE: kernel/windows/netuio/netuio_dev.c:40:
+        WDF_OBJECT_ATTRIBUTES_INIT_CONTEXT_TYPE(&deviceAttributes, NETUIO_CONTEXT_DATA);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#87: FILE: kernel/windows/netuio/netuio_dev.c:42:
+        // Set the device context cleanup callback.$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#87: FILE: kernel/windows/netuio/netuio_dev.c:42:
+        // Set the device context cleanup callback.$

ERROR:C99_COMMENTS: do not use C99 // comments
#87: FILE: kernel/windows/netuio/netuio_dev.c:42:
+        // Set the device context cleanup callback.

WARNING:LONG_LINE_COMMENT: line over 100 characters
#88: FILE: kernel/windows/netuio/netuio_dev.c:43:
+        // This function will be called when the WDF Device Object associated to the current device is destroyed

ERROR:CODE_INDENT: code indent should use tabs where possible
#88: FILE: kernel/windows/netuio/netuio_dev.c:43:
+        // This function will be called when the WDF Device Object associated to the current device is destroyed$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#88: FILE: kernel/windows/netuio/netuio_dev.c:43:
+        // This function will be called when the WDF Device Object associated to the current device is destroyed$

ERROR:C99_COMMENTS: do not use C99 // comments
#88: FILE: kernel/windows/netuio/netuio_dev.c:43:
+        // This function will be called when the WDF Device Object associated to the current device is destroyed

ERROR:CODE_INDENT: code indent should use tabs where possible
#89: FILE: kernel/windows/netuio/netuio_dev.c:44:
+        deviceAttributes.EvtCleanupCallback = netuio_evt_device_context_cleanup;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#89: FILE: kernel/windows/netuio/netuio_dev.c:44:
+        deviceAttributes.EvtCleanupCallback = netuio_evt_device_context_cleanup;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#93: FILE: kernel/windows/netuio/netuio_dev.c:46:
+        status = WdfDeviceCreate(&DeviceInit, &deviceAttributes, &device);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#93: FILE: kernel/windows/netuio/netuio_dev.c:46:
+        status = WdfDeviceCreate(&DeviceInit, &deviceAttributes, &device);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#94: FILE: kernel/windows/netuio/netuio_dev.c:47:
+    }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#103: FILE: kernel/windows/netuio/netuio_dev.c:266:
+    lowest_acceptable_address.QuadPart = 0x0000000000000000;$

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 9 errors, 12 warnings, 41 lines checked

           reply	other threads:[~2020-08-13 23:23 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1597360905-74106-9-git-send-email-navasile@linux.microsoft.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200813232350.7E08F1C0D5@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=navasile@linux.microsoft.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).