From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22016A04D8 for ; Fri, 14 Aug 2020 01:23:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A2AD81C114; Fri, 14 Aug 2020 01:23:51 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 7E08F1C0D5; Fri, 14 Aug 2020 01:23:50 +0200 (CEST) In-Reply-To: <1597360905-74106-9-git-send-email-navasile@linux.microsoft.com> References: <1597360905-74106-9-git-send-email-navasile@linux.microsoft.com> To: test-report@dpdk.org Cc: Narcisa Ana Maria Vasile Message-Id: <20200813232350.7E08F1C0D5@dpdk.org> Date: Fri, 14 Aug 2020 01:23:50 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw75524 [PATCH 08/22] doc: remove lower bound on mapped address from Windows UIO driver X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/75524 _coding style issues_ WARNING:LEADING_SPACE: please, no spaces at the start of a line #69: FILE: kernel/windows/netuio/netuio_dev.c:31: + WDFDEVICE device = NULL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #76: FILE: kernel/windows/netuio/netuio_dev.c:36: + // Ensure that only administrators can access our device object.$ ERROR:C99_COMMENTS: do not use C99 // comments #76: FILE: kernel/windows/netuio/netuio_dev.c:36: + // Ensure that only administrators can access our device object. WARNING:LEADING_SPACE: please, no spaces at the start of a line #77: FILE: kernel/windows/netuio/netuio_dev.c:37: + status = WdfDeviceInitAssignSDDLString(DeviceInit, &SDDL_DEVOBJ_SYS_ALL_ADM_ALL);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #81: FILE: kernel/windows/netuio/netuio_dev.c:39: + if (NT_SUCCESS(status)) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #82: FILE: kernel/windows/netuio/netuio_dev.c:40: + WDF_OBJECT_ATTRIBUTES_INIT_CONTEXT_TYPE(&deviceAttributes, NETUIO_CONTEXT_DATA);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #82: FILE: kernel/windows/netuio/netuio_dev.c:40: + WDF_OBJECT_ATTRIBUTES_INIT_CONTEXT_TYPE(&deviceAttributes, NETUIO_CONTEXT_DATA);$ ERROR:CODE_INDENT: code indent should use tabs where possible #87: FILE: kernel/windows/netuio/netuio_dev.c:42: + // Set the device context cleanup callback.$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #87: FILE: kernel/windows/netuio/netuio_dev.c:42: + // Set the device context cleanup callback.$ ERROR:C99_COMMENTS: do not use C99 // comments #87: FILE: kernel/windows/netuio/netuio_dev.c:42: + // Set the device context cleanup callback. WARNING:LONG_LINE_COMMENT: line over 100 characters #88: FILE: kernel/windows/netuio/netuio_dev.c:43: + // This function will be called when the WDF Device Object associated to the current device is destroyed ERROR:CODE_INDENT: code indent should use tabs where possible #88: FILE: kernel/windows/netuio/netuio_dev.c:43: + // This function will be called when the WDF Device Object associated to the current device is destroyed$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #88: FILE: kernel/windows/netuio/netuio_dev.c:43: + // This function will be called when the WDF Device Object associated to the current device is destroyed$ ERROR:C99_COMMENTS: do not use C99 // comments #88: FILE: kernel/windows/netuio/netuio_dev.c:43: + // This function will be called when the WDF Device Object associated to the current device is destroyed ERROR:CODE_INDENT: code indent should use tabs where possible #89: FILE: kernel/windows/netuio/netuio_dev.c:44: + deviceAttributes.EvtCleanupCallback = netuio_evt_device_context_cleanup;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #89: FILE: kernel/windows/netuio/netuio_dev.c:44: + deviceAttributes.EvtCleanupCallback = netuio_evt_device_context_cleanup;$ ERROR:CODE_INDENT: code indent should use tabs where possible #93: FILE: kernel/windows/netuio/netuio_dev.c:46: + status = WdfDeviceCreate(&DeviceInit, &deviceAttributes, &device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #93: FILE: kernel/windows/netuio/netuio_dev.c:46: + status = WdfDeviceCreate(&DeviceInit, &deviceAttributes, &device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #94: FILE: kernel/windows/netuio/netuio_dev.c:47: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #103: FILE: kernel/windows/netuio/netuio_dev.c:266: + lowest_acceptable_address.QuadPart = 0x0000000000000000;$ ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s) total: 9 errors, 12 warnings, 41 lines checked