From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
Subject: [dpdk-test-report] |WARNING| pw75525 [PATCH 10/22] uio: move SDDL string to INF on Windows
Date: Fri, 14 Aug 2020 01:23:51 +0200 (CEST) [thread overview]
Message-ID: <20200813232351.ED6671C1B9@dpdk.org> (raw)
In-Reply-To: <1597360905-74106-11-git-send-email-navasile@linux.microsoft.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/75525
_coding style issues_
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#88: FILE: kernel/windows/netuio/netuio_dev.c:36:
+ WDF_OBJECT_ATTRIBUTES_INIT_CONTEXT_TYPE(&deviceAttributes, NETUIO_CONTEXT_DATA);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#96: FILE: kernel/windows/netuio/netuio_dev.c:38:
+ // Set the device context cleanup callback.$
ERROR:C99_COMMENTS: do not use C99 // comments
#96: FILE: kernel/windows/netuio/netuio_dev.c:38:
+ // Set the device context cleanup callback.
WARNING:LONG_LINE_COMMENT: line over 100 characters
#97: FILE: kernel/windows/netuio/netuio_dev.c:39:
+ // This function will be called when the WDF Device Object associated to the current device is destroyed
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#97: FILE: kernel/windows/netuio/netuio_dev.c:39:
+ // This function will be called when the WDF Device Object associated to the current device is destroyed$
ERROR:C99_COMMENTS: do not use C99 // comments
#97: FILE: kernel/windows/netuio/netuio_dev.c:39:
+ // This function will be called when the WDF Device Object associated to the current device is destroyed
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#98: FILE: kernel/windows/netuio/netuio_dev.c:40:
+ deviceAttributes.EvtCleanupCallback = netuio_evt_device_context_cleanup;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#102: FILE: kernel/windows/netuio/netuio_dev.c:42:
+ status = WdfDeviceCreate(&DeviceInit, &deviceAttributes, &device);$
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 3 errors, 6 warnings, 36 lines checked
parent reply other threads:[~2020-08-13 23:23 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1597360905-74106-11-git-send-email-navasile@linux.microsoft.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813232351.ED6671C1B9@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=navasile@linux.microsoft.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).