From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
Subject: [dpdk-test-report] |WARNING| pw75527 [PATCH 07/22] doc: change the Windows UIO driver's default security descriptor to admin only
Date: Fri, 14 Aug 2020 01:25:35 +0200 (CEST) [thread overview]
Message-ID: <20200813232535.571961C124@dpdk.org> (raw)
In-Reply-To: <1597360905-74106-8-git-send-email-navasile@linux.microsoft.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/75527
_coding style issues_
ERROR:C99_COMMENTS: do not use C99 // comments
#73: FILE: kernel/windows/netuio/netuio_dev.c:36:
+ // Ensure that only administrators can access our device object.
ERROR:C99_COMMENTS: do not use C99 // comments
#83: FILE: kernel/windows/netuio/netuio_dev.c:42:
+ // Set the device context cleanup callback.
WARNING:LONG_LINE_COMMENT: line over 100 characters
#84: FILE: kernel/windows/netuio/netuio_dev.c:43:
+ // This function will be called when the WDF Device Object associated to the current device is destroyed
ERROR:C99_COMMENTS: do not use C99 // comments
#84: FILE: kernel/windows/netuio/netuio_dev.c:43:
+ // This function will be called when the WDF Device Object associated to the current device is destroyed
ERROR:C99_COMMENTS: do not use C99 // comments
#99: FILE: kernel/windows/netuio/netuio_dev.c:50:
+ // Create a device interface so that applications can find and talk to us.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#107: FILE: kernel/windows/netuio/netuio_dev.c:54:
+ if (NT_SUCCESS(status)) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#108: FILE: kernel/windows/netuio/netuio_dev.c:55:
+ // Retrieve and store PCI information$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#108: FILE: kernel/windows/netuio/netuio_dev.c:55:
+ // Retrieve and store PCI information$
ERROR:C99_COMMENTS: do not use C99 // comments
#108: FILE: kernel/windows/netuio/netuio_dev.c:55:
+ // Retrieve and store PCI information
ERROR:CODE_INDENT: code indent should use tabs where possible
#109: FILE: kernel/windows/netuio/netuio_dev.c:56:
+ status = get_pci_device_info(device);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#109: FILE: kernel/windows/netuio/netuio_dev.c:56:
+ status = get_pci_device_info(device);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#110: FILE: kernel/windows/netuio/netuio_dev.c:57:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#116: FILE: kernel/windows/netuio/netuio_dev.c:59:
+ if (NT_SUCCESS(status)) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#117: FILE: kernel/windows/netuio/netuio_dev.c:60:
+ // Create a symbolic link name for user-space access$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#117: FILE: kernel/windows/netuio/netuio_dev.c:60:
+ // Create a symbolic link name for user-space access$
ERROR:C99_COMMENTS: do not use C99 // comments
#117: FILE: kernel/windows/netuio/netuio_dev.c:60:
+ // Create a symbolic link name for user-space access
ERROR:CODE_INDENT: code indent should use tabs where possible
#118: FILE: kernel/windows/netuio/netuio_dev.c:61:
+ status = create_device_specific_symbolic_link(device);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#118: FILE: kernel/windows/netuio/netuio_dev.c:61:
+ status = create_device_specific_symbolic_link(device);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#119: FILE: kernel/windows/netuio/netuio_dev.c:62:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#121: FILE: kernel/windows/netuio/netuio_dev.c:64:
+ if (NT_SUCCESS(status)) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#122: FILE: kernel/windows/netuio/netuio_dev.c:65:
+ // Initialize the I/O Package and any Queues$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#122: FILE: kernel/windows/netuio/netuio_dev.c:65:
+ // Initialize the I/O Package and any Queues$
ERROR:C99_COMMENTS: do not use C99 // comments
#122: FILE: kernel/windows/netuio/netuio_dev.c:65:
+ // Initialize the I/O Package and any Queues
ERROR:CODE_INDENT: code indent should use tabs where possible
#123: FILE: kernel/windows/netuio/netuio_dev.c:66:
+ status = netuio_queue_initialize(device);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#123: FILE: kernel/windows/netuio/netuio_dev.c:66:
+ status = netuio_queue_initialize(device);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#124: FILE: kernel/windows/netuio/netuio_dev.c:67:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#126: FILE: kernel/windows/netuio/netuio_dev.c:69:
+ if (NT_SUCCESS(status)) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#127: FILE: kernel/windows/netuio/netuio_dev.c:70:
+ // Allocate physically contiguous memory for user process use. We'll map it later$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#127: FILE: kernel/windows/netuio/netuio_dev.c:70:
+ // Allocate physically contiguous memory for user process use. We'll map it later$
ERROR:C99_COMMENTS: do not use C99 // comments
#127: FILE: kernel/windows/netuio/netuio_dev.c:70:
+ // Allocate physically contiguous memory for user process use. We'll map it later
ERROR:CODE_INDENT: code indent should use tabs where possible
#128: FILE: kernel/windows/netuio/netuio_dev.c:71:
+ status = allocate_usermemory_segment(device);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#128: FILE: kernel/windows/netuio/netuio_dev.c:71:
+ status = allocate_usermemory_segment(device);$
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 17 errors, 16 warnings, 67 lines checked
parent reply other threads:[~2020-08-13 23:25 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1597360905-74106-8-git-send-email-navasile@linux.microsoft.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813232535.571961C124@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=navasile@linux.microsoft.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).