From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32C6EA04B1 for ; Fri, 14 Aug 2020 01:25:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0FAC21C11F; Fri, 14 Aug 2020 01:25:37 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 571961C124; Fri, 14 Aug 2020 01:25:35 +0200 (CEST) In-Reply-To: <1597360905-74106-8-git-send-email-navasile@linux.microsoft.com> References: <1597360905-74106-8-git-send-email-navasile@linux.microsoft.com> To: test-report@dpdk.org Cc: Narcisa Ana Maria Vasile Message-Id: <20200813232535.571961C124@dpdk.org> Date: Fri, 14 Aug 2020 01:25:35 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw75527 [PATCH 07/22] doc: change the Windows UIO driver's default security descriptor to admin only X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/75527 _coding style issues_ ERROR:C99_COMMENTS: do not use C99 // comments #73: FILE: kernel/windows/netuio/netuio_dev.c:36: + // Ensure that only administrators can access our device object. ERROR:C99_COMMENTS: do not use C99 // comments #83: FILE: kernel/windows/netuio/netuio_dev.c:42: + // Set the device context cleanup callback. WARNING:LONG_LINE_COMMENT: line over 100 characters #84: FILE: kernel/windows/netuio/netuio_dev.c:43: + // This function will be called when the WDF Device Object associated to the current device is destroyed ERROR:C99_COMMENTS: do not use C99 // comments #84: FILE: kernel/windows/netuio/netuio_dev.c:43: + // This function will be called when the WDF Device Object associated to the current device is destroyed ERROR:C99_COMMENTS: do not use C99 // comments #99: FILE: kernel/windows/netuio/netuio_dev.c:50: + // Create a device interface so that applications can find and talk to us. WARNING:LEADING_SPACE: please, no spaces at the start of a line #107: FILE: kernel/windows/netuio/netuio_dev.c:54: + if (NT_SUCCESS(status)) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #108: FILE: kernel/windows/netuio/netuio_dev.c:55: + // Retrieve and store PCI information$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #108: FILE: kernel/windows/netuio/netuio_dev.c:55: + // Retrieve and store PCI information$ ERROR:C99_COMMENTS: do not use C99 // comments #108: FILE: kernel/windows/netuio/netuio_dev.c:55: + // Retrieve and store PCI information ERROR:CODE_INDENT: code indent should use tabs where possible #109: FILE: kernel/windows/netuio/netuio_dev.c:56: + status = get_pci_device_info(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #109: FILE: kernel/windows/netuio/netuio_dev.c:56: + status = get_pci_device_info(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #110: FILE: kernel/windows/netuio/netuio_dev.c:57: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #116: FILE: kernel/windows/netuio/netuio_dev.c:59: + if (NT_SUCCESS(status)) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #117: FILE: kernel/windows/netuio/netuio_dev.c:60: + // Create a symbolic link name for user-space access$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #117: FILE: kernel/windows/netuio/netuio_dev.c:60: + // Create a symbolic link name for user-space access$ ERROR:C99_COMMENTS: do not use C99 // comments #117: FILE: kernel/windows/netuio/netuio_dev.c:60: + // Create a symbolic link name for user-space access ERROR:CODE_INDENT: code indent should use tabs where possible #118: FILE: kernel/windows/netuio/netuio_dev.c:61: + status = create_device_specific_symbolic_link(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #118: FILE: kernel/windows/netuio/netuio_dev.c:61: + status = create_device_specific_symbolic_link(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #119: FILE: kernel/windows/netuio/netuio_dev.c:62: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #121: FILE: kernel/windows/netuio/netuio_dev.c:64: + if (NT_SUCCESS(status)) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #122: FILE: kernel/windows/netuio/netuio_dev.c:65: + // Initialize the I/O Package and any Queues$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #122: FILE: kernel/windows/netuio/netuio_dev.c:65: + // Initialize the I/O Package and any Queues$ ERROR:C99_COMMENTS: do not use C99 // comments #122: FILE: kernel/windows/netuio/netuio_dev.c:65: + // Initialize the I/O Package and any Queues ERROR:CODE_INDENT: code indent should use tabs where possible #123: FILE: kernel/windows/netuio/netuio_dev.c:66: + status = netuio_queue_initialize(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #123: FILE: kernel/windows/netuio/netuio_dev.c:66: + status = netuio_queue_initialize(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #124: FILE: kernel/windows/netuio/netuio_dev.c:67: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #126: FILE: kernel/windows/netuio/netuio_dev.c:69: + if (NT_SUCCESS(status)) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #127: FILE: kernel/windows/netuio/netuio_dev.c:70: + // Allocate physically contiguous memory for user process use. We'll map it later$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #127: FILE: kernel/windows/netuio/netuio_dev.c:70: + // Allocate physically contiguous memory for user process use. We'll map it later$ ERROR:C99_COMMENTS: do not use C99 // comments #127: FILE: kernel/windows/netuio/netuio_dev.c:70: + // Allocate physically contiguous memory for user process use. We'll map it later ERROR:CODE_INDENT: code indent should use tabs where possible #128: FILE: kernel/windows/netuio/netuio_dev.c:71: + status = allocate_usermemory_segment(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #128: FILE: kernel/windows/netuio/netuio_dev.c:71: + status = allocate_usermemory_segment(device);$ ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s) total: 17 errors, 16 warnings, 67 lines checked