* [dpdk-test-report] |WARNING| pw75530 [PATCH 09/22] doc: remove embedded buffer from Windows UIO ioctl
[not found] <1597360905-74106-10-git-send-email-navasile@linux.microsoft.com>
@ 2020-08-13 23:25 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-08-13 23:25 UTC (permalink / raw)
To: test-report; +Cc: Narcisa Ana Maria Vasile
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/75530
_coding style issues_
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#72: FILE: kernel/windows/netuio/netuio_interface.h:64:
+ UINT32 access_size; // 1, 2, 4, or 8 bytes$
ERROR:C99_COMMENTS: do not use C99 // comments
#72: FILE: kernel/windows/netuio/netuio_interface.h:64:
+ UINT32 access_size; // 1, 2, 4, or 8 bytes
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#74: FILE: kernel/windows/netuio/netuio_interface.h:66:
+ union dpdk_pci_config_io_data {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#75: FILE: kernel/windows/netuio/netuio_interface.h:67:
+ UINT8^I^I^Iu8;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#75: FILE: kernel/windows/netuio/netuio_interface.h:67:
+ UINT8^I^I^Iu8;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#76: FILE: kernel/windows/netuio/netuio_interface.h:68:
+ UINT16^I^I^Iu16;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#76: FILE: kernel/windows/netuio/netuio_interface.h:68:
+ UINT16^I^I^Iu16;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#77: FILE: kernel/windows/netuio/netuio_interface.h:69:
+ UINT32^I^I^Iu32;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#77: FILE: kernel/windows/netuio/netuio_interface.h:69:
+ UINT32^I^I^Iu32;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#78: FILE: kernel/windows/netuio/netuio_interface.h:70:
+ UINT64^I^I^Iu64;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#78: FILE: kernel/windows/netuio/netuio_interface.h:70:
+ UINT64^I^I^Iu64;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#79: FILE: kernel/windows/netuio/netuio_interface.h:71:
+ } data;$
WARNING:LONG_LINE: line over 100 characters
#92: FILE: kernel/windows/netuio/netuio_queue.c:14:
+VOID netuio_read_PCI_config(PNETUIO_CONTEXT_DATA netuio_contextdata, ULONG offset, UINT32 access_size, _Out_ UINT64 *output)
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#94: FILE: kernel/windows/netuio/netuio_queue.c:16:
+ *output = 0;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#98: FILE: kernel/windows/netuio/netuio_queue.c:19:
+ output,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#98: FILE: kernel/windows/netuio/netuio_queue.c:19:
+ output,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#101: FILE: kernel/windows/netuio/netuio_queue.c:21:
+ access_size);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#101: FILE: kernel/windows/netuio/netuio_queue.c:21:
+ access_size);$
WARNING:LONG_LINE: line over 100 characters
#105: FILE: kernel/windows/netuio/netuio_queue.c:24:
+VOID netuio_write_PCI_config(PNETUIO_CONTEXT_DATA netuio_contextdata, ULONG offset, UINT32 access_size, union dpdk_pci_config_io_data const *input)
ERROR:CODE_INDENT: code indent should use tabs where possible
#110: FILE: kernel/windows/netuio/netuio_queue.c:28:
+ (PVOID)input,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#110: FILE: kernel/windows/netuio/netuio_queue.c:28:
+ (PVOID)input,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#113: FILE: kernel/windows/netuio/netuio_queue.c:30:
+ access_size);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#113: FILE: kernel/windows/netuio/netuio_queue.c:30:
+ access_size);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#122: FILE: kernel/windows/netuio/netuio_queue.c:185:
+ if (dpdk_pci_io_input->access_size != 1 &&$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#122: FILE: kernel/windows/netuio/netuio_queue.c:185:
+ if (dpdk_pci_io_input->access_size != 1 &&$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#122: FILE: kernel/windows/netuio/netuio_queue.c:185:
+ if (dpdk_pci_io_input->access_size != 1 &&
[...]
+ status = STATUS_INVALID_PARAMETER;
ERROR:CODE_INDENT: code indent should use tabs where possible
#123: FILE: kernel/windows/netuio/netuio_queue.c:186:
+ dpdk_pci_io_input->access_size != 2 &&$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#123: FILE: kernel/windows/netuio/netuio_queue.c:186:
+ dpdk_pci_io_input->access_size != 2 &&$
ERROR:CODE_INDENT: code indent should use tabs where possible
#124: FILE: kernel/windows/netuio/netuio_queue.c:187:
+ dpdk_pci_io_input->access_size != 4 &&$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#124: FILE: kernel/windows/netuio/netuio_queue.c:187:
+ dpdk_pci_io_input->access_size != 4 &&$
ERROR:CODE_INDENT: code indent should use tabs where possible
#125: FILE: kernel/windows/netuio/netuio_queue.c:188:
+ dpdk_pci_io_input->access_size != 8) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#125: FILE: kernel/windows/netuio/netuio_queue.c:188:
+ dpdk_pci_io_input->access_size != 8) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#126: FILE: kernel/windows/netuio/netuio_queue.c:189:
+ status = STATUS_INVALID_PARAMETER;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#126: FILE: kernel/windows/netuio/netuio_queue.c:189:
+ status = STATUS_INVALID_PARAMETER;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#127: FILE: kernel/windows/netuio/netuio_queue.c:190:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#127: FILE: kernel/windows/netuio/netuio_queue.c:190:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#128: FILE: kernel/windows/netuio/netuio_queue.c:191:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#128: FILE: kernel/windows/netuio/netuio_queue.c:191:
+ }$
WARNING:LONG_LINE: line over 100 characters
#138: FILE: kernel/windows/netuio/netuio_queue.c:201:
+ status = WdfRequestRetrieveOutputBuffer(Request, sizeof(UINT64), &output_buf, &output_buf_size);
ERROR:CODE_INDENT: code indent should use tabs where possible
#138: FILE: kernel/windows/netuio/netuio_queue.c:201:
+ status = WdfRequestRetrieveOutputBuffer(Request, sizeof(UINT64), &output_buf, &output_buf_size);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#138: FILE: kernel/windows/netuio/netuio_queue.c:201:
+ status = WdfRequestRetrieveOutputBuffer(Request, sizeof(UINT64), &output_buf, &output_buf_size);$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#145: FILE: kernel/windows/netuio/netuio_queue.c:208:
if (dpdk_pci_io_input->op == PCI_IO_READ) {
+ netuio_read_PCI_config(netuio_contextdata,
ERROR:CODE_INDENT: code indent should use tabs where possible
#148: FILE: kernel/windows/netuio/netuio_queue.c:209:
+ netuio_read_PCI_config(netuio_contextdata,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#148: FILE: kernel/windows/netuio/netuio_queue.c:209:
+ netuio_read_PCI_config(netuio_contextdata,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#149: FILE: kernel/windows/netuio/netuio_queue.c:210:
+ dpdk_pci_io_input->offset,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#149: FILE: kernel/windows/netuio/netuio_queue.c:210:
+ dpdk_pci_io_input->offset,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#150: FILE: kernel/windows/netuio/netuio_queue.c:211:
+ dpdk_pci_io_input->access_size,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#150: FILE: kernel/windows/netuio/netuio_queue.c:211:
+ dpdk_pci_io_input->access_size,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#151: FILE: kernel/windows/netuio/netuio_queue.c:212:
+ (UINT64*)output_buf);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#151: FILE: kernel/windows/netuio/netuio_queue.c:212:
+ (UINT64*)output_buf);$
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#151: FILE: kernel/windows/netuio/netuio_queue.c:212:
+ (UINT64*)output_buf);
ERROR:TRAILING_WHITESPACE: trailing whitespace
#152: FILE: kernel/windows/netuio/netuio_queue.c:213:
+ $
ERROR:CODE_INDENT: code indent should use tabs where possible
#152: FILE: kernel/windows/netuio/netuio_queue.c:213:
+ $
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#152: FILE: kernel/windows/netuio/netuio_queue.c:213:
+ $
ERROR:CODE_INDENT: code indent should use tabs where possible
#153: FILE: kernel/windows/netuio/netuio_queue.c:214:
+ bytes_returned = sizeof(UINT64);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#153: FILE: kernel/windows/netuio/netuio_queue.c:214:
+ bytes_returned = sizeof(UINT64);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#157: FILE: kernel/windows/netuio/netuio_queue.c:216:
+ else if (dpdk_pci_io_input->op == PCI_IO_WRITE) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#157: FILE: kernel/windows/netuio/netuio_queue.c:216:
+ else if (dpdk_pci_io_input->op == PCI_IO_WRITE) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#157: FILE: kernel/windows/netuio/netuio_queue.c:216:
+ else if (dpdk_pci_io_input->op == PCI_IO_WRITE) {
+ netuio_write_PCI_config(netuio_contextdata,
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#157: FILE: kernel/windows/netuio/netuio_queue.c:216:
}
+ else if (dpdk_pci_io_input->op == PCI_IO_WRITE) {
ERROR:CODE_INDENT: code indent should use tabs where possible
#158: FILE: kernel/windows/netuio/netuio_queue.c:217:
+ netuio_write_PCI_config(netuio_contextdata,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#158: FILE: kernel/windows/netuio/netuio_queue.c:217:
+ netuio_write_PCI_config(netuio_contextdata,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#159: FILE: kernel/windows/netuio/netuio_queue.c:218:
+ dpdk_pci_io_input->offset,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#159: FILE: kernel/windows/netuio/netuio_queue.c:218:
+ dpdk_pci_io_input->offset,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#160: FILE: kernel/windows/netuio/netuio_queue.c:219:
+ dpdk_pci_io_input->access_size,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#160: FILE: kernel/windows/netuio/netuio_queue.c:219:
+ dpdk_pci_io_input->access_size,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#161: FILE: kernel/windows/netuio/netuio_queue.c:220:
+ &dpdk_pci_io_input->data);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#161: FILE: kernel/windows/netuio/netuio_queue.c:220:
+ &dpdk_pci_io_input->data);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#164: FILE: kernel/windows/netuio/netuio_queue.c:223:
+ else {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#164: FILE: kernel/windows/netuio/netuio_queue.c:223:
+ else {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#164: FILE: kernel/windows/netuio/netuio_queue.c:223:
+ else {
+ status = STATUS_INVALID_PARAMETER;
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#164: FILE: kernel/windows/netuio/netuio_queue.c:223:
}
+ else {
ERROR:CODE_INDENT: code indent should use tabs where possible
#165: FILE: kernel/windows/netuio/netuio_queue.c:224:
+ status = STATUS_INVALID_PARAMETER;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#165: FILE: kernel/windows/netuio/netuio_queue.c:224:
+ status = STATUS_INVALID_PARAMETER;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#166: FILE: kernel/windows/netuio/netuio_queue.c:225:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#166: FILE: kernel/windows/netuio/netuio_queue.c:225:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#167: FILE: kernel/windows/netuio/netuio_queue.c:226:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#167: FILE: kernel/windows/netuio/netuio_queue.c:226:
+ }$
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 37 errors, 42 warnings, 97 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-08-13 23:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1597360905-74106-10-git-send-email-navasile@linux.microsoft.com>
2020-08-13 23:25 ` [dpdk-test-report] |WARNING| pw75530 [PATCH 09/22] doc: remove embedded buffer from Windows UIO ioctl checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).