From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD2C6A04B1 for ; Fri, 14 Aug 2020 01:25:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8F9731C127; Fri, 14 Aug 2020 01:25:55 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 4629C1C123; Fri, 14 Aug 2020 01:25:54 +0200 (CEST) In-Reply-To: <1597360905-74106-7-git-send-email-navasile@linux.microsoft.com> References: <1597360905-74106-7-git-send-email-navasile@linux.microsoft.com> To: test-report@dpdk.org Cc: Narcisa Ana Maria Vasile Message-Id: <20200813232554.4629C1C123@dpdk.org> Date: Fri, 14 Aug 2020 01:25:54 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw75533 [PATCH 06/22] Windows DPDK libraries and applications have now been updated to the latest public release v18.08, X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/75533 _coding style issues_ WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #242: FILE: kernel/windows/netuio/netuio_dev.c:2: +/*- +* WARNING:SPACING: space prohibited between function name and open parenthesis '(' #254: FILE: kernel/windows/netuio/netuio_dev.c:14: +#pragma alloc_text (PAGE, netuio_create_device) WARNING:SPACING: space prohibited between function name and open parenthesis '(' #255: FILE: kernel/windows/netuio/netuio_dev.c:15: +#pragma alloc_text (PAGE, netuio_evt_device_context_cleanup) WARNING:SPACING: space prohibited between function name and open parenthesis '(' #256: FILE: kernel/windows/netuio/netuio_dev.c:16: +#pragma alloc_text (PAGE, netuio_map_hw_resources) WARNING:SPACING: space prohibited between function name and open parenthesis '(' #257: FILE: kernel/windows/netuio/netuio_dev.c:17: +#pragma alloc_text (PAGE, netuio_free_hw_resources) WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #261: FILE: kernel/windows/netuio/netuio_dev.c:21: +/* +Routine Description: WARNING:TYPO_SPELLING: 'Inout' may be misspelled - perhaps 'Input'? #268: FILE: kernel/windows/netuio/netuio_dev.c:28: +netuio_create_device(_Inout_ PWDFDEVICE_INIT DeviceInit) WARNING:LEADING_SPACE: please, no spaces at the start of a line #270: FILE: kernel/windows/netuio/netuio_dev.c:30: + WDF_OBJECT_ATTRIBUTES deviceAttributes;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #271: FILE: kernel/windows/netuio/netuio_dev.c:31: + WDFDEVICE device;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #272: FILE: kernel/windows/netuio/netuio_dev.c:32: + NTSTATUS status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #274: FILE: kernel/windows/netuio/netuio_dev.c:34: + PAGED_CODE();$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #275: FILE: kernel/windows/netuio/netuio_dev.c:35: + WDF_OBJECT_ATTRIBUTES_INIT_CONTEXT_TYPE(&deviceAttributes, NETUIO_CONTEXT_DATA);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #277: FILE: kernel/windows/netuio/netuio_dev.c:37: + // Set the device context cleanup callback.$ ERROR:C99_COMMENTS: do not use C99 // comments #277: FILE: kernel/windows/netuio/netuio_dev.c:37: + // Set the device context cleanup callback. WARNING:LONG_LINE_COMMENT: line over 100 characters #278: FILE: kernel/windows/netuio/netuio_dev.c:38: + // This function will be called when the WDF Device Object associated to the current device is destroyed WARNING:LEADING_SPACE: please, no spaces at the start of a line #278: FILE: kernel/windows/netuio/netuio_dev.c:38: + // This function will be called when the WDF Device Object associated to the current device is destroyed$ ERROR:C99_COMMENTS: do not use C99 // comments #278: FILE: kernel/windows/netuio/netuio_dev.c:38: + // This function will be called when the WDF Device Object associated to the current device is destroyed WARNING:LEADING_SPACE: please, no spaces at the start of a line #279: FILE: kernel/windows/netuio/netuio_dev.c:39: + deviceAttributes.EvtCleanupCallback = netuio_evt_device_context_cleanup;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #281: FILE: kernel/windows/netuio/netuio_dev.c:41: + status = WdfDeviceCreate(&DeviceInit, &deviceAttributes, &device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #283: FILE: kernel/windows/netuio/netuio_dev.c:43: + if (NT_SUCCESS(status)) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #284: FILE: kernel/windows/netuio/netuio_dev.c:44: + // Create a device interface so that applications can find and talk to us.$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #284: FILE: kernel/windows/netuio/netuio_dev.c:44: + // Create a device interface so that applications can find and talk to us.$ ERROR:C99_COMMENTS: do not use C99 // comments #284: FILE: kernel/windows/netuio/netuio_dev.c:44: + // Create a device interface so that applications can find and talk to us. ERROR:CODE_INDENT: code indent should use tabs where possible #285: FILE: kernel/windows/netuio/netuio_dev.c:45: + status = WdfDeviceCreateDeviceInterface(device, &GUID_DEVINTERFACE_netUIO, NULL);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #285: FILE: kernel/windows/netuio/netuio_dev.c:45: + status = WdfDeviceCreateDeviceInterface(device, &GUID_DEVINTERFACE_netUIO, NULL);$ ERROR:CODE_INDENT: code indent should use tabs where possible #287: FILE: kernel/windows/netuio/netuio_dev.c:47: + if (NT_SUCCESS(status)) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #287: FILE: kernel/windows/netuio/netuio_dev.c:47: + if (NT_SUCCESS(status)) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #287: FILE: kernel/windows/netuio/netuio_dev.c:47: + if (NT_SUCCESS(status)) { + // Retrieve and store PCI information ERROR:CODE_INDENT: code indent should use tabs where possible #288: FILE: kernel/windows/netuio/netuio_dev.c:48: + // Retrieve and store PCI information$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #288: FILE: kernel/windows/netuio/netuio_dev.c:48: + // Retrieve and store PCI information$ ERROR:C99_COMMENTS: do not use C99 // comments #288: FILE: kernel/windows/netuio/netuio_dev.c:48: + // Retrieve and store PCI information ERROR:CODE_INDENT: code indent should use tabs where possible #289: FILE: kernel/windows/netuio/netuio_dev.c:49: + status = get_pci_device_info(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #289: FILE: kernel/windows/netuio/netuio_dev.c:49: + status = get_pci_device_info(device);$ ERROR:CODE_INDENT: code indent should use tabs where possible #290: FILE: kernel/windows/netuio/netuio_dev.c:50: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #290: FILE: kernel/windows/netuio/netuio_dev.c:50: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #292: FILE: kernel/windows/netuio/netuio_dev.c:52: + if (NT_SUCCESS(status)) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #292: FILE: kernel/windows/netuio/netuio_dev.c:52: + if (NT_SUCCESS(status)) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #292: FILE: kernel/windows/netuio/netuio_dev.c:52: + if (NT_SUCCESS(status)) { + // Create a symbolic link name for user-space access ERROR:CODE_INDENT: code indent should use tabs where possible #293: FILE: kernel/windows/netuio/netuio_dev.c:53: + // Create a symbolic link name for user-space access$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #293: FILE: kernel/windows/netuio/netuio_dev.c:53: + // Create a symbolic link name for user-space access$ ERROR:C99_COMMENTS: do not use C99 // comments #293: FILE: kernel/windows/netuio/netuio_dev.c:53: + // Create a symbolic link name for user-space access ERROR:CODE_INDENT: code indent should use tabs where possible #294: FILE: kernel/windows/netuio/netuio_dev.c:54: + status = create_device_specific_symbolic_link(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #294: FILE: kernel/windows/netuio/netuio_dev.c:54: + status = create_device_specific_symbolic_link(device);$ ERROR:CODE_INDENT: code indent should use tabs where possible #295: FILE: kernel/windows/netuio/netuio_dev.c:55: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #295: FILE: kernel/windows/netuio/netuio_dev.c:55: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #297: FILE: kernel/windows/netuio/netuio_dev.c:57: + if (NT_SUCCESS(status)) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #297: FILE: kernel/windows/netuio/netuio_dev.c:57: + if (NT_SUCCESS(status)) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #297: FILE: kernel/windows/netuio/netuio_dev.c:57: + if (NT_SUCCESS(status)) { + // Initialize the I/O Package and any Queues ERROR:CODE_INDENT: code indent should use tabs where possible #298: FILE: kernel/windows/netuio/netuio_dev.c:58: + // Initialize the I/O Package and any Queues$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #298: FILE: kernel/windows/netuio/netuio_dev.c:58: + // Initialize the I/O Package and any Queues$ ERROR:C99_COMMENTS: do not use C99 // comments #298: FILE: kernel/windows/netuio/netuio_dev.c:58: + // Initialize the I/O Package and any Queues ERROR:CODE_INDENT: code indent should use tabs where possible #299: FILE: kernel/windows/netuio/netuio_dev.c:59: + status = netuio_queue_initialize(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #299: FILE: kernel/windows/netuio/netuio_dev.c:59: + status = netuio_queue_initialize(device);$ ERROR:CODE_INDENT: code indent should use tabs where possible #300: FILE: kernel/windows/netuio/netuio_dev.c:60: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #300: FILE: kernel/windows/netuio/netuio_dev.c:60: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #302: FILE: kernel/windows/netuio/netuio_dev.c:62: + if (NT_SUCCESS(status)) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #302: FILE: kernel/windows/netuio/netuio_dev.c:62: + if (NT_SUCCESS(status)) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #302: FILE: kernel/windows/netuio/netuio_dev.c:62: + if (NT_SUCCESS(status)) { + // Allocate physically contiguous memory for user process use. We'll map it later ERROR:CODE_INDENT: code indent should use tabs where possible #303: FILE: kernel/windows/netuio/netuio_dev.c:63: + // Allocate physically contiguous memory for user process use. We'll map it later$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #303: FILE: kernel/windows/netuio/netuio_dev.c:63: + // Allocate physically contiguous memory for user process use. We'll map it later$ ERROR:C99_COMMENTS: do not use C99 // comments #303: FILE: kernel/windows/netuio/netuio_dev.c:63: + // Allocate physically contiguous memory for user process use. We'll map it later ERROR:CODE_INDENT: code indent should use tabs where possible #304: FILE: kernel/windows/netuio/netuio_dev.c:64: + status = allocate_usermemory_segment(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #304: FILE: kernel/windows/netuio/netuio_dev.c:64: + status = allocate_usermemory_segment(device);$ ERROR:CODE_INDENT: code indent should use tabs where possible #305: FILE: kernel/windows/netuio/netuio_dev.c:65: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #305: FILE: kernel/windows/netuio/netuio_dev.c:65: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #306: FILE: kernel/windows/netuio/netuio_dev.c:66: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #308: FILE: kernel/windows/netuio/netuio_dev.c:68: + return status;$ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #312: FILE: kernel/windows/netuio/netuio_dev.c:72: +/* +Routine Description: WARNING:LEADING_SPACE: please, no spaces at the start of a line #321: FILE: kernel/windows/netuio/netuio_dev.c:81: + free_usermemory_segment(Device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #322: FILE: kernel/windows/netuio/netuio_dev.c:82: + return;$ WARNING:LONG_LINE: line over 100 characters #326: FILE: kernel/windows/netuio/netuio_dev.c:86: +netuio_map_hw_resources(_In_ WDFDEVICE Device, _In_ WDFCMRESLIST Resources, _In_ WDFCMRESLIST ResourcesTranslated) WARNING:LEADING_SPACE: please, no spaces at the start of a line #328: FILE: kernel/windows/netuio/netuio_dev.c:88: + UNREFERENCED_PARAMETER(Resources);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #330: FILE: kernel/windows/netuio/netuio_dev.c:90: + NTSTATUS status = STATUS_SUCCESS;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #332: FILE: kernel/windows/netuio/netuio_dev.c:92: + PNETUIO_CONTEXT_DATA netuio_contextdata;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #333: FILE: kernel/windows/netuio/netuio_dev.c:93: + netuio_contextdata = netuio_get_context_data(Device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #335: FILE: kernel/windows/netuio/netuio_dev.c:95: + if (!netuio_contextdata)$ ERROR:CODE_INDENT: code indent should use tabs where possible #336: FILE: kernel/windows/netuio/netuio_dev.c:96: + return STATUS_UNSUCCESSFUL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #336: FILE: kernel/windows/netuio/netuio_dev.c:96: + return STATUS_UNSUCCESSFUL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #338: FILE: kernel/windows/netuio/netuio_dev.c:98: + PCM_PARTIAL_RESOURCE_DESCRIPTOR descriptor;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #339: FILE: kernel/windows/netuio/netuio_dev.c:99: + UINT8 bar_index = 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #341: FILE: kernel/windows/netuio/netuio_dev.c:101: + // Collect device BAR resources from the ResourcesTranslated object$ ERROR:C99_COMMENTS: do not use C99 // comments #341: FILE: kernel/windows/netuio/netuio_dev.c:101: + // Collect device BAR resources from the ResourcesTranslated object WARNING:LEADING_SPACE: please, no spaces at the start of a line #342: FILE: kernel/windows/netuio/netuio_dev.c:102: + for (ULONG idx = 0; idx < WdfCmResourceListGetCount(ResourcesTranslated); idx++) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #343: FILE: kernel/windows/netuio/netuio_dev.c:103: + descriptor = WdfCmResourceListGetDescriptor(ResourcesTranslated, idx);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #343: FILE: kernel/windows/netuio/netuio_dev.c:103: + descriptor = WdfCmResourceListGetDescriptor(ResourcesTranslated, idx);$ ERROR:CODE_INDENT: code indent should use tabs where possible #344: FILE: kernel/windows/netuio/netuio_dev.c:104: + if (!descriptor) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #344: FILE: kernel/windows/netuio/netuio_dev.c:104: + if (!descriptor) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #344: FILE: kernel/windows/netuio/netuio_dev.c:104: + if (!descriptor) { + status = STATUS_DEVICE_CONFIGURATION_ERROR; ERROR:CODE_INDENT: code indent should use tabs where possible #345: FILE: kernel/windows/netuio/netuio_dev.c:105: + status = STATUS_DEVICE_CONFIGURATION_ERROR;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #345: FILE: kernel/windows/netuio/netuio_dev.c:105: + status = STATUS_DEVICE_CONFIGURATION_ERROR;$ ERROR:CODE_INDENT: code indent should use tabs where possible #346: FILE: kernel/windows/netuio/netuio_dev.c:106: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #346: FILE: kernel/windows/netuio/netuio_dev.c:106: + goto end;$ ERROR:CODE_INDENT: code indent should use tabs where possible #347: FILE: kernel/windows/netuio/netuio_dev.c:107: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #347: FILE: kernel/windows/netuio/netuio_dev.c:107: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #349: FILE: kernel/windows/netuio/netuio_dev.c:109: + switch (descriptor->Type) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #349: FILE: kernel/windows/netuio/netuio_dev.c:109: + switch (descriptor->Type) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #350: FILE: kernel/windows/netuio/netuio_dev.c:110: + case CmResourceTypeMemory:$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #350: FILE: kernel/windows/netuio/netuio_dev.c:110: + case CmResourceTypeMemory:$ ERROR:CODE_INDENT: code indent should use tabs where possible #351: FILE: kernel/windows/netuio/netuio_dev.c:111: + // Retrieve and map the BARs$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #351: FILE: kernel/windows/netuio/netuio_dev.c:111: + // Retrieve and map the BARs$ ERROR:C99_COMMENTS: do not use C99 // comments #351: FILE: kernel/windows/netuio/netuio_dev.c:111: + // Retrieve and map the BARs WARNING:LONG_LINE: line over 100 characters #352: FILE: kernel/windows/netuio/netuio_dev.c:112: + netuio_contextdata->bar[bar_index].base_addr.QuadPart = descriptor->u.Memory.Start.QuadPart; ERROR:CODE_INDENT: code indent should use tabs where possible #352: FILE: kernel/windows/netuio/netuio_dev.c:112: + netuio_contextdata->bar[bar_index].base_addr.QuadPart = descriptor->u.Memory.Start.QuadPart;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #352: FILE: kernel/windows/netuio/netuio_dev.c:112: + netuio_contextdata->bar[bar_index].base_addr.QuadPart = descriptor->u.Memory.Start.QuadPart;$ ERROR:CODE_INDENT: code indent should use tabs where possible #353: FILE: kernel/windows/netuio/netuio_dev.c:113: + netuio_contextdata->bar[bar_index].size = descriptor->u.Memory.Length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #353: FILE: kernel/windows/netuio/netuio_dev.c:113: + netuio_contextdata->bar[bar_index].size = descriptor->u.Memory.Length;$ ERROR:CODE_INDENT: code indent should use tabs where possible #354: FILE: kernel/windows/netuio/netuio_dev.c:114: + netuio_contextdata->bar[bar_index].virt_addr =$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #354: FILE: kernel/windows/netuio/netuio_dev.c:114: + netuio_contextdata->bar[bar_index].virt_addr =$ ERROR:CODE_INDENT: code indent should use tabs where possible #355: FILE: kernel/windows/netuio/netuio_dev.c:115: + MmMapIoSpace(descriptor->u.Memory.Start, descriptor->u.Memory.Length, MmNonCached);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #355: FILE: kernel/windows/netuio/netuio_dev.c:115: + MmMapIoSpace(descriptor->u.Memory.Start, descriptor->u.Memory.Length, MmNonCached);$ ERROR:CODE_INDENT: code indent should use tabs where possible #357: FILE: kernel/windows/netuio/netuio_dev.c:117: + if (netuio_contextdata->bar[bar_index].virt_addr == NULL) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #357: FILE: kernel/windows/netuio/netuio_dev.c:117: + if (netuio_contextdata->bar[bar_index].virt_addr == NULL) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #358: FILE: kernel/windows/netuio/netuio_dev.c:118: + status = STATUS_UNSUCCESSFUL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #358: FILE: kernel/windows/netuio/netuio_dev.c:118: + status = STATUS_UNSUCCESSFUL;$ ERROR:CODE_INDENT: code indent should use tabs where possible #359: FILE: kernel/windows/netuio/netuio_dev.c:119: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #359: FILE: kernel/windows/netuio/netuio_dev.c:119: + goto end;$ ERROR:CODE_INDENT: code indent should use tabs where possible #360: FILE: kernel/windows/netuio/netuio_dev.c:120: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #360: FILE: kernel/windows/netuio/netuio_dev.c:120: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #362: FILE: kernel/windows/netuio/netuio_dev.c:122: + bar_index++;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #362: FILE: kernel/windows/netuio/netuio_dev.c:122: + bar_index++;$ ERROR:CODE_INDENT: code indent should use tabs where possible #363: FILE: kernel/windows/netuio/netuio_dev.c:123: + break;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #363: FILE: kernel/windows/netuio/netuio_dev.c:123: + break;$ ERROR:CODE_INDENT: code indent should use tabs where possible #365: FILE: kernel/windows/netuio/netuio_dev.c:125: + // Don't handle any other resource type$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #365: FILE: kernel/windows/netuio/netuio_dev.c:125: + // Don't handle any other resource type$ ERROR:C99_COMMENTS: do not use C99 // comments #365: FILE: kernel/windows/netuio/netuio_dev.c:125: + // Don't handle any other resource type ERROR:CODE_INDENT: code indent should use tabs where possible #366: FILE: kernel/windows/netuio/netuio_dev.c:126: + // This could be device-private type added by the PCI bus driver.$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #366: FILE: kernel/windows/netuio/netuio_dev.c:126: + // This could be device-private type added by the PCI bus driver.$ ERROR:C99_COMMENTS: do not use C99 // comments #366: FILE: kernel/windows/netuio/netuio_dev.c:126: + // This could be device-private type added by the PCI bus driver. ERROR:CODE_INDENT: code indent should use tabs where possible #367: FILE: kernel/windows/netuio/netuio_dev.c:127: + case CmResourceTypeInterrupt:$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #367: FILE: kernel/windows/netuio/netuio_dev.c:127: + case CmResourceTypeInterrupt:$ ERROR:CODE_INDENT: code indent should use tabs where possible #368: FILE: kernel/windows/netuio/netuio_dev.c:128: + default:$ ERROR:CODE_INDENT: code indent should use tabs where possible #369: FILE: kernel/windows/netuio/netuio_dev.c:129: + break;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #369: FILE: kernel/windows/netuio/netuio_dev.c:129: + break;$ ERROR:CODE_INDENT: code indent should use tabs where possible #370: FILE: kernel/windows/netuio/netuio_dev.c:130: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #370: FILE: kernel/windows/netuio/netuio_dev.c:130: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #371: FILE: kernel/windows/netuio/netuio_dev.c:131: + }$ WARNING:LONG_LINE_COMMENT: line over 100 characters #373: FILE: kernel/windows/netuio/netuio_dev.c:133: + // Allocate an MDL for the device BAR, so that we can map it to the user's process context later... WARNING:LEADING_SPACE: please, no spaces at the start of a line #373: FILE: kernel/windows/netuio/netuio_dev.c:133: + // Allocate an MDL for the device BAR, so that we can map it to the user's process context later...$ ERROR:C99_COMMENTS: do not use C99 // comments #373: FILE: kernel/windows/netuio/netuio_dev.c:133: + // Allocate an MDL for the device BAR, so that we can map it to the user's process context later... WARNING:LEADING_SPACE: please, no spaces at the start of a line #374: FILE: kernel/windows/netuio/netuio_dev.c:134: + if (status == STATUS_SUCCESS) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #375: FILE: kernel/windows/netuio/netuio_dev.c:135: + // Bar 0 is typically the HW BAR$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #375: FILE: kernel/windows/netuio/netuio_dev.c:135: + // Bar 0 is typically the HW BAR$ ERROR:C99_COMMENTS: do not use C99 // comments #375: FILE: kernel/windows/netuio/netuio_dev.c:135: + // Bar 0 is typically the HW BAR ERROR:CODE_INDENT: code indent should use tabs where possible #376: FILE: kernel/windows/netuio/netuio_dev.c:136: + if (netuio_contextdata->bar[0].virt_addr) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #376: FILE: kernel/windows/netuio/netuio_dev.c:136: + if (netuio_contextdata->bar[0].virt_addr) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #376: FILE: kernel/windows/netuio/netuio_dev.c:136: + if (netuio_contextdata->bar[0].virt_addr) { + netuio_contextdata->dpdk_hw.mdl = IoAllocateMdl(netuio_contextdata->bar[0].virt_addr, (ULONG)netuio_contextdata->bar[0].size, FALSE, FALSE, NULL); WARNING:LONG_LINE: line over 100 characters #377: FILE: kernel/windows/netuio/netuio_dev.c:137: + netuio_contextdata->dpdk_hw.mdl = IoAllocateMdl(netuio_contextdata->bar[0].virt_addr, (ULONG)netuio_contextdata->bar[0].size, FALSE, FALSE, NULL); ERROR:CODE_INDENT: code indent should use tabs where possible #377: FILE: kernel/windows/netuio/netuio_dev.c:137: + netuio_contextdata->dpdk_hw.mdl = IoAllocateMdl(netuio_contextdata->bar[0].virt_addr, (ULONG)netuio_contextdata->bar[0].size, FALSE, FALSE, NULL);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #377: FILE: kernel/windows/netuio/netuio_dev.c:137: + netuio_contextdata->dpdk_hw.mdl = IoAllocateMdl(netuio_contextdata->bar[0].virt_addr, (ULONG)netuio_contextdata->bar[0].size, FALSE, FALSE, NULL);$ ERROR:CODE_INDENT: code indent should use tabs where possible #378: FILE: kernel/windows/netuio/netuio_dev.c:138: + if (!netuio_contextdata->dpdk_hw.mdl) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #378: FILE: kernel/windows/netuio/netuio_dev.c:138: + if (!netuio_contextdata->dpdk_hw.mdl) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #379: FILE: kernel/windows/netuio/netuio_dev.c:139: + status = STATUS_INSUFFICIENT_RESOURCES;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #379: FILE: kernel/windows/netuio/netuio_dev.c:139: + status = STATUS_INSUFFICIENT_RESOURCES;$ ERROR:CODE_INDENT: code indent should use tabs where possible #380: FILE: kernel/windows/netuio/netuio_dev.c:140: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #380: FILE: kernel/windows/netuio/netuio_dev.c:140: + goto end;$ ERROR:CODE_INDENT: code indent should use tabs where possible #381: FILE: kernel/windows/netuio/netuio_dev.c:141: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #381: FILE: kernel/windows/netuio/netuio_dev.c:141: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #382: FILE: kernel/windows/netuio/netuio_dev.c:142: + netuio_contextdata->dpdk_hw.mem.size = netuio_contextdata->bar[0].size;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #382: FILE: kernel/windows/netuio/netuio_dev.c:142: + netuio_contextdata->dpdk_hw.mem.size = netuio_contextdata->bar[0].size;$ ERROR:CODE_INDENT: code indent should use tabs where possible #383: FILE: kernel/windows/netuio/netuio_dev.c:143: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #383: FILE: kernel/windows/netuio/netuio_dev.c:143: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #384: FILE: kernel/windows/netuio/netuio_dev.c:144: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #387: FILE: kernel/windows/netuio/netuio_dev.c:147: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #393: FILE: kernel/windows/netuio/netuio_dev.c:153: + PNETUIO_CONTEXT_DATA netuio_contextdata;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #394: FILE: kernel/windows/netuio/netuio_dev.c:154: + netuio_contextdata = netuio_get_context_data(Device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #396: FILE: kernel/windows/netuio/netuio_dev.c:156: + if (netuio_contextdata) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #397: FILE: kernel/windows/netuio/netuio_dev.c:157: + // Free the allocated MDL$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #397: FILE: kernel/windows/netuio/netuio_dev.c:157: + // Free the allocated MDL$ ERROR:C99_COMMENTS: do not use C99 // comments #397: FILE: kernel/windows/netuio/netuio_dev.c:157: + // Free the allocated MDL ERROR:CODE_INDENT: code indent should use tabs where possible #398: FILE: kernel/windows/netuio/netuio_dev.c:158: + if (netuio_contextdata->dpdk_hw.mdl)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #398: FILE: kernel/windows/netuio/netuio_dev.c:158: + if (netuio_contextdata->dpdk_hw.mdl)$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #398: FILE: kernel/windows/netuio/netuio_dev.c:158: + if (netuio_contextdata->dpdk_hw.mdl) + IoFreeMdl(netuio_contextdata->dpdk_hw.mdl); ERROR:CODE_INDENT: code indent should use tabs where possible #399: FILE: kernel/windows/netuio/netuio_dev.c:159: + IoFreeMdl(netuio_contextdata->dpdk_hw.mdl);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #399: FILE: kernel/windows/netuio/netuio_dev.c:159: + IoFreeMdl(netuio_contextdata->dpdk_hw.mdl);$ ERROR:CODE_INDENT: code indent should use tabs where possible #401: FILE: kernel/windows/netuio/netuio_dev.c:161: + // Unmap all the BAR regions previously mapped$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #401: FILE: kernel/windows/netuio/netuio_dev.c:161: + // Unmap all the BAR regions previously mapped$ ERROR:C99_COMMENTS: do not use C99 // comments #401: FILE: kernel/windows/netuio/netuio_dev.c:161: + // Unmap all the BAR regions previously mapped ERROR:CODE_INDENT: code indent should use tabs where possible #402: FILE: kernel/windows/netuio/netuio_dev.c:162: + for (UINT8 bar_index = 0; bar_index < PCI_MAX_BAR; bar_index++) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #402: FILE: kernel/windows/netuio/netuio_dev.c:162: + for (UINT8 bar_index = 0; bar_index < PCI_MAX_BAR; bar_index++) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #402: FILE: kernel/windows/netuio/netuio_dev.c:162: + for (UINT8 bar_index = 0; bar_index < PCI_MAX_BAR; bar_index++) { + if (netuio_contextdata->bar[bar_index].virt_addr) ERROR:CODE_INDENT: code indent should use tabs where possible #403: FILE: kernel/windows/netuio/netuio_dev.c:163: + if (netuio_contextdata->bar[bar_index].virt_addr)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #403: FILE: kernel/windows/netuio/netuio_dev.c:163: + if (netuio_contextdata->bar[bar_index].virt_addr)$ WARNING:LONG_LINE: line over 100 characters #404: FILE: kernel/windows/netuio/netuio_dev.c:164: + MmUnmapIoSpace(netuio_contextdata->bar[bar_index].virt_addr, netuio_contextdata->bar[bar_index].size); ERROR:CODE_INDENT: code indent should use tabs where possible #404: FILE: kernel/windows/netuio/netuio_dev.c:164: + MmUnmapIoSpace(netuio_contextdata->bar[bar_index].virt_addr, netuio_contextdata->bar[bar_index].size);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #404: FILE: kernel/windows/netuio/netuio_dev.c:164: + MmUnmapIoSpace(netuio_contextdata->bar[bar_index].virt_addr, netuio_contextdata->bar[bar_index].size);$ ERROR:CODE_INDENT: code indent should use tabs where possible #405: FILE: kernel/windows/netuio/netuio_dev.c:165: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #405: FILE: kernel/windows/netuio/netuio_dev.c:165: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #406: FILE: kernel/windows/netuio/netuio_dev.c:166: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #413: FILE: kernel/windows/netuio/netuio_dev.c:173: + NTSTATUS status = STATUS_UNSUCCESSFUL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #415: FILE: kernel/windows/netuio/netuio_dev.c:175: + PNETUIO_CONTEXT_DATA netuio_contextdata;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #416: FILE: kernel/windows/netuio/netuio_dev.c:176: + netuio_contextdata = netuio_get_context_data(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #418: FILE: kernel/windows/netuio/netuio_dev.c:178: + if (!netuio_contextdata)$ ERROR:CODE_INDENT: code indent should use tabs where possible #419: FILE: kernel/windows/netuio/netuio_dev.c:179: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #419: FILE: kernel/windows/netuio/netuio_dev.c:179: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #421: FILE: kernel/windows/netuio/netuio_dev.c:181: + netuio_contextdata->wdf_device = device; // Store for later use$ ERROR:C99_COMMENTS: do not use C99 // comments #421: FILE: kernel/windows/netuio/netuio_dev.c:181: + netuio_contextdata->wdf_device = device; // Store for later use WARNING:LEADING_SPACE: please, no spaces at the start of a line #423: FILE: kernel/windows/netuio/netuio_dev.c:183: + // Obtain the BUS_INTERFACE_STANDARD interface from the Bus Driver$ ERROR:C99_COMMENTS: do not use C99 // comments #423: FILE: kernel/windows/netuio/netuio_dev.c:183: + // Obtain the BUS_INTERFACE_STANDARD interface from the Bus Driver WARNING:LEADING_SPACE: please, no spaces at the start of a line #424: FILE: kernel/windows/netuio/netuio_dev.c:184: + status = WdfFdoQueryForInterface(device, &GUID_BUS_INTERFACE_STANDARD,$ ERROR:CODE_INDENT: code indent should use tabs where possible #425: FILE: kernel/windows/netuio/netuio_dev.c:185: + (PINTERFACE)&netuio_contextdata->bus_interface,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #425: FILE: kernel/windows/netuio/netuio_dev.c:185: + (PINTERFACE)&netuio_contextdata->bus_interface,$ ERROR:CODE_INDENT: code indent should use tabs where possible #426: FILE: kernel/windows/netuio/netuio_dev.c:186: + sizeof(BUS_INTERFACE_STANDARD), 1, NULL);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #426: FILE: kernel/windows/netuio/netuio_dev.c:186: + sizeof(BUS_INTERFACE_STANDARD), 1, NULL);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #427: FILE: kernel/windows/netuio/netuio_dev.c:187: + if (!NT_SUCCESS(status))$ ERROR:CODE_INDENT: code indent should use tabs where possible #428: FILE: kernel/windows/netuio/netuio_dev.c:188: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #428: FILE: kernel/windows/netuio/netuio_dev.c:188: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #430: FILE: kernel/windows/netuio/netuio_dev.c:190: + // Retrieve the B:D:F details of our device$ ERROR:C99_COMMENTS: do not use C99 // comments #430: FILE: kernel/windows/netuio/netuio_dev.c:190: + // Retrieve the B:D:F details of our device WARNING:LEADING_SPACE: please, no spaces at the start of a line #431: FILE: kernel/windows/netuio/netuio_dev.c:191: + PDEVICE_OBJECT pdo = NULL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #432: FILE: kernel/windows/netuio/netuio_dev.c:192: + pdo = WdfDeviceWdmGetPhysicalDevice(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #433: FILE: kernel/windows/netuio/netuio_dev.c:193: + if (pdo) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #434: FILE: kernel/windows/netuio/netuio_dev.c:194: + ULONG prop = 0, length = 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #434: FILE: kernel/windows/netuio/netuio_dev.c:194: + ULONG prop = 0, length = 0;$ WARNING:LONG_LINE: line over 100 characters #435: FILE: kernel/windows/netuio/netuio_dev.c:195: + status = IoGetDeviceProperty(pdo, DevicePropertyBusNumber, sizeof(ULONG), (PVOID)&netuio_contextdata->addr.bus_num, &length); ERROR:CODE_INDENT: code indent should use tabs where possible #435: FILE: kernel/windows/netuio/netuio_dev.c:195: + status = IoGetDeviceProperty(pdo, DevicePropertyBusNumber, sizeof(ULONG), (PVOID)&netuio_contextdata->addr.bus_num, &length);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #435: FILE: kernel/windows/netuio/netuio_dev.c:195: + status = IoGetDeviceProperty(pdo, DevicePropertyBusNumber, sizeof(ULONG), (PVOID)&netuio_contextdata->addr.bus_num, &length);$ WARNING:LONG_LINE: line over 100 characters #436: FILE: kernel/windows/netuio/netuio_dev.c:196: + status = IoGetDeviceProperty(pdo, DevicePropertyAddress, sizeof(ULONG), (PVOID)&prop, &length); ERROR:CODE_INDENT: code indent should use tabs where possible #436: FILE: kernel/windows/netuio/netuio_dev.c:196: + status = IoGetDeviceProperty(pdo, DevicePropertyAddress, sizeof(ULONG), (PVOID)&prop, &length);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #436: FILE: kernel/windows/netuio/netuio_dev.c:196: + status = IoGetDeviceProperty(pdo, DevicePropertyAddress, sizeof(ULONG), (PVOID)&prop, &length);$ ERROR:CODE_INDENT: code indent should use tabs where possible #438: FILE: kernel/windows/netuio/netuio_dev.c:198: + if (NT_SUCCESS(status)) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #438: FILE: kernel/windows/netuio/netuio_dev.c:198: + if (NT_SUCCESS(status)) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #438: FILE: kernel/windows/netuio/netuio_dev.c:198: + if (NT_SUCCESS(status)) { + netuio_contextdata->addr.func_num = prop & 0x0000FFFF; ERROR:CODE_INDENT: code indent should use tabs where possible #439: FILE: kernel/windows/netuio/netuio_dev.c:199: + netuio_contextdata->addr.func_num = prop & 0x0000FFFF;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #439: FILE: kernel/windows/netuio/netuio_dev.c:199: + netuio_contextdata->addr.func_num = prop & 0x0000FFFF;$ ERROR:CODE_INDENT: code indent should use tabs where possible #440: FILE: kernel/windows/netuio/netuio_dev.c:200: + netuio_contextdata->addr.dev_num = ((prop >> 16) & 0x0000FFFF);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #440: FILE: kernel/windows/netuio/netuio_dev.c:200: + netuio_contextdata->addr.dev_num = ((prop >> 16) & 0x0000FFFF);$ ERROR:CODE_INDENT: code indent should use tabs where possible #441: FILE: kernel/windows/netuio/netuio_dev.c:201: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #441: FILE: kernel/windows/netuio/netuio_dev.c:201: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #442: FILE: kernel/windows/netuio/netuio_dev.c:202: + // Also, retrieve the NUMA node of the device$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #442: FILE: kernel/windows/netuio/netuio_dev.c:202: + // Also, retrieve the NUMA node of the device$ ERROR:C99_COMMENTS: do not use C99 // comments #442: FILE: kernel/windows/netuio/netuio_dev.c:202: + // Also, retrieve the NUMA node of the device ERROR:CODE_INDENT: code indent should use tabs where possible #443: FILE: kernel/windows/netuio/netuio_dev.c:203: + USHORT numaNode;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #443: FILE: kernel/windows/netuio/netuio_dev.c:203: + USHORT numaNode;$ ERROR:CODE_INDENT: code indent should use tabs where possible #444: FILE: kernel/windows/netuio/netuio_dev.c:204: + status = IoGetDeviceNumaNode(pdo, &numaNode);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #444: FILE: kernel/windows/netuio/netuio_dev.c:204: + status = IoGetDeviceNumaNode(pdo, &numaNode);$ ERROR:CODE_INDENT: code indent should use tabs where possible #445: FILE: kernel/windows/netuio/netuio_dev.c:205: + if (NT_SUCCESS(status)) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #445: FILE: kernel/windows/netuio/netuio_dev.c:205: + if (NT_SUCCESS(status)) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #445: FILE: kernel/windows/netuio/netuio_dev.c:205: + if (NT_SUCCESS(status)) { + netuio_contextdata->dev_numa_node = numaNode; WARNING:BRACES: braces {} are not necessary for single statement blocks #445: FILE: kernel/windows/netuio/netuio_dev.c:205: + if (NT_SUCCESS(status)) { + netuio_contextdata->dev_numa_node = numaNode; + } ERROR:CODE_INDENT: code indent should use tabs where possible #446: FILE: kernel/windows/netuio/netuio_dev.c:206: + netuio_contextdata->dev_numa_node = numaNode;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #446: FILE: kernel/windows/netuio/netuio_dev.c:206: + netuio_contextdata->dev_numa_node = numaNode;$ ERROR:CODE_INDENT: code indent should use tabs where possible #447: FILE: kernel/windows/netuio/netuio_dev.c:207: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #447: FILE: kernel/windows/netuio/netuio_dev.c:207: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #448: FILE: kernel/windows/netuio/netuio_dev.c:208: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #450: FILE: kernel/windows/netuio/netuio_dev.c:210: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #456: FILE: kernel/windows/netuio/netuio_dev.c:216: + NTSTATUS status = STATUS_UNSUCCESSFUL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #457: FILE: kernel/windows/netuio/netuio_dev.c:217: + UNICODE_STRING netuio_symbolic_link;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #459: FILE: kernel/windows/netuio/netuio_dev.c:219: + PNETUIO_CONTEXT_DATA netuio_contextdata;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #460: FILE: kernel/windows/netuio/netuio_dev.c:220: + netuio_contextdata = netuio_get_context_data(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #462: FILE: kernel/windows/netuio/netuio_dev.c:222: + if (!netuio_contextdata)$ ERROR:CODE_INDENT: code indent should use tabs where possible #463: FILE: kernel/windows/netuio/netuio_dev.c:223: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #463: FILE: kernel/windows/netuio/netuio_dev.c:223: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #465: FILE: kernel/windows/netuio/netuio_dev.c:225: + // Build symbolic link name as _BDF (bus/device/func)$ ERROR:C99_COMMENTS: do not use C99 // comments #465: FILE: kernel/windows/netuio/netuio_dev.c:225: + // Build symbolic link name as _BDF (bus/device/func) WARNING:LEADING_SPACE: please, no spaces at the start of a line #466: FILE: kernel/windows/netuio/netuio_dev.c:226: + CHAR symbolic_link[64] = { 0 };$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #467: FILE: kernel/windows/netuio/netuio_dev.c:227: + sprintf_s(symbolic_link, sizeof(symbolic_link), "%s_%04d%02d%02d",$ ERROR:CODE_INDENT: code indent should use tabs where possible #468: FILE: kernel/windows/netuio/netuio_dev.c:228: + NETUIO_DEVICE_SYMBOLIC_LINK_ANSI, netuio_contextdata->addr.bus_num,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #468: FILE: kernel/windows/netuio/netuio_dev.c:228: + NETUIO_DEVICE_SYMBOLIC_LINK_ANSI, netuio_contextdata->addr.bus_num,$ ERROR:CODE_INDENT: code indent should use tabs where possible #469: FILE: kernel/windows/netuio/netuio_dev.c:229: + netuio_contextdata->addr.dev_num, netuio_contextdata->addr.func_num);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #469: FILE: kernel/windows/netuio/netuio_dev.c:229: + netuio_contextdata->addr.dev_num, netuio_contextdata->addr.func_num);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #471: FILE: kernel/windows/netuio/netuio_dev.c:231: + ANSI_STRING ansi_symbolic_link;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #472: FILE: kernel/windows/netuio/netuio_dev.c:232: + RtlInitAnsiString(&ansi_symbolic_link, symbolic_link);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #474: FILE: kernel/windows/netuio/netuio_dev.c:234: + status = RtlAnsiStringToUnicodeString(&netuio_symbolic_link, &ansi_symbolic_link, TRUE);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #475: FILE: kernel/windows/netuio/netuio_dev.c:235: + if (!NT_SUCCESS(status))$ ERROR:CODE_INDENT: code indent should use tabs where possible #476: FILE: kernel/windows/netuio/netuio_dev.c:236: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #476: FILE: kernel/windows/netuio/netuio_dev.c:236: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #478: FILE: kernel/windows/netuio/netuio_dev.c:238: + status = WdfDeviceCreateSymbolicLink(device, &netuio_symbolic_link);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #480: FILE: kernel/windows/netuio/netuio_dev.c:240: + RtlFreeUnicodeString(&netuio_symbolic_link);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #482: FILE: kernel/windows/netuio/netuio_dev.c:242: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #488: FILE: kernel/windows/netuio/netuio_dev.c:248: + NTSTATUS status = STATUS_SUCCESS;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #490: FILE: kernel/windows/netuio/netuio_dev.c:250: + PNETUIO_CONTEXT_DATA netuio_contextdata;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #491: FILE: kernel/windows/netuio/netuio_dev.c:251: + netuio_contextdata = netuio_get_context_data(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #493: FILE: kernel/windows/netuio/netuio_dev.c:253: + if (!netuio_contextdata)$ ERROR:CODE_INDENT: code indent should use tabs where possible #494: FILE: kernel/windows/netuio/netuio_dev.c:254: + return STATUS_UNSUCCESSFUL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #494: FILE: kernel/windows/netuio/netuio_dev.c:254: + return STATUS_UNSUCCESSFUL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #496: FILE: kernel/windows/netuio/netuio_dev.c:256: + PHYSICAL_ADDRESS lowest_acceptable_address;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #497: FILE: kernel/windows/netuio/netuio_dev.c:257: + PHYSICAL_ADDRESS highest_acceptable_address;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #498: FILE: kernel/windows/netuio/netuio_dev.c:258: + PHYSICAL_ADDRESS boundary_address_multiple;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #500: FILE: kernel/windows/netuio/netuio_dev.c:260: + lowest_acceptable_address.QuadPart = 0x0000000000800000;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #501: FILE: kernel/windows/netuio/netuio_dev.c:261: + highest_acceptable_address.QuadPart = 0xFFFFFFFFFFFFFFFF;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #502: FILE: kernel/windows/netuio/netuio_dev.c:262: + boundary_address_multiple.QuadPart = 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #504: FILE: kernel/windows/netuio/netuio_dev.c:264: + // Allocate physically contiguous memory for user process use$ ERROR:C99_COMMENTS: do not use C99 // comments #504: FILE: kernel/windows/netuio/netuio_dev.c:264: + // Allocate physically contiguous memory for user process use WARNING:LEADING_SPACE: please, no spaces at the start of a line #505: FILE: kernel/windows/netuio/netuio_dev.c:265: + netuio_contextdata->dpdk_seg.mem.virt_addr =$ ERROR:CODE_INDENT: code indent should use tabs where possible #506: FILE: kernel/windows/netuio/netuio_dev.c:266: + MmAllocateContiguousMemorySpecifyCache(USER_MEMORY_SEGMENT_SIZE,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #506: FILE: kernel/windows/netuio/netuio_dev.c:266: + MmAllocateContiguousMemorySpecifyCache(USER_MEMORY_SEGMENT_SIZE,$ ERROR:CODE_INDENT: code indent should use tabs where possible #507: FILE: kernel/windows/netuio/netuio_dev.c:267: + lowest_acceptable_address,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #507: FILE: kernel/windows/netuio/netuio_dev.c:267: + lowest_acceptable_address,$ ERROR:CODE_INDENT: code indent should use tabs where possible #508: FILE: kernel/windows/netuio/netuio_dev.c:268: + highest_acceptable_address,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #508: FILE: kernel/windows/netuio/netuio_dev.c:268: + highest_acceptable_address,$ ERROR:CODE_INDENT: code indent should use tabs where possible #509: FILE: kernel/windows/netuio/netuio_dev.c:269: + boundary_address_multiple,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #509: FILE: kernel/windows/netuio/netuio_dev.c:269: + boundary_address_multiple,$ ERROR:CODE_INDENT: code indent should use tabs where possible #510: FILE: kernel/windows/netuio/netuio_dev.c:270: + MmCached);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #510: FILE: kernel/windows/netuio/netuio_dev.c:270: + MmCached);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #512: FILE: kernel/windows/netuio/netuio_dev.c:272: + if (!netuio_contextdata->dpdk_seg.mem.virt_addr) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #513: FILE: kernel/windows/netuio/netuio_dev.c:273: + status = STATUS_NO_MEMORY;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #513: FILE: kernel/windows/netuio/netuio_dev.c:273: + status = STATUS_NO_MEMORY;$ ERROR:CODE_INDENT: code indent should use tabs where possible #514: FILE: kernel/windows/netuio/netuio_dev.c:274: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #514: FILE: kernel/windows/netuio/netuio_dev.c:274: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #515: FILE: kernel/windows/netuio/netuio_dev.c:275: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #517: FILE: kernel/windows/netuio/netuio_dev.c:277: + netuio_contextdata->dpdk_seg.mem.size = USER_MEMORY_SEGMENT_SIZE;$ WARNING:LONG_LINE_COMMENT: line over 100 characters #519: FILE: kernel/windows/netuio/netuio_dev.c:279: + // Allocate an MDL for this memory region - so that we can map it into the user's process context later WARNING:LEADING_SPACE: please, no spaces at the start of a line #519: FILE: kernel/windows/netuio/netuio_dev.c:279: + // Allocate an MDL for this memory region - so that we can map it into the user's process context later$ ERROR:C99_COMMENTS: do not use C99 // comments #519: FILE: kernel/windows/netuio/netuio_dev.c:279: + // Allocate an MDL for this memory region - so that we can map it into the user's process context later WARNING:LONG_LINE: line over 100 characters #520: FILE: kernel/windows/netuio/netuio_dev.c:280: + netuio_contextdata->dpdk_seg.mdl = IoAllocateMdl((PVOID)netuio_contextdata->dpdk_seg.mem.virt_addr, USER_MEMORY_SEGMENT_SIZE, FALSE, FALSE, NULL); WARNING:LEADING_SPACE: please, no spaces at the start of a line #520: FILE: kernel/windows/netuio/netuio_dev.c:280: + netuio_contextdata->dpdk_seg.mdl = IoAllocateMdl((PVOID)netuio_contextdata->dpdk_seg.mem.virt_addr, USER_MEMORY_SEGMENT_SIZE, FALSE, FALSE, NULL);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #521: FILE: kernel/windows/netuio/netuio_dev.c:281: + if (netuio_contextdata->dpdk_seg.mdl == NULL) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #522: FILE: kernel/windows/netuio/netuio_dev.c:282: + status = STATUS_NO_MEMORY;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #522: FILE: kernel/windows/netuio/netuio_dev.c:282: + status = STATUS_NO_MEMORY;$ ERROR:CODE_INDENT: code indent should use tabs where possible #523: FILE: kernel/windows/netuio/netuio_dev.c:283: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #523: FILE: kernel/windows/netuio/netuio_dev.c:283: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #524: FILE: kernel/windows/netuio/netuio_dev.c:284: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #526: FILE: kernel/windows/netuio/netuio_dev.c:286: + // Store the region's physical address$ ERROR:C99_COMMENTS: do not use C99 // comments #526: FILE: kernel/windows/netuio/netuio_dev.c:286: + // Store the region's physical address WARNING:LONG_LINE: line over 100 characters #527: FILE: kernel/windows/netuio/netuio_dev.c:287: + netuio_contextdata->dpdk_seg.mem.phys_addr = MmGetPhysicalAddress(netuio_contextdata->dpdk_seg.mem.virt_addr); WARNING:LEADING_SPACE: please, no spaces at the start of a line #527: FILE: kernel/windows/netuio/netuio_dev.c:287: + netuio_contextdata->dpdk_seg.mem.phys_addr = MmGetPhysicalAddress(netuio_contextdata->dpdk_seg.mem.virt_addr);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #530: FILE: kernel/windows/netuio/netuio_dev.c:290: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #536: FILE: kernel/windows/netuio/netuio_dev.c:296: + PNETUIO_CONTEXT_DATA netuio_contextdata;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #537: FILE: kernel/windows/netuio/netuio_dev.c:297: + netuio_contextdata = netuio_get_context_data(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #539: FILE: kernel/windows/netuio/netuio_dev.c:299: + if (netuio_contextdata) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #540: FILE: kernel/windows/netuio/netuio_dev.c:300: + if (netuio_contextdata->dpdk_seg.mdl)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #540: FILE: kernel/windows/netuio/netuio_dev.c:300: + if (netuio_contextdata->dpdk_seg.mdl)$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #540: FILE: kernel/windows/netuio/netuio_dev.c:300: + if (netuio_contextdata->dpdk_seg.mdl) + IoFreeMdl(netuio_contextdata->dpdk_seg.mdl); ERROR:CODE_INDENT: code indent should use tabs where possible #541: FILE: kernel/windows/netuio/netuio_dev.c:301: + IoFreeMdl(netuio_contextdata->dpdk_seg.mdl);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #541: FILE: kernel/windows/netuio/netuio_dev.c:301: + IoFreeMdl(netuio_contextdata->dpdk_seg.mdl);$ ERROR:CODE_INDENT: code indent should use tabs where possible #543: FILE: kernel/windows/netuio/netuio_dev.c:303: + if (netuio_contextdata->dpdk_seg.mem.virt_addr)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #543: FILE: kernel/windows/netuio/netuio_dev.c:303: + if (netuio_contextdata->dpdk_seg.mem.virt_addr)$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #543: FILE: kernel/windows/netuio/netuio_dev.c:303: + if (netuio_contextdata->dpdk_seg.mem.virt_addr) + MmFreeContiguousMemory(netuio_contextdata->dpdk_seg.mem.virt_addr); ERROR:CODE_INDENT: code indent should use tabs where possible #544: FILE: kernel/windows/netuio/netuio_dev.c:304: + MmFreeContiguousMemory(netuio_contextdata->dpdk_seg.mem.virt_addr);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #544: FILE: kernel/windows/netuio/netuio_dev.c:304: + MmFreeContiguousMemory(netuio_contextdata->dpdk_seg.mem.virt_addr);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #545: FILE: kernel/windows/netuio/netuio_dev.c:305: + }$ WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #554: FILE: kernel/windows/netuio/netuio_dev.h:2: +/*- +* ERROR:C99_COMMENTS: do not use C99 // comments #566: FILE: kernel/windows/netuio/netuio_dev.h:14: +// Constants ERROR:C99_COMMENTS: do not use C99 // comments #568: FILE: kernel/windows/netuio/netuio_dev.h:16: +#define USER_MEMORY_SEGMENT_SIZE (256ULL * 1024ULL * 1024ULL) // 256MB WARNING:LEADING_SPACE: please, no spaces at the start of a line #571: FILE: kernel/windows/netuio/netuio_dev.h:19: + PHYSICAL_ADDRESS base_addr;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #572: FILE: kernel/windows/netuio/netuio_dev.h:20: + PVOID virt_addr;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #573: FILE: kernel/windows/netuio/netuio_dev.h:21: + UINT64 size;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #577: FILE: kernel/windows/netuio/netuio_dev.h:25: + PMDL mdl; // MDL describing the memory region$ ERROR:C99_COMMENTS: do not use C99 // comments #577: FILE: kernel/windows/netuio/netuio_dev.h:25: + PMDL mdl; // MDL describing the memory region WARNING:LEADING_SPACE: please, no spaces at the start of a line #578: FILE: kernel/windows/netuio/netuio_dev.h:26: + struct mem_region mem; // Memory region details$ ERROR:C99_COMMENTS: do not use C99 // comments #578: FILE: kernel/windows/netuio/netuio_dev.h:26: + struct mem_region mem; // Memory region details ERROR:C99_COMMENTS: do not use C99 // comments #581: FILE: kernel/windows/netuio/netuio_dev.h:29: +// The device context performs the same job as a WDM device extension in the driver frameworks ERROR:OPEN_BRACE: open brace '{' following struct go on the same line #583: FILE: kernel/windows/netuio/netuio_dev.h:31: +typedef struct _NETUIO_CONTEXT_DATA +{ WARNING:LEADING_SPACE: please, no spaces at the start of a line #584: FILE: kernel/windows/netuio/netuio_dev.h:32: + WDFDEVICE wdf_device; // WDF device handle to the FDO$ ERROR:C99_COMMENTS: do not use C99 // comments #584: FILE: kernel/windows/netuio/netuio_dev.h:32: + WDFDEVICE wdf_device; // WDF device handle to the FDO WARNING:LEADING_SPACE: please, no spaces at the start of a line #585: FILE: kernel/windows/netuio/netuio_dev.h:33: + BUS_INTERFACE_STANDARD bus_interface; // Bus interface for config space access$ ERROR:C99_COMMENTS: do not use C99 // comments #585: FILE: kernel/windows/netuio/netuio_dev.h:33: + BUS_INTERFACE_STANDARD bus_interface; // Bus interface for config space access WARNING:LEADING_SPACE: please, no spaces at the start of a line #586: FILE: kernel/windows/netuio/netuio_dev.h:34: + struct pci_bar bar[PCI_MAX_BAR]; // device BARs$ ERROR:C99_COMMENTS: do not use C99 // comments #586: FILE: kernel/windows/netuio/netuio_dev.h:34: + struct pci_bar bar[PCI_MAX_BAR]; // device BARs WARNING:LEADING_SPACE: please, no spaces at the start of a line #587: FILE: kernel/windows/netuio/netuio_dev.h:35: + struct dev_addr addr; // B:D:F details of device$ ERROR:C99_COMMENTS: do not use C99 // comments #587: FILE: kernel/windows/netuio/netuio_dev.h:35: + struct dev_addr addr; // B:D:F details of device WARNING:LEADING_SPACE: please, no spaces at the start of a line #588: FILE: kernel/windows/netuio/netuio_dev.h:36: + USHORT dev_numa_node; // The NUMA node of the device$ ERROR:C99_COMMENTS: do not use C99 // comments #588: FILE: kernel/windows/netuio/netuio_dev.h:36: + USHORT dev_numa_node; // The NUMA node of the device WARNING:LEADING_SPACE: please, no spaces at the start of a line #589: FILE: kernel/windows/netuio/netuio_dev.h:37: + struct mem_map_region dpdk_hw; // mapped region for the device's register space$ ERROR:C99_COMMENTS: do not use C99 // comments #589: FILE: kernel/windows/netuio/netuio_dev.h:37: + struct mem_map_region dpdk_hw; // mapped region for the device's register space WARNING:LEADING_SPACE: please, no spaces at the start of a line #590: FILE: kernel/windows/netuio/netuio_dev.h:38: + struct mem_map_region dpdk_seg; // mapped region allocated for DPDK process use$ ERROR:C99_COMMENTS: do not use C99 // comments #590: FILE: kernel/windows/netuio/netuio_dev.h:38: + struct mem_map_region dpdk_seg; // mapped region allocated for DPDK process use ERROR:C99_COMMENTS: do not use C99 // comments #594: FILE: kernel/windows/netuio/netuio_dev.h:42: +// This macro will generate an inline function called DeviceGetContext ERROR:C99_COMMENTS: do not use C99 // comments #595: FILE: kernel/windows/netuio/netuio_dev.h:43: +// which will be used to get a pointer to the device context memory in a type safe manner. ERROR:C99_COMMENTS: do not use C99 // comments #599: FILE: kernel/windows/netuio/netuio_dev.h:47: +// Function to initialize the device and its callbacks WARNING:TYPO_SPELLING: 'Inout' may be misspelled - perhaps 'Input'? #600: FILE: kernel/windows/netuio/netuio_dev.h:48: +NTSTATUS netuio_create_device(_Inout_ PWDFDEVICE_INIT DeviceInit); WARNING:LONG_LINE: line over 100 characters #601: FILE: kernel/windows/netuio/netuio_dev.h:49: +NTSTATUS netuio_map_hw_resources(_In_ WDFDEVICE Device, _In_ WDFCMRESLIST Resources, _In_ WDFCMRESLIST ResourcesTranslated); ERROR:C99_COMMENTS: do not use C99 // comments #605: FILE: kernel/windows/netuio/netuio_dev.h:53: +// Function called for cleanup when device object is being destroyed ERROR:C99_COMMENTS: do not use C99 // comments #608: FILE: kernel/windows/netuio/netuio_dev.h:56: +// Local function protoyypes ERROR:C99_COMMENTS: do not use C99 // comments #617: FILE: kernel/windows/netuio/netuio_dev.h:65: +#endif // NETUIO_DEV_H WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #625: FILE: kernel/windows/netuio/netuio_drv.c:2: +/*- +* WARNING:SPACING: space prohibited between function name and open parenthesis '(' #634: FILE: kernel/windows/netuio/netuio_drv.c:11: +#pragma alloc_text (INIT, DriverEntry) WARNING:SPACING: space prohibited between function name and open parenthesis '(' #635: FILE: kernel/windows/netuio/netuio_drv.c:12: +#pragma alloc_text (PAGE, netuio_evt_device_add) WARNING:SPACING: space prohibited between function name and open parenthesis '(' #636: FILE: kernel/windows/netuio/netuio_drv.c:13: +#pragma alloc_text (PAGE, netuio_evt_driver_context_cleanup) WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #641: FILE: kernel/windows/netuio/netuio_drv.c:18: +/* +Routine Description: WARNING:LEADING_SPACE: please, no spaces at the start of a line #653: FILE: kernel/windows/netuio/netuio_drv.c:30: + WDF_DRIVER_CONFIG config;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #654: FILE: kernel/windows/netuio/netuio_drv.c:31: + NTSTATUS status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #655: FILE: kernel/windows/netuio/netuio_drv.c:32: + WDF_OBJECT_ATTRIBUTES attributes;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #657: FILE: kernel/windows/netuio/netuio_drv.c:34: + // Register a cleanup callback so that we can call WPP_CLEANUP when$ ERROR:C99_COMMENTS: do not use C99 // comments #657: FILE: kernel/windows/netuio/netuio_drv.c:34: + // Register a cleanup callback so that we can call WPP_CLEANUP when WARNING:LEADING_SPACE: please, no spaces at the start of a line #658: FILE: kernel/windows/netuio/netuio_drv.c:35: + // the framework driver object is deleted during driver unload.$ ERROR:C99_COMMENTS: do not use C99 // comments #658: FILE: kernel/windows/netuio/netuio_drv.c:35: + // the framework driver object is deleted during driver unload. WARNING:LEADING_SPACE: please, no spaces at the start of a line #659: FILE: kernel/windows/netuio/netuio_drv.c:36: + WDF_OBJECT_ATTRIBUTES_INIT(&attributes);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #660: FILE: kernel/windows/netuio/netuio_drv.c:37: + attributes.EvtCleanupCallback = netuio_evt_driver_context_cleanup;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #662: FILE: kernel/windows/netuio/netuio_drv.c:39: + WDF_DRIVER_CONFIG_INIT(&config, netuio_evt_device_add);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #664: FILE: kernel/windows/netuio/netuio_drv.c:41: + status = WdfDriverCreate(DriverObject, RegistryPath,$ ERROR:CODE_INDENT: code indent should use tabs where possible #665: FILE: kernel/windows/netuio/netuio_drv.c:42: + &attributes, &config,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #665: FILE: kernel/windows/netuio/netuio_drv.c:42: + &attributes, &config,$ ERROR:CODE_INDENT: code indent should use tabs where possible #666: FILE: kernel/windows/netuio/netuio_drv.c:43: + WDF_NO_HANDLE);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #666: FILE: kernel/windows/netuio/netuio_drv.c:43: + WDF_NO_HANDLE);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #668: FILE: kernel/windows/netuio/netuio_drv.c:45: + if (!NT_SUCCESS(status)) {$ WARNING:BRACES: braces {} are not necessary for single statement blocks #668: FILE: kernel/windows/netuio/netuio_drv.c:45: + if (!NT_SUCCESS(status)) { + return status; + } ERROR:CODE_INDENT: code indent should use tabs where possible #669: FILE: kernel/windows/netuio/netuio_drv.c:46: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #669: FILE: kernel/windows/netuio/netuio_drv.c:46: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #670: FILE: kernel/windows/netuio/netuio_drv.c:47: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #672: FILE: kernel/windows/netuio/netuio_drv.c:49: + return status;$ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #677: FILE: kernel/windows/netuio/netuio_drv.c:54: +/* +Routine Description: WARNING:TYPO_SPELLING: 'Inout' may be misspelled - perhaps 'Input'? #686: FILE: kernel/windows/netuio/netuio_drv.c:63: +netuio_evt_device_add(_In_ WDFDRIVER Driver, _Inout_ PWDFDEVICE_INIT DeviceInit) WARNING:LEADING_SPACE: please, no spaces at the start of a line #688: FILE: kernel/windows/netuio/netuio_drv.c:65: + NTSTATUS status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #689: FILE: kernel/windows/netuio/netuio_drv.c:66: + WDF_PNPPOWER_EVENT_CALLBACKS pnpPowerCallbacks;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #691: FILE: kernel/windows/netuio/netuio_drv.c:68: + UNREFERENCED_PARAMETER(Driver);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #693: FILE: kernel/windows/netuio/netuio_drv.c:70: + PAGED_CODE();$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #695: FILE: kernel/windows/netuio/netuio_drv.c:72: + // Zero out the PnpPowerCallbacks structure$ ERROR:C99_COMMENTS: do not use C99 // comments #695: FILE: kernel/windows/netuio/netuio_drv.c:72: + // Zero out the PnpPowerCallbacks structure WARNING:LEADING_SPACE: please, no spaces at the start of a line #696: FILE: kernel/windows/netuio/netuio_drv.c:73: + WDF_PNPPOWER_EVENT_CALLBACKS_INIT(&pnpPowerCallbacks);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #698: FILE: kernel/windows/netuio/netuio_drv.c:75: + // Register Plug-aNd-Play and power management callbacks$ ERROR:C99_COMMENTS: do not use C99 // comments #698: FILE: kernel/windows/netuio/netuio_drv.c:75: + // Register Plug-aNd-Play and power management callbacks WARNING:LEADING_SPACE: please, no spaces at the start of a line #699: FILE: kernel/windows/netuio/netuio_drv.c:76: + pnpPowerCallbacks.EvtDevicePrepareHardware = netuio_evt_prepare_hw;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #700: FILE: kernel/windows/netuio/netuio_drv.c:77: + pnpPowerCallbacks.EvtDeviceReleaseHardware = netuio_evt_release_hw;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #702: FILE: kernel/windows/netuio/netuio_drv.c:79: + WdfDeviceInitSetPnpPowerEventCallbacks(DeviceInit, &pnpPowerCallbacks);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #704: FILE: kernel/windows/netuio/netuio_drv.c:81: + status = netuio_create_device(DeviceInit);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #706: FILE: kernel/windows/netuio/netuio_drv.c:83: + return status;$ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #710: FILE: kernel/windows/netuio/netuio_drv.c:87: +/* +Routine Description : WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #716: FILE: kernel/windows/netuio/netuio_drv.c:93: +-*/ WARNING:LONG_LINE: line over 100 characters #718: FILE: kernel/windows/netuio/netuio_drv.c:95: +netuio_evt_prepare_hw(_In_ WDFDEVICE Device, _In_ WDFCMRESLIST Resources, _In_ WDFCMRESLIST ResourcesTranslated) WARNING:LEADING_SPACE: please, no spaces at the start of a line #720: FILE: kernel/windows/netuio/netuio_drv.c:97: + NTSTATUS status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #722: FILE: kernel/windows/netuio/netuio_drv.c:99: + status = netuio_map_hw_resources(Device, Resources, ResourcesTranslated);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #724: FILE: kernel/windows/netuio/netuio_drv.c:101: + if (NT_SUCCESS(status)) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #725: FILE: kernel/windows/netuio/netuio_drv.c:102: + PNETUIO_CONTEXT_DATA netuio_contextdata;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #725: FILE: kernel/windows/netuio/netuio_drv.c:102: + PNETUIO_CONTEXT_DATA netuio_contextdata;$ ERROR:CODE_INDENT: code indent should use tabs where possible #726: FILE: kernel/windows/netuio/netuio_drv.c:103: + netuio_contextdata = netuio_get_context_data(Device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #726: FILE: kernel/windows/netuio/netuio_drv.c:103: + netuio_contextdata = netuio_get_context_data(Device);$ ERROR:CODE_INDENT: code indent should use tabs where possible #727: FILE: kernel/windows/netuio/netuio_drv.c:104: + if (netuio_contextdata) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #727: FILE: kernel/windows/netuio/netuio_drv.c:104: + if (netuio_contextdata) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #727: FILE: kernel/windows/netuio/netuio_drv.c:104: + if (netuio_contextdata) { + DbgPrintEx(DPFLTR_IHVNETWORK_ID, DPFLTR_NETUIO_INFO_LEVEL, "netUIO Driver loaded...on device (B:D:F) %04d:%02d:%02d ", ERROR:CODE_INDENT: code indent should use tabs where possible #728: FILE: kernel/windows/netuio/netuio_drv.c:105: + DbgPrintEx(DPFLTR_IHVNETWORK_ID, DPFLTR_NETUIO_INFO_LEVEL, "netUIO Driver loaded...on device (B:D:F) %04d:%02d:%02d ",$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #728: FILE: kernel/windows/netuio/netuio_drv.c:105: + DbgPrintEx(DPFLTR_IHVNETWORK_ID, DPFLTR_NETUIO_INFO_LEVEL, "netUIO Driver loaded...on device (B:D:F) %04d:%02d:%02d ",$ WARNING:LONG_LINE: line over 100 characters #729: FILE: kernel/windows/netuio/netuio_drv.c:106: + netuio_contextdata->addr.bus_num, netuio_contextdata->addr.dev_num, netuio_contextdata->addr.func_num); ERROR:CODE_INDENT: code indent should use tabs where possible #729: FILE: kernel/windows/netuio/netuio_drv.c:106: + netuio_contextdata->addr.bus_num, netuio_contextdata->addr.dev_num, netuio_contextdata->addr.func_num);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #729: FILE: kernel/windows/netuio/netuio_drv.c:106: + netuio_contextdata->addr.bus_num, netuio_contextdata->addr.dev_num, netuio_contextdata->addr.func_num);$ ERROR:CODE_INDENT: code indent should use tabs where possible #730: FILE: kernel/windows/netuio/netuio_drv.c:107: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #730: FILE: kernel/windows/netuio/netuio_drv.c:107: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #731: FILE: kernel/windows/netuio/netuio_drv.c:108: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #732: FILE: kernel/windows/netuio/netuio_drv.c:109: + return status;$ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #736: FILE: kernel/windows/netuio/netuio_drv.c:113: +/* +Routine Description : WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #741: FILE: kernel/windows/netuio/netuio_drv.c:118: +-*/ WARNING:LEADING_SPACE: please, no spaces at the start of a line #745: FILE: kernel/windows/netuio/netuio_drv.c:122: + UNREFERENCED_PARAMETER(ResourcesTranslated);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #747: FILE: kernel/windows/netuio/netuio_drv.c:124: + netuio_free_hw_resources(Device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #749: FILE: kernel/windows/netuio/netuio_drv.c:126: + return STATUS_SUCCESS;$ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #753: FILE: kernel/windows/netuio/netuio_drv.c:130: +/* +Routine Description: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #758: FILE: kernel/windows/netuio/netuio_drv.c:135: +-*/ WARNING:LEADING_SPACE: please, no spaces at the start of a line #762: FILE: kernel/windows/netuio/netuio_drv.c:139: + UNREFERENCED_PARAMETER(DriverObject);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #763: FILE: kernel/windows/netuio/netuio_drv.c:140: + DbgPrintEx(DPFLTR_IHVNETWORK_ID, DPFLTR_NETUIO_INFO_LEVEL, "netUIO Driver unloaded. ");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #764: FILE: kernel/windows/netuio/netuio_drv.c:141: + PAGED_CODE();$ WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #773: FILE: kernel/windows/netuio/netuio_drv.h:2: +/*- +* ERROR:C99_COMMENTS: do not use C99 // comments #792: FILE: kernel/windows/netuio/netuio_drv.h:21: +// Print output constants ERROR:C99_COMMENTS: do not use C99 // comments #795: FILE: kernel/windows/netuio/netuio_drv.h:24: +// WDFDRIVER Events ERROR:C99_COMMENTS: do not use C99 // comments #804: FILE: kernel/windows/netuio/netuio_drv.h:33: +#endif // NETUIO_DRV_H WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #812: FILE: kernel/windows/netuio/netuio_interface.h:2: +/*- +* ERROR:TRAILING_WHITESPACE: trailing whitespace #821: FILE: kernel/windows/netuio/netuio_interface.h:11: +// All structures in this file are packed on an 8B boundary. $ ERROR:C99_COMMENTS: do not use C99 // comments #821: FILE: kernel/windows/netuio/netuio_interface.h:11: +// All structures in this file are packed on an 8B boundary. ERROR:C99_COMMENTS: do not use C99 // comments #825: FILE: kernel/windows/netuio/netuio_interface.h:15: +// Define an Interface Guid so that any app can find the device and talk to it. WARNING:LONG_LINE: line over 100 characters #826: FILE: kernel/windows/netuio/netuio_interface.h:16: +DEFINE_GUID (GUID_DEVINTERFACE_netUIO, 0x08336f60,0x0679,0x4c6c,0x85,0xd2,0xae,0x7c,0xed,0x65,0xff,0xf7); // {08336f60-0679-4c6c-85d2-ae7ced65fff7} ERROR:C99_COMMENTS: do not use C99 // comments #826: FILE: kernel/windows/netuio/netuio_interface.h:16: +DEFINE_GUID (GUID_DEVINTERFACE_netUIO, 0x08336f60,0x0679,0x4c6c,0x85,0xd2,0xae,0x7c,0xed,0x65,0xff,0xf7); // {08336f60-0679-4c6c-85d2-ae7ced65fff7} WARNING:SPACING: space prohibited between function name and open parenthesis '(' #826: FILE: kernel/windows/netuio/netuio_interface.h:16: +DEFINE_GUID (GUID_DEVINTERFACE_netUIO, 0x08336f60,0x0679,0x4c6c,0x85,0xd2,0xae,0x7c,0xed,0x65,0xff,0xf7); // {08336f60-0679-4c6c-85d2-ae7ced65fff7} ERROR:SPACING: space required after that ',' (ctx:VxV) #826: FILE: kernel/windows/netuio/netuio_interface.h:16: +DEFINE_GUID (GUID_DEVINTERFACE_netUIO, 0x08336f60,0x0679,0x4c6c,0x85,0xd2,0xae,0x7c,0xed,0x65,0xff,0xf7); // {08336f60-0679-4c6c-85d2-ae7ced65fff7} ^ ERROR:SPACING: space required after that ',' (ctx:VxV) #826: FILE: kernel/windows/netuio/netuio_interface.h:16: +DEFINE_GUID (GUID_DEVINTERFACE_netUIO, 0x08336f60,0x0679,0x4c6c,0x85,0xd2,0xae,0x7c,0xed,0x65,0xff,0xf7); // {08336f60-0679-4c6c-85d2-ae7ced65fff7} ^ ERROR:SPACING: space required after that ',' (ctx:VxV) #826: FILE: kernel/windows/netuio/netuio_interface.h:16: +DEFINE_GUID (GUID_DEVINTERFACE_netUIO, 0x08336f60,0x0679,0x4c6c,0x85,0xd2,0xae,0x7c,0xed,0x65,0xff,0xf7); // {08336f60-0679-4c6c-85d2-ae7ced65fff7} ^ ERROR:SPACING: space required after that ',' (ctx:VxV) #826: FILE: kernel/windows/netuio/netuio_interface.h:16: +DEFINE_GUID (GUID_DEVINTERFACE_netUIO, 0x08336f60,0x0679,0x4c6c,0x85,0xd2,0xae,0x7c,0xed,0x65,0xff,0xf7); // {08336f60-0679-4c6c-85d2-ae7ced65fff7} ^ ERROR:SPACING: space required after that ',' (ctx:VxV) #826: FILE: kernel/windows/netuio/netuio_interface.h:16: +DEFINE_GUID (GUID_DEVINTERFACE_netUIO, 0x08336f60,0x0679,0x4c6c,0x85,0xd2,0xae,0x7c,0xed,0x65,0xff,0xf7); // {08336f60-0679-4c6c-85d2-ae7ced65fff7} ^ ERROR:SPACING: space required after that ',' (ctx:VxV) #826: FILE: kernel/windows/netuio/netuio_interface.h:16: +DEFINE_GUID (GUID_DEVINTERFACE_netUIO, 0x08336f60,0x0679,0x4c6c,0x85,0xd2,0xae,0x7c,0xed,0x65,0xff,0xf7); // {08336f60-0679-4c6c-85d2-ae7ced65fff7} ^ ERROR:SPACING: space required after that ',' (ctx:VxV) #826: FILE: kernel/windows/netuio/netuio_interface.h:16: +DEFINE_GUID (GUID_DEVINTERFACE_netUIO, 0x08336f60,0x0679,0x4c6c,0x85,0xd2,0xae,0x7c,0xed,0x65,0xff,0xf7); // {08336f60-0679-4c6c-85d2-ae7ced65fff7} ^ ERROR:SPACING: space required after that ',' (ctx:VxV) #826: FILE: kernel/windows/netuio/netuio_interface.h:16: +DEFINE_GUID (GUID_DEVINTERFACE_netUIO, 0x08336f60,0x0679,0x4c6c,0x85,0xd2,0xae,0x7c,0xed,0x65,0xff,0xf7); // {08336f60-0679-4c6c-85d2-ae7ced65fff7} ^ ERROR:SPACING: space required after that ',' (ctx:VxV) #826: FILE: kernel/windows/netuio/netuio_interface.h:16: +DEFINE_GUID (GUID_DEVINTERFACE_netUIO, 0x08336f60,0x0679,0x4c6c,0x85,0xd2,0xae,0x7c,0xed,0x65,0xff,0xf7); // {08336f60-0679-4c6c-85d2-ae7ced65fff7} ^ ERROR:SPACING: space required after that ',' (ctx:VxV) #826: FILE: kernel/windows/netuio/netuio_interface.h:16: +DEFINE_GUID (GUID_DEVINTERFACE_netUIO, 0x08336f60,0x0679,0x4c6c,0x85,0xd2,0xae,0x7c,0xed,0x65,0xff,0xf7); // {08336f60-0679-4c6c-85d2-ae7ced65fff7} ^ ERROR:C99_COMMENTS: do not use C99 // comments #828: FILE: kernel/windows/netuio/netuio_interface.h:18: +// Device name definitions ERROR:C99_COMMENTS: do not use C99 // comments #831: FILE: kernel/windows/netuio/netuio_interface.h:21: +// netUIO driver symbolic name (prefix) ERROR:C99_COMMENTS: do not use C99 // comments #834: FILE: kernel/windows/netuio/netuio_interface.h:24: +// IOCTL code definitions WARNING:LONG_LINE: line over 100 characters #835: FILE: kernel/windows/netuio/netuio_interface.h:25: +#define IOCTL_NETUIO_GET_HW_DATA CTL_CODE(FILE_DEVICE_NETWORK, 51, METHOD_BUFFERED, FILE_READ_ACCESS | FILE_WRITE_ACCESS) WARNING:LONG_LINE: line over 100 characters #836: FILE: kernel/windows/netuio/netuio_interface.h:26: +#define IOCTL_NETUIO_PCI_CONFIG_IO CTL_CODE(FILE_DEVICE_NETWORK, 52, METHOD_BUFFERED, FILE_READ_ACCESS | FILE_WRITE_ACCESS) WARNING:LEADING_SPACE: please, no spaces at the start of a line #839: FILE: kernel/windows/netuio/netuio_interface.h:29: + UINT64 size; // memory region size$ ERROR:C99_COMMENTS: do not use C99 // comments #839: FILE: kernel/windows/netuio/netuio_interface.h:29: + UINT64 size; // memory region size WARNING:LEADING_SPACE: please, no spaces at the start of a line #840: FILE: kernel/windows/netuio/netuio_interface.h:30: + PHYSICAL_ADDRESS phys_addr; // physical address of the memory region$ ERROR:C99_COMMENTS: do not use C99 // comments #840: FILE: kernel/windows/netuio/netuio_interface.h:30: + PHYSICAL_ADDRESS phys_addr; // physical address of the memory region WARNING:LEADING_SPACE: please, no spaces at the start of a line #841: FILE: kernel/windows/netuio/netuio_interface.h:31: + PVOID virt_addr; // virtual address of the memory region$ ERROR:C99_COMMENTS: do not use C99 // comments #841: FILE: kernel/windows/netuio/netuio_interface.h:31: + PVOID virt_addr; // virtual address of the memory region WARNING:LONG_LINE_COMMENT: line over 100 characters #842: FILE: kernel/windows/netuio/netuio_interface.h:32: + PVOID user_mapped_virt_addr; // virtual address of the region mapped into user process context WARNING:LEADING_SPACE: please, no spaces at the start of a line #842: FILE: kernel/windows/netuio/netuio_interface.h:32: + PVOID user_mapped_virt_addr; // virtual address of the region mapped into user process context$ ERROR:C99_COMMENTS: do not use C99 // comments #842: FILE: kernel/windows/netuio/netuio_interface.h:32: + PVOID user_mapped_virt_addr; // virtual address of the region mapped into user process context WARNING:LEADING_SPACE: please, no spaces at the start of a line #846: FILE: kernel/windows/netuio/netuio_interface.h:36: + ULONG bus_num;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #847: FILE: kernel/windows/netuio/netuio_interface.h:37: + USHORT dev_num;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #848: FILE: kernel/windows/netuio/netuio_interface.h:38: + USHORT func_num;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #852: FILE: kernel/windows/netuio/netuio_interface.h:42: + PCI_IO_READ = 0,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #853: FILE: kernel/windows/netuio/netuio_interface.h:43: + PCI_IO_WRITE = 1$ ERROR:OPEN_BRACE: open brace '{' following struct go on the same line #857: FILE: kernel/windows/netuio/netuio_interface.h:47: +struct dpdk_private_info +{ WARNING:LEADING_SPACE: please, no spaces at the start of a line #858: FILE: kernel/windows/netuio/netuio_interface.h:48: + struct mem_region hw;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #859: FILE: kernel/windows/netuio/netuio_interface.h:49: + struct mem_region ms;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #860: FILE: kernel/windows/netuio/netuio_interface.h:50: + struct dev_addr dev_addr;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #861: FILE: kernel/windows/netuio/netuio_interface.h:51: + struct mem_region^Ibar1;$ ERROR:C99_COMMENTS: do not use C99 // comments #862: FILE: kernel/windows/netuio/netuio_interface.h:52: +// struct mem_region bar2; WARNING:LEADING_SPACE: please, no spaces at the start of a line #863: FILE: kernel/windows/netuio/netuio_interface.h:53: + UINT16 dev_id;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #864: FILE: kernel/windows/netuio/netuio_interface.h:54: + UINT16 sub_dev_id;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #865: FILE: kernel/windows/netuio/netuio_interface.h:55: + USHORT dev_numa_node;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #866: FILE: kernel/windows/netuio/netuio_interface.h:56: + USHORT reserved;$ ERROR:OPEN_BRACE: open brace '{' following struct go on the same line #870: FILE: kernel/windows/netuio/netuio_interface.h:60: +struct dpdk_pci_config_io +{ WARNING:LEADING_SPACE: please, no spaces at the start of a line #871: FILE: kernel/windows/netuio/netuio_interface.h:61: + struct dev_addr dev_addr;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #872: FILE: kernel/windows/netuio/netuio_interface.h:62: + PVOID buf;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #873: FILE: kernel/windows/netuio/netuio_interface.h:63: + UINT32 offset;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #874: FILE: kernel/windows/netuio/netuio_interface.h:64: + enum pci_io op;$ ERROR:C99_COMMENTS: do not use C99 // comments #879: FILE: kernel/windows/netuio/netuio_interface.h:69: +#endif // NETUIO_INTERFACE_H WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #887: FILE: kernel/windows/netuio/netuio_queue.c:2: +/*- +* WARNING:SPACING: space prohibited between function name and open parenthesis '(' #896: FILE: kernel/windows/netuio/netuio_queue.c:11: +#pragma alloc_text (PAGE, netuio_queue_initialize) WARNING:LEADING_SPACE: please, no spaces at the start of a line #901: FILE: kernel/windows/netuio/netuio_queue.c:16: + netuio_contextdata->bus_interface.GetBusData(netuio_contextdata->bus_interface.Context,$ ERROR:CODE_INDENT: code indent should use tabs where possible #902: FILE: kernel/windows/netuio/netuio_queue.c:17: + PCI_WHICHSPACE_CONFIG,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #902: FILE: kernel/windows/netuio/netuio_queue.c:17: + PCI_WHICHSPACE_CONFIG,$ ERROR:CODE_INDENT: code indent should use tabs where possible #903: FILE: kernel/windows/netuio/netuio_queue.c:18: + buffer,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #903: FILE: kernel/windows/netuio/netuio_queue.c:18: + buffer,$ ERROR:CODE_INDENT: code indent should use tabs where possible #904: FILE: kernel/windows/netuio/netuio_queue.c:19: + offset,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #904: FILE: kernel/windows/netuio/netuio_queue.c:19: + offset,$ ERROR:CODE_INDENT: code indent should use tabs where possible #905: FILE: kernel/windows/netuio/netuio_queue.c:20: + sizeof(UINT32));$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #905: FILE: kernel/windows/netuio/netuio_queue.c:20: + sizeof(UINT32));$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #910: FILE: kernel/windows/netuio/netuio_queue.c:25: + netuio_contextdata->bus_interface.SetBusData(netuio_contextdata->bus_interface.Context,$ ERROR:CODE_INDENT: code indent should use tabs where possible #911: FILE: kernel/windows/netuio/netuio_queue.c:26: + PCI_WHICHSPACE_CONFIG,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #911: FILE: kernel/windows/netuio/netuio_queue.c:26: + PCI_WHICHSPACE_CONFIG,$ ERROR:CODE_INDENT: code indent should use tabs where possible #912: FILE: kernel/windows/netuio/netuio_queue.c:27: + buffer,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #912: FILE: kernel/windows/netuio/netuio_queue.c:27: + buffer,$ ERROR:CODE_INDENT: code indent should use tabs where possible #913: FILE: kernel/windows/netuio/netuio_queue.c:28: + offset,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #913: FILE: kernel/windows/netuio/netuio_queue.c:28: + offset,$ ERROR:CODE_INDENT: code indent should use tabs where possible #914: FILE: kernel/windows/netuio/netuio_queue.c:29: + sizeof(UINT32));$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #914: FILE: kernel/windows/netuio/netuio_queue.c:29: + sizeof(UINT32));$ WARNING:LONG_LINE: line over 100 characters #918: FILE: kernel/windows/netuio/netuio_queue.c:33: +netuio_handle_get_hw_data_request(_In_ WDFREQUEST Request, _In_ PNETUIO_CONTEXT_DATA netuio_contextdata, ERROR:CODE_INDENT: code indent should use tabs where possible #919: FILE: kernel/windows/netuio/netuio_queue.c:34: + _In_ PVOID outputBuf, _In_ size_t outputBufSize)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #919: FILE: kernel/windows/netuio/netuio_queue.c:34: + _In_ PVOID outputBuf, _In_ size_t outputBufSize)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #921: FILE: kernel/windows/netuio/netuio_queue.c:36: + NTSTATUS status = STATUS_SUCCESS;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #923: FILE: kernel/windows/netuio/netuio_queue.c:38: + WDF_REQUEST_PARAMETERS params;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #924: FILE: kernel/windows/netuio/netuio_queue.c:39: + WDF_REQUEST_PARAMETERS_INIT(¶ms);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #925: FILE: kernel/windows/netuio/netuio_queue.c:40: + WdfRequestGetParameters(Request, ¶ms);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #927: FILE: kernel/windows/netuio/netuio_queue.c:42: + if (!netuio_contextdata || (outputBufSize != sizeof(struct dpdk_private_info))) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #928: FILE: kernel/windows/netuio/netuio_queue.c:43: + status = STATUS_INVALID_PARAMETER;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #928: FILE: kernel/windows/netuio/netuio_queue.c:43: + status = STATUS_INVALID_PARAMETER;$ ERROR:CODE_INDENT: code indent should use tabs where possible #929: FILE: kernel/windows/netuio/netuio_queue.c:44: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #929: FILE: kernel/windows/netuio/netuio_queue.c:44: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #930: FILE: kernel/windows/netuio/netuio_queue.c:45: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #932: FILE: kernel/windows/netuio/netuio_queue.c:47: + struct dpdk_private_info *dpdk_pvt_info = (struct dpdk_private_info *)outputBuf;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #933: FILE: kernel/windows/netuio/netuio_queue.c:48: + RtlZeroMemory(dpdk_pvt_info, outputBufSize);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #935: FILE: kernel/windows/netuio/netuio_queue.c:50: + dpdk_pvt_info->hw.phys_addr.QuadPart = netuio_contextdata->bar[0].base_addr.QuadPart;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #936: FILE: kernel/windows/netuio/netuio_queue.c:51: + dpdk_pvt_info->hw.user_mapped_virt_addr = netuio_contextdata->dpdk_hw.mem.user_mapped_virt_addr;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #937: FILE: kernel/windows/netuio/netuio_queue.c:52: + dpdk_pvt_info->hw.size = netuio_contextdata->bar[0].size;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #939: FILE: kernel/windows/netuio/netuio_queue.c:54: + dpdk_pvt_info->ms.phys_addr.QuadPart = netuio_contextdata->dpdk_seg.mem.phys_addr.QuadPart;$ WARNING:LONG_LINE: line over 100 characters #940: FILE: kernel/windows/netuio/netuio_queue.c:55: + dpdk_pvt_info->ms.user_mapped_virt_addr = netuio_contextdata->dpdk_seg.mem.user_mapped_virt_addr; WARNING:LEADING_SPACE: please, no spaces at the start of a line #940: FILE: kernel/windows/netuio/netuio_queue.c:55: + dpdk_pvt_info->ms.user_mapped_virt_addr = netuio_contextdata->dpdk_seg.mem.user_mapped_virt_addr;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #941: FILE: kernel/windows/netuio/netuio_queue.c:56: + dpdk_pvt_info->ms.size = netuio_contextdata->dpdk_seg.mem.size;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #943: FILE: kernel/windows/netuio/netuio_queue.c:58: + return status;$ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #947: FILE: kernel/windows/netuio/netuio_queue.c:62: +/* +Routine Description: WARNING:LEADING_SPACE: please, no spaces at the start of a line #958: FILE: kernel/windows/netuio/netuio_queue.c:73: + WDFQUEUE queue;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #959: FILE: kernel/windows/netuio/netuio_queue.c:74: + NTSTATUS status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #960: FILE: kernel/windows/netuio/netuio_queue.c:75: + WDF_IO_QUEUE_CONFIG queueConfig;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #962: FILE: kernel/windows/netuio/netuio_queue.c:77: + PAGED_CODE();$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #964: FILE: kernel/windows/netuio/netuio_queue.c:79: + // Configure a default queue so that requests that are not$ ERROR:C99_COMMENTS: do not use C99 // comments #964: FILE: kernel/windows/netuio/netuio_queue.c:79: + // Configure a default queue so that requests that are not WARNING:TYPO_SPELLING: 'fowarded' may be misspelled - perhaps 'forwarded'? #965: FILE: kernel/windows/netuio/netuio_queue.c:80: + // configure-fowarded using WdfDeviceConfigureRequestDispatching to goto WARNING:LEADING_SPACE: please, no spaces at the start of a line #965: FILE: kernel/windows/netuio/netuio_queue.c:80: + // configure-fowarded using WdfDeviceConfigureRequestDispatching to goto$ ERROR:C99_COMMENTS: do not use C99 // comments #965: FILE: kernel/windows/netuio/netuio_queue.c:80: + // configure-fowarded using WdfDeviceConfigureRequestDispatching to goto WARNING:LEADING_SPACE: please, no spaces at the start of a line #966: FILE: kernel/windows/netuio/netuio_queue.c:81: + // other queues get dispatched here.$ ERROR:C99_COMMENTS: do not use C99 // comments #966: FILE: kernel/windows/netuio/netuio_queue.c:81: + // other queues get dispatched here. WARNING:LEADING_SPACE: please, no spaces at the start of a line #967: FILE: kernel/windows/netuio/netuio_queue.c:82: + WDF_IO_QUEUE_CONFIG_INIT_DEFAULT_QUEUE(&queueConfig, WdfIoQueueDispatchParallel);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #969: FILE: kernel/windows/netuio/netuio_queue.c:84: + queueConfig.EvtIoDeviceControl = netuio_evt_IO_device_control;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #970: FILE: kernel/windows/netuio/netuio_queue.c:85: + queueConfig.EvtIoStop = netuio_evt_IO_stop;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #972: FILE: kernel/windows/netuio/netuio_queue.c:87: + status = WdfIoQueueCreate(Device,$ ERROR:CODE_INDENT: code indent should use tabs where possible #973: FILE: kernel/windows/netuio/netuio_queue.c:88: + &queueConfig,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #973: FILE: kernel/windows/netuio/netuio_queue.c:88: + &queueConfig,$ ERROR:CODE_INDENT: code indent should use tabs where possible #974: FILE: kernel/windows/netuio/netuio_queue.c:89: + WDF_NO_OBJECT_ATTRIBUTES,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #974: FILE: kernel/windows/netuio/netuio_queue.c:89: + WDF_NO_OBJECT_ATTRIBUTES,$ ERROR:CODE_INDENT: code indent should use tabs where possible #975: FILE: kernel/windows/netuio/netuio_queue.c:90: + &queue);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #975: FILE: kernel/windows/netuio/netuio_queue.c:90: + &queue);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #977: FILE: kernel/windows/netuio/netuio_queue.c:92: + if( !NT_SUCCESS(status) ) {$ ERROR:SPACING: space prohibited after that open parenthesis '(' #977: FILE: kernel/windows/netuio/netuio_queue.c:92: + if( !NT_SUCCESS(status) ) { ERROR:SPACING: space prohibited before that close parenthesis ')' #977: FILE: kernel/windows/netuio/netuio_queue.c:92: + if( !NT_SUCCESS(status) ) { ERROR:SPACING: space required before the open parenthesis '(' #977: FILE: kernel/windows/netuio/netuio_queue.c:92: + if( !NT_SUCCESS(status) ) { WARNING:BRACES: braces {} are not necessary for single statement blocks #977: FILE: kernel/windows/netuio/netuio_queue.c:92: + if( !NT_SUCCESS(status) ) { + return status; + } ERROR:CODE_INDENT: code indent should use tabs where possible #978: FILE: kernel/windows/netuio/netuio_queue.c:93: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #978: FILE: kernel/windows/netuio/netuio_queue.c:93: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #979: FILE: kernel/windows/netuio/netuio_queue.c:94: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #981: FILE: kernel/windows/netuio/netuio_queue.c:96: + return status;$ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #985: FILE: kernel/windows/netuio/netuio_queue.c:100: +/* +Routine Description: ERROR:CODE_INDENT: code indent should use tabs where possible #993: FILE: kernel/windows/netuio/netuio_queue.c:108: + _In_ size_t OutputBufferLength, _In_ size_t InputBufferLength,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #993: FILE: kernel/windows/netuio/netuio_queue.c:108: + _In_ size_t OutputBufferLength, _In_ size_t InputBufferLength,$ ERROR:CODE_INDENT: code indent should use tabs where possible #994: FILE: kernel/windows/netuio/netuio_queue.c:109: + _In_ ULONG IoControlCode)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #994: FILE: kernel/windows/netuio/netuio_queue.c:109: + _In_ ULONG IoControlCode)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #996: FILE: kernel/windows/netuio/netuio_queue.c:111: + UNREFERENCED_PARAMETER(OutputBufferLength);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #997: FILE: kernel/windows/netuio/netuio_queue.c:112: + UNREFERENCED_PARAMETER(InputBufferLength);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #999: FILE: kernel/windows/netuio/netuio_queue.c:114: + NTSTATUS status = STATUS_SUCCESS;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1000: FILE: kernel/windows/netuio/netuio_queue.c:115: + PVOID input_buf = NULL, output_buf = NULL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1001: FILE: kernel/windows/netuio/netuio_queue.c:116: + size_t input_buf_size, output_buf_size;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1002: FILE: kernel/windows/netuio/netuio_queue.c:117: + size_t bytes_returned = 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1004: FILE: kernel/windows/netuio/netuio_queue.c:119: + WDFDEVICE device = WdfIoQueueGetDevice(Queue);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1006: FILE: kernel/windows/netuio/netuio_queue.c:121: + PNETUIO_CONTEXT_DATA netuio_contextdata;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1007: FILE: kernel/windows/netuio/netuio_queue.c:122: + netuio_contextdata = netuio_get_context_data(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1009: FILE: kernel/windows/netuio/netuio_queue.c:124: + switch (IoControlCode) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1010: FILE: kernel/windows/netuio/netuio_queue.c:125: + case IOCTL_NETUIO_GET_HW_DATA:$ ERROR:CODE_INDENT: code indent should use tabs where possible #1011: FILE: kernel/windows/netuio/netuio_queue.c:126: + // First retrieve the input buffer and see if it matches our device$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1011: FILE: kernel/windows/netuio/netuio_queue.c:126: + // First retrieve the input buffer and see if it matches our device$ ERROR:C99_COMMENTS: do not use C99 // comments #1011: FILE: kernel/windows/netuio/netuio_queue.c:126: + // First retrieve the input buffer and see if it matches our device WARNING:LONG_LINE: line over 100 characters #1012: FILE: kernel/windows/netuio/netuio_queue.c:127: + status = WdfRequestRetrieveInputBuffer(Request, sizeof(struct dpdk_private_info), &input_buf, &input_buf_size); ERROR:CODE_INDENT: code indent should use tabs where possible #1012: FILE: kernel/windows/netuio/netuio_queue.c:127: + status = WdfRequestRetrieveInputBuffer(Request, sizeof(struct dpdk_private_info), &input_buf, &input_buf_size);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1012: FILE: kernel/windows/netuio/netuio_queue.c:127: + status = WdfRequestRetrieveInputBuffer(Request, sizeof(struct dpdk_private_info), &input_buf, &input_buf_size);$ ERROR:CODE_INDENT: code indent should use tabs where possible #1013: FILE: kernel/windows/netuio/netuio_queue.c:128: + if (!NT_SUCCESS(status)) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1013: FILE: kernel/windows/netuio/netuio_queue.c:128: + if (!NT_SUCCESS(status)) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #1013: FILE: kernel/windows/netuio/netuio_queue.c:128: + if (!NT_SUCCESS(status)) { + status = STATUS_INVALID_BUFFER_SIZE; ERROR:CODE_INDENT: code indent should use tabs where possible #1014: FILE: kernel/windows/netuio/netuio_queue.c:129: + status = STATUS_INVALID_BUFFER_SIZE;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1014: FILE: kernel/windows/netuio/netuio_queue.c:129: + status = STATUS_INVALID_BUFFER_SIZE;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1015: FILE: kernel/windows/netuio/netuio_queue.c:130: + break;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1015: FILE: kernel/windows/netuio/netuio_queue.c:130: + break;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1016: FILE: kernel/windows/netuio/netuio_queue.c:131: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1016: FILE: kernel/windows/netuio/netuio_queue.c:131: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #1018: FILE: kernel/windows/netuio/netuio_queue.c:133: + struct dpdk_private_info *dpdk_pvt_info = (struct dpdk_private_info *)input_buf;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1018: FILE: kernel/windows/netuio/netuio_queue.c:133: + struct dpdk_private_info *dpdk_pvt_info = (struct dpdk_private_info *)input_buf;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1019: FILE: kernel/windows/netuio/netuio_queue.c:134: + // Ensure that the B:D:F match - otherwise, fail the IOCTL$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1019: FILE: kernel/windows/netuio/netuio_queue.c:134: + // Ensure that the B:D:F match - otherwise, fail the IOCTL$ ERROR:C99_COMMENTS: do not use C99 // comments #1019: FILE: kernel/windows/netuio/netuio_queue.c:134: + // Ensure that the B:D:F match - otherwise, fail the IOCTL ERROR:CODE_INDENT: code indent should use tabs where possible #1020: FILE: kernel/windows/netuio/netuio_queue.c:135: + if ((netuio_contextdata->addr.bus_num != dpdk_pvt_info->dev_addr.bus_num) ||$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1020: FILE: kernel/windows/netuio/netuio_queue.c:135: + if ((netuio_contextdata->addr.bus_num != dpdk_pvt_info->dev_addr.bus_num) ||$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #1020: FILE: kernel/windows/netuio/netuio_queue.c:135: + if ((netuio_contextdata->addr.bus_num != dpdk_pvt_info->dev_addr.bus_num) || [...] + status = STATUS_NOT_SAME_DEVICE; ERROR:CODE_INDENT: code indent should use tabs where possible #1021: FILE: kernel/windows/netuio/netuio_queue.c:136: + (netuio_contextdata->addr.dev_num != dpdk_pvt_info->dev_addr.dev_num) ||$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1021: FILE: kernel/windows/netuio/netuio_queue.c:136: + (netuio_contextdata->addr.dev_num != dpdk_pvt_info->dev_addr.dev_num) ||$ ERROR:CODE_INDENT: code indent should use tabs where possible #1022: FILE: kernel/windows/netuio/netuio_queue.c:137: + (netuio_contextdata->addr.func_num != dpdk_pvt_info->dev_addr.func_num)) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1022: FILE: kernel/windows/netuio/netuio_queue.c:137: + (netuio_contextdata->addr.func_num != dpdk_pvt_info->dev_addr.func_num)) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #1023: FILE: kernel/windows/netuio/netuio_queue.c:138: + status = STATUS_NOT_SAME_DEVICE;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1023: FILE: kernel/windows/netuio/netuio_queue.c:138: + status = STATUS_NOT_SAME_DEVICE;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1024: FILE: kernel/windows/netuio/netuio_queue.c:139: + break;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1024: FILE: kernel/windows/netuio/netuio_queue.c:139: + break;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1025: FILE: kernel/windows/netuio/netuio_queue.c:140: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1025: FILE: kernel/windows/netuio/netuio_queue.c:140: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #1027: FILE: kernel/windows/netuio/netuio_queue.c:142: + // Map the previously allocated/defined memory regions to the user's process context$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1027: FILE: kernel/windows/netuio/netuio_queue.c:142: + // Map the previously allocated/defined memory regions to the user's process context$ ERROR:C99_COMMENTS: do not use C99 // comments #1027: FILE: kernel/windows/netuio/netuio_queue.c:142: + // Map the previously allocated/defined memory regions to the user's process context ERROR:CODE_INDENT: code indent should use tabs where possible #1028: FILE: kernel/windows/netuio/netuio_queue.c:143: + MmBuildMdlForNonPagedPool(netuio_contextdata->dpdk_hw.mdl);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1028: FILE: kernel/windows/netuio/netuio_queue.c:143: + MmBuildMdlForNonPagedPool(netuio_contextdata->dpdk_hw.mdl);$ ERROR:CODE_INDENT: code indent should use tabs where possible #1029: FILE: kernel/windows/netuio/netuio_queue.c:144: + netuio_contextdata->dpdk_hw.mem.user_mapped_virt_addr =$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1029: FILE: kernel/windows/netuio/netuio_queue.c:144: + netuio_contextdata->dpdk_hw.mem.user_mapped_virt_addr =$ WARNING:LONG_LINE: line over 100 characters #1030: FILE: kernel/windows/netuio/netuio_queue.c:145: + MmMapLockedPagesSpecifyCache(netuio_contextdata->dpdk_hw.mdl, UserMode, MmCached, ERROR:CODE_INDENT: code indent should use tabs where possible #1030: FILE: kernel/windows/netuio/netuio_queue.c:145: + MmMapLockedPagesSpecifyCache(netuio_contextdata->dpdk_hw.mdl, UserMode, MmCached,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1030: FILE: kernel/windows/netuio/netuio_queue.c:145: + MmMapLockedPagesSpecifyCache(netuio_contextdata->dpdk_hw.mdl, UserMode, MmCached,$ ERROR:CODE_INDENT: code indent should use tabs where possible #1031: FILE: kernel/windows/netuio/netuio_queue.c:146: + NULL, FALSE, (NormalPagePriority | MdlMappingNoExecute));$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1031: FILE: kernel/windows/netuio/netuio_queue.c:146: + NULL, FALSE, (NormalPagePriority | MdlMappingNoExecute));$ ERROR:CODE_INDENT: code indent should use tabs where possible #1033: FILE: kernel/windows/netuio/netuio_queue.c:148: + MmBuildMdlForNonPagedPool(netuio_contextdata->dpdk_seg.mdl);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1033: FILE: kernel/windows/netuio/netuio_queue.c:148: + MmBuildMdlForNonPagedPool(netuio_contextdata->dpdk_seg.mdl);$ ERROR:CODE_INDENT: code indent should use tabs where possible #1034: FILE: kernel/windows/netuio/netuio_queue.c:149: + netuio_contextdata->dpdk_seg.mem.user_mapped_virt_addr =$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1034: FILE: kernel/windows/netuio/netuio_queue.c:149: + netuio_contextdata->dpdk_seg.mem.user_mapped_virt_addr =$ WARNING:LONG_LINE: line over 100 characters #1035: FILE: kernel/windows/netuio/netuio_queue.c:150: + MmMapLockedPagesSpecifyCache(netuio_contextdata->dpdk_seg.mdl, UserMode, MmCached, ERROR:CODE_INDENT: code indent should use tabs where possible #1035: FILE: kernel/windows/netuio/netuio_queue.c:150: + MmMapLockedPagesSpecifyCache(netuio_contextdata->dpdk_seg.mdl, UserMode, MmCached,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1035: FILE: kernel/windows/netuio/netuio_queue.c:150: + MmMapLockedPagesSpecifyCache(netuio_contextdata->dpdk_seg.mdl, UserMode, MmCached,$ ERROR:CODE_INDENT: code indent should use tabs where possible #1036: FILE: kernel/windows/netuio/netuio_queue.c:151: + NULL, FALSE, (NormalPagePriority | MdlMappingNoExecute));$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1036: FILE: kernel/windows/netuio/netuio_queue.c:151: + NULL, FALSE, (NormalPagePriority | MdlMappingNoExecute));$ WARNING:LONG_LINE: line over 100 characters #1038: FILE: kernel/windows/netuio/netuio_queue.c:153: + if (!netuio_contextdata->dpdk_hw.mem.user_mapped_virt_addr && !netuio_contextdata->dpdk_seg.mem.user_mapped_virt_addr) { ERROR:CODE_INDENT: code indent should use tabs where possible #1038: FILE: kernel/windows/netuio/netuio_queue.c:153: + if (!netuio_contextdata->dpdk_hw.mem.user_mapped_virt_addr && !netuio_contextdata->dpdk_seg.mem.user_mapped_virt_addr) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1038: FILE: kernel/windows/netuio/netuio_queue.c:153: + if (!netuio_contextdata->dpdk_hw.mem.user_mapped_virt_addr && !netuio_contextdata->dpdk_seg.mem.user_mapped_virt_addr) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #1038: FILE: kernel/windows/netuio/netuio_queue.c:153: + if (!netuio_contextdata->dpdk_hw.mem.user_mapped_virt_addr && !netuio_contextdata->dpdk_seg.mem.user_mapped_virt_addr) { + status = STATUS_INSUFFICIENT_RESOURCES; ERROR:CODE_INDENT: code indent should use tabs where possible #1039: FILE: kernel/windows/netuio/netuio_queue.c:154: + status = STATUS_INSUFFICIENT_RESOURCES;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1039: FILE: kernel/windows/netuio/netuio_queue.c:154: + status = STATUS_INSUFFICIENT_RESOURCES;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1040: FILE: kernel/windows/netuio/netuio_queue.c:155: + break;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1040: FILE: kernel/windows/netuio/netuio_queue.c:155: + break;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1041: FILE: kernel/windows/netuio/netuio_queue.c:156: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1041: FILE: kernel/windows/netuio/netuio_queue.c:156: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #1043: FILE: kernel/windows/netuio/netuio_queue.c:158: + // Zero out the physically contiguous block$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1043: FILE: kernel/windows/netuio/netuio_queue.c:158: + // Zero out the physically contiguous block$ ERROR:C99_COMMENTS: do not use C99 // comments #1043: FILE: kernel/windows/netuio/netuio_queue.c:158: + // Zero out the physically contiguous block WARNING:LONG_LINE: line over 100 characters #1044: FILE: kernel/windows/netuio/netuio_queue.c:159: + RtlZeroMemory(netuio_contextdata->dpdk_seg.mem.virt_addr, netuio_contextdata->dpdk_seg.mem.size); ERROR:CODE_INDENT: code indent should use tabs where possible #1044: FILE: kernel/windows/netuio/netuio_queue.c:159: + RtlZeroMemory(netuio_contextdata->dpdk_seg.mem.virt_addr, netuio_contextdata->dpdk_seg.mem.size);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1044: FILE: kernel/windows/netuio/netuio_queue.c:159: + RtlZeroMemory(netuio_contextdata->dpdk_seg.mem.virt_addr, netuio_contextdata->dpdk_seg.mem.size);$ ERROR:CODE_INDENT: code indent should use tabs where possible #1046: FILE: kernel/windows/netuio/netuio_queue.c:161: + // Return relevant data to the caller$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1046: FILE: kernel/windows/netuio/netuio_queue.c:161: + // Return relevant data to the caller$ ERROR:C99_COMMENTS: do not use C99 // comments #1046: FILE: kernel/windows/netuio/netuio_queue.c:161: + // Return relevant data to the caller WARNING:LONG_LINE: line over 100 characters #1047: FILE: kernel/windows/netuio/netuio_queue.c:162: + status = WdfRequestRetrieveOutputBuffer(Request, sizeof(struct dpdk_private_info), &output_buf, &output_buf_size); ERROR:CODE_INDENT: code indent should use tabs where possible #1047: FILE: kernel/windows/netuio/netuio_queue.c:162: + status = WdfRequestRetrieveOutputBuffer(Request, sizeof(struct dpdk_private_info), &output_buf, &output_buf_size);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1047: FILE: kernel/windows/netuio/netuio_queue.c:162: + status = WdfRequestRetrieveOutputBuffer(Request, sizeof(struct dpdk_private_info), &output_buf, &output_buf_size);$ ERROR:CODE_INDENT: code indent should use tabs where possible #1048: FILE: kernel/windows/netuio/netuio_queue.c:163: + if (!NT_SUCCESS(status)) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1048: FILE: kernel/windows/netuio/netuio_queue.c:163: + if (!NT_SUCCESS(status)) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #1048: FILE: kernel/windows/netuio/netuio_queue.c:163: + if (!NT_SUCCESS(status)) { + status = STATUS_INVALID_BUFFER_SIZE; ERROR:CODE_INDENT: code indent should use tabs where possible #1049: FILE: kernel/windows/netuio/netuio_queue.c:164: + status = STATUS_INVALID_BUFFER_SIZE;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1049: FILE: kernel/windows/netuio/netuio_queue.c:164: + status = STATUS_INVALID_BUFFER_SIZE;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1050: FILE: kernel/windows/netuio/netuio_queue.c:165: + break;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1050: FILE: kernel/windows/netuio/netuio_queue.c:165: + break;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1051: FILE: kernel/windows/netuio/netuio_queue.c:166: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1051: FILE: kernel/windows/netuio/netuio_queue.c:166: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #1052: FILE: kernel/windows/netuio/netuio_queue.c:167: + ASSERT(output_buf_size == OutputBufferLength);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1052: FILE: kernel/windows/netuio/netuio_queue.c:167: + ASSERT(output_buf_size == OutputBufferLength);$ WARNING:LONG_LINE: line over 100 characters #1053: FILE: kernel/windows/netuio/netuio_queue.c:168: + status = netuio_handle_get_hw_data_request(Request, netuio_contextdata, output_buf, output_buf_size); ERROR:CODE_INDENT: code indent should use tabs where possible #1053: FILE: kernel/windows/netuio/netuio_queue.c:168: + status = netuio_handle_get_hw_data_request(Request, netuio_contextdata, output_buf, output_buf_size);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1053: FILE: kernel/windows/netuio/netuio_queue.c:168: + status = netuio_handle_get_hw_data_request(Request, netuio_contextdata, output_buf, output_buf_size);$ ERROR:CODE_INDENT: code indent should use tabs where possible #1054: FILE: kernel/windows/netuio/netuio_queue.c:169: + if (NT_SUCCESS(status))$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1054: FILE: kernel/windows/netuio/netuio_queue.c:169: + if (NT_SUCCESS(status))$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #1054: FILE: kernel/windows/netuio/netuio_queue.c:169: + if (NT_SUCCESS(status)) + bytes_returned = output_buf_size; ERROR:CODE_INDENT: code indent should use tabs where possible #1055: FILE: kernel/windows/netuio/netuio_queue.c:170: + bytes_returned = output_buf_size;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1055: FILE: kernel/windows/netuio/netuio_queue.c:170: + bytes_returned = output_buf_size;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1057: FILE: kernel/windows/netuio/netuio_queue.c:172: + break;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1057: FILE: kernel/windows/netuio/netuio_queue.c:172: + break;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1059: FILE: kernel/windows/netuio/netuio_queue.c:174: + case IOCTL_NETUIO_PCI_CONFIG_IO:$ ERROR:CODE_INDENT: code indent should use tabs where possible #1060: FILE: kernel/windows/netuio/netuio_queue.c:175: + // First retrieve the input buffer and see if it matches our device$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1060: FILE: kernel/windows/netuio/netuio_queue.c:175: + // First retrieve the input buffer and see if it matches our device$ ERROR:C99_COMMENTS: do not use C99 // comments #1060: FILE: kernel/windows/netuio/netuio_queue.c:175: + // First retrieve the input buffer and see if it matches our device WARNING:LONG_LINE: line over 100 characters #1061: FILE: kernel/windows/netuio/netuio_queue.c:176: + status = WdfRequestRetrieveInputBuffer(Request, sizeof(struct dpdk_pci_config_io), &input_buf, &input_buf_size); ERROR:CODE_INDENT: code indent should use tabs where possible #1061: FILE: kernel/windows/netuio/netuio_queue.c:176: + status = WdfRequestRetrieveInputBuffer(Request, sizeof(struct dpdk_pci_config_io), &input_buf, &input_buf_size);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1061: FILE: kernel/windows/netuio/netuio_queue.c:176: + status = WdfRequestRetrieveInputBuffer(Request, sizeof(struct dpdk_pci_config_io), &input_buf, &input_buf_size);$ ERROR:CODE_INDENT: code indent should use tabs where possible #1062: FILE: kernel/windows/netuio/netuio_queue.c:177: + if (!NT_SUCCESS(status)) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1062: FILE: kernel/windows/netuio/netuio_queue.c:177: + if (!NT_SUCCESS(status)) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #1062: FILE: kernel/windows/netuio/netuio_queue.c:177: + if (!NT_SUCCESS(status)) { + status = STATUS_INVALID_BUFFER_SIZE; ERROR:CODE_INDENT: code indent should use tabs where possible #1063: FILE: kernel/windows/netuio/netuio_queue.c:178: + status = STATUS_INVALID_BUFFER_SIZE;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1063: FILE: kernel/windows/netuio/netuio_queue.c:178: + status = STATUS_INVALID_BUFFER_SIZE;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1064: FILE: kernel/windows/netuio/netuio_queue.c:179: + break;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1064: FILE: kernel/windows/netuio/netuio_queue.c:179: + break;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1065: FILE: kernel/windows/netuio/netuio_queue.c:180: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1065: FILE: kernel/windows/netuio/netuio_queue.c:180: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #1067: FILE: kernel/windows/netuio/netuio_queue.c:182: + struct dpdk_pci_config_io *dpdk_pci_io_input = (struct dpdk_pci_config_io *)input_buf;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1067: FILE: kernel/windows/netuio/netuio_queue.c:182: + struct dpdk_pci_config_io *dpdk_pci_io_input = (struct dpdk_pci_config_io *)input_buf;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1068: FILE: kernel/windows/netuio/netuio_queue.c:183: + // Ensure that the B:D:F match - otherwise, fail the IOCTL$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1068: FILE: kernel/windows/netuio/netuio_queue.c:183: + // Ensure that the B:D:F match - otherwise, fail the IOCTL$ ERROR:C99_COMMENTS: do not use C99 // comments #1068: FILE: kernel/windows/netuio/netuio_queue.c:183: + // Ensure that the B:D:F match - otherwise, fail the IOCTL ERROR:CODE_INDENT: code indent should use tabs where possible #1069: FILE: kernel/windows/netuio/netuio_queue.c:184: + if ((netuio_contextdata->addr.bus_num != dpdk_pci_io_input->dev_addr.bus_num) ||$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1069: FILE: kernel/windows/netuio/netuio_queue.c:184: + if ((netuio_contextdata->addr.bus_num != dpdk_pci_io_input->dev_addr.bus_num) ||$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #1069: FILE: kernel/windows/netuio/netuio_queue.c:184: + if ((netuio_contextdata->addr.bus_num != dpdk_pci_io_input->dev_addr.bus_num) || [...] + status = STATUS_NOT_SAME_DEVICE; ERROR:CODE_INDENT: code indent should use tabs where possible #1070: FILE: kernel/windows/netuio/netuio_queue.c:185: + (netuio_contextdata->addr.dev_num != dpdk_pci_io_input->dev_addr.dev_num) ||$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1070: FILE: kernel/windows/netuio/netuio_queue.c:185: + (netuio_contextdata->addr.dev_num != dpdk_pci_io_input->dev_addr.dev_num) ||$ ERROR:CODE_INDENT: code indent should use tabs where possible #1071: FILE: kernel/windows/netuio/netuio_queue.c:186: + (netuio_contextdata->addr.func_num != dpdk_pci_io_input->dev_addr.func_num)) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1071: FILE: kernel/windows/netuio/netuio_queue.c:186: + (netuio_contextdata->addr.func_num != dpdk_pci_io_input->dev_addr.func_num)) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #1072: FILE: kernel/windows/netuio/netuio_queue.c:187: + status = STATUS_NOT_SAME_DEVICE;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1072: FILE: kernel/windows/netuio/netuio_queue.c:187: + status = STATUS_NOT_SAME_DEVICE;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1073: FILE: kernel/windows/netuio/netuio_queue.c:188: + break;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1073: FILE: kernel/windows/netuio/netuio_queue.c:188: + break;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1074: FILE: kernel/windows/netuio/netuio_queue.c:189: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1074: FILE: kernel/windows/netuio/netuio_queue.c:189: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #1075: FILE: kernel/windows/netuio/netuio_queue.c:190: + // Retrieve output buffer$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1075: FILE: kernel/windows/netuio/netuio_queue.c:190: + // Retrieve output buffer$ ERROR:C99_COMMENTS: do not use C99 // comments #1075: FILE: kernel/windows/netuio/netuio_queue.c:190: + // Retrieve output buffer WARNING:LONG_LINE: line over 100 characters #1076: FILE: kernel/windows/netuio/netuio_queue.c:191: + status = WdfRequestRetrieveOutputBuffer(Request, sizeof(UINT32), &output_buf, &output_buf_size); ERROR:CODE_INDENT: code indent should use tabs where possible #1076: FILE: kernel/windows/netuio/netuio_queue.c:191: + status = WdfRequestRetrieveOutputBuffer(Request, sizeof(UINT32), &output_buf, &output_buf_size);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1076: FILE: kernel/windows/netuio/netuio_queue.c:191: + status = WdfRequestRetrieveOutputBuffer(Request, sizeof(UINT32), &output_buf, &output_buf_size);$ ERROR:CODE_INDENT: code indent should use tabs where possible #1077: FILE: kernel/windows/netuio/netuio_queue.c:192: + if (!NT_SUCCESS(status)) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1077: FILE: kernel/windows/netuio/netuio_queue.c:192: + if (!NT_SUCCESS(status)) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #1077: FILE: kernel/windows/netuio/netuio_queue.c:192: + if (!NT_SUCCESS(status)) { + status = STATUS_INVALID_BUFFER_SIZE; ERROR:CODE_INDENT: code indent should use tabs where possible #1078: FILE: kernel/windows/netuio/netuio_queue.c:193: + status = STATUS_INVALID_BUFFER_SIZE;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1078: FILE: kernel/windows/netuio/netuio_queue.c:193: + status = STATUS_INVALID_BUFFER_SIZE;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1079: FILE: kernel/windows/netuio/netuio_queue.c:194: + break;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1079: FILE: kernel/windows/netuio/netuio_queue.c:194: + break;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1080: FILE: kernel/windows/netuio/netuio_queue.c:195: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1080: FILE: kernel/windows/netuio/netuio_queue.c:195: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #1081: FILE: kernel/windows/netuio/netuio_queue.c:196: + ASSERT(output_buf_size == OutputBufferLength);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1081: FILE: kernel/windows/netuio/netuio_queue.c:196: + ASSERT(output_buf_size == OutputBufferLength);$ ERROR:CODE_INDENT: code indent should use tabs where possible #1083: FILE: kernel/windows/netuio/netuio_queue.c:198: + if (dpdk_pci_io_input->op == PCI_IO_READ) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1083: FILE: kernel/windows/netuio/netuio_queue.c:198: + if (dpdk_pci_io_input->op == PCI_IO_READ) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #1083: FILE: kernel/windows/netuio/netuio_queue.c:198: + if (dpdk_pci_io_input->op == PCI_IO_READ) { + netuio_read_PCI_config(netuio_contextdata, dpdk_pci_io_input->offset, output_buf); ERROR:CODE_INDENT: code indent should use tabs where possible #1084: FILE: kernel/windows/netuio/netuio_queue.c:199: + netuio_read_PCI_config(netuio_contextdata, dpdk_pci_io_input->offset, output_buf);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1084: FILE: kernel/windows/netuio/netuio_queue.c:199: + netuio_read_PCI_config(netuio_contextdata, dpdk_pci_io_input->offset, output_buf);$ ERROR:CODE_INDENT: code indent should use tabs where possible #1085: FILE: kernel/windows/netuio/netuio_queue.c:200: + bytes_returned = output_buf_size;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1085: FILE: kernel/windows/netuio/netuio_queue.c:200: + bytes_returned = output_buf_size;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1086: FILE: kernel/windows/netuio/netuio_queue.c:201: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1086: FILE: kernel/windows/netuio/netuio_queue.c:201: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #1087: FILE: kernel/windows/netuio/netuio_queue.c:202: + else {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1087: FILE: kernel/windows/netuio/netuio_queue.c:202: + else {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #1087: FILE: kernel/windows/netuio/netuio_queue.c:202: + else { + netuio_write_PCI_config(netuio_contextdata, dpdk_pci_io_input->offset, dpdk_pci_io_input->buf); ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #1087: FILE: kernel/windows/netuio/netuio_queue.c:202: + } + else { WARNING:LONG_LINE: line over 100 characters #1088: FILE: kernel/windows/netuio/netuio_queue.c:203: + netuio_write_PCI_config(netuio_contextdata, dpdk_pci_io_input->offset, dpdk_pci_io_input->buf); ERROR:CODE_INDENT: code indent should use tabs where possible #1088: FILE: kernel/windows/netuio/netuio_queue.c:203: + netuio_write_PCI_config(netuio_contextdata, dpdk_pci_io_input->offset, dpdk_pci_io_input->buf);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1088: FILE: kernel/windows/netuio/netuio_queue.c:203: + netuio_write_PCI_config(netuio_contextdata, dpdk_pci_io_input->offset, dpdk_pci_io_input->buf);$ ERROR:CODE_INDENT: code indent should use tabs where possible #1089: FILE: kernel/windows/netuio/netuio_queue.c:204: + bytes_returned = 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1089: FILE: kernel/windows/netuio/netuio_queue.c:204: + bytes_returned = 0;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1090: FILE: kernel/windows/netuio/netuio_queue.c:205: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1090: FILE: kernel/windows/netuio/netuio_queue.c:205: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #1092: FILE: kernel/windows/netuio/netuio_queue.c:207: + break;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1092: FILE: kernel/windows/netuio/netuio_queue.c:207: + break;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1095: FILE: kernel/windows/netuio/netuio_queue.c:210: + break;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1095: FILE: kernel/windows/netuio/netuio_queue.c:210: + break;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1096: FILE: kernel/windows/netuio/netuio_queue.c:211: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1098: FILE: kernel/windows/netuio/netuio_queue.c:213: + WdfRequestCompleteWithInformation(Request, status, bytes_returned);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1100: FILE: kernel/windows/netuio/netuio_queue.c:215: + return;$ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #1104: FILE: kernel/windows/netuio/netuio_queue.c:219: +/* +Routine Description: ERROR:SPACING: space required after that ',' (ctx:VxV) #1111: FILE: kernel/windows/netuio/netuio_queue.c:226: +netuio_evt_IO_stop(_In_ WDFQUEUE Queue, _In_ WDFREQUEST Request,_In_ ULONG ActionFlags) ^ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1113: FILE: kernel/windows/netuio/netuio_queue.c:228: + //$ ERROR:C99_COMMENTS: do not use C99 // comments #1113: FILE: kernel/windows/netuio/netuio_queue.c:228: + // WARNING:LEADING_SPACE: please, no spaces at the start of a line #1114: FILE: kernel/windows/netuio/netuio_queue.c:229: + // In most cases, the EvtIoStop callback function completes, cancels, or postpones$ ERROR:C99_COMMENTS: do not use C99 // comments #1114: FILE: kernel/windows/netuio/netuio_queue.c:229: + // In most cases, the EvtIoStop callback function completes, cancels, or postpones WARNING:LEADING_SPACE: please, no spaces at the start of a line #1115: FILE: kernel/windows/netuio/netuio_queue.c:230: + // further processing of the I/O request.$ ERROR:C99_COMMENTS: do not use C99 // comments #1115: FILE: kernel/windows/netuio/netuio_queue.c:230: + // further processing of the I/O request. WARNING:LEADING_SPACE: please, no spaces at the start of a line #1116: FILE: kernel/windows/netuio/netuio_queue.c:231: + //$ ERROR:C99_COMMENTS: do not use C99 // comments #1116: FILE: kernel/windows/netuio/netuio_queue.c:231: + // WARNING:LEADING_SPACE: please, no spaces at the start of a line #1117: FILE: kernel/windows/netuio/netuio_queue.c:232: + // Typically, the driver uses the following rules:$ ERROR:C99_COMMENTS: do not use C99 // comments #1117: FILE: kernel/windows/netuio/netuio_queue.c:232: + // Typically, the driver uses the following rules: WARNING:LEADING_SPACE: please, no spaces at the start of a line #1118: FILE: kernel/windows/netuio/netuio_queue.c:233: + //$ ERROR:C99_COMMENTS: do not use C99 // comments #1118: FILE: kernel/windows/netuio/netuio_queue.c:233: + // WARNING:LEADING_SPACE: please, no spaces at the start of a line #1119: FILE: kernel/windows/netuio/netuio_queue.c:234: + // - If the driver owns the I/O request, it calls WdfRequestUnmarkCancelable$ ERROR:C99_COMMENTS: do not use C99 // comments #1119: FILE: kernel/windows/netuio/netuio_queue.c:234: + // - If the driver owns the I/O request, it calls WdfRequestUnmarkCancelable WARNING:LEADING_SPACE: please, no spaces at the start of a line #1120: FILE: kernel/windows/netuio/netuio_queue.c:235: + // (if the request is cancelable) and either calls WdfRequestStopAcknowledge$ ERROR:C99_COMMENTS: do not use C99 // comments #1120: FILE: kernel/windows/netuio/netuio_queue.c:235: + // (if the request is cancelable) and either calls WdfRequestStopAcknowledge WARNING:LEADING_SPACE: please, no spaces at the start of a line #1121: FILE: kernel/windows/netuio/netuio_queue.c:236: + // with a Requeue value of TRUE, or it calls WdfRequestComplete with a$ ERROR:C99_COMMENTS: do not use C99 // comments #1121: FILE: kernel/windows/netuio/netuio_queue.c:236: + // with a Requeue value of TRUE, or it calls WdfRequestComplete with a WARNING:LEADING_SPACE: please, no spaces at the start of a line #1122: FILE: kernel/windows/netuio/netuio_queue.c:237: + // completion status value of STATUS_SUCCESS or STATUS_CANCELLED.$ ERROR:C99_COMMENTS: do not use C99 // comments #1122: FILE: kernel/windows/netuio/netuio_queue.c:237: + // completion status value of STATUS_SUCCESS or STATUS_CANCELLED. WARNING:LEADING_SPACE: please, no spaces at the start of a line #1123: FILE: kernel/windows/netuio/netuio_queue.c:238: + //$ ERROR:C99_COMMENTS: do not use C99 // comments #1123: FILE: kernel/windows/netuio/netuio_queue.c:238: + // WARNING:LEADING_SPACE: please, no spaces at the start of a line #1124: FILE: kernel/windows/netuio/netuio_queue.c:239: + // Before it can call these methods safely, the driver must make sure that$ ERROR:C99_COMMENTS: do not use C99 // comments #1124: FILE: kernel/windows/netuio/netuio_queue.c:239: + // Before it can call these methods safely, the driver must make sure that WARNING:LEADING_SPACE: please, no spaces at the start of a line #1125: FILE: kernel/windows/netuio/netuio_queue.c:240: + // its implementation of EvtIoStop has exclusive access to the request.$ ERROR:C99_COMMENTS: do not use C99 // comments #1125: FILE: kernel/windows/netuio/netuio_queue.c:240: + // its implementation of EvtIoStop has exclusive access to the request. WARNING:LEADING_SPACE: please, no spaces at the start of a line #1126: FILE: kernel/windows/netuio/netuio_queue.c:241: + //$ ERROR:C99_COMMENTS: do not use C99 // comments #1126: FILE: kernel/windows/netuio/netuio_queue.c:241: + // WARNING:LEADING_SPACE: please, no spaces at the start of a line #1127: FILE: kernel/windows/netuio/netuio_queue.c:242: + // In order to do that, the driver must synchronize access to the request$ ERROR:C99_COMMENTS: do not use C99 // comments #1127: FILE: kernel/windows/netuio/netuio_queue.c:242: + // In order to do that, the driver must synchronize access to the request WARNING:LEADING_SPACE: please, no spaces at the start of a line #1128: FILE: kernel/windows/netuio/netuio_queue.c:243: + // to prevent other threads from manipulating the request concurrently.$ ERROR:C99_COMMENTS: do not use C99 // comments #1128: FILE: kernel/windows/netuio/netuio_queue.c:243: + // to prevent other threads from manipulating the request concurrently. WARNING:LEADING_SPACE: please, no spaces at the start of a line #1129: FILE: kernel/windows/netuio/netuio_queue.c:244: + // The synchronization method you choose will depend on your driver's design.$ ERROR:C99_COMMENTS: do not use C99 // comments #1129: FILE: kernel/windows/netuio/netuio_queue.c:244: + // The synchronization method you choose will depend on your driver's design. WARNING:LEADING_SPACE: please, no spaces at the start of a line #1130: FILE: kernel/windows/netuio/netuio_queue.c:245: + //$ ERROR:C99_COMMENTS: do not use C99 // comments #1130: FILE: kernel/windows/netuio/netuio_queue.c:245: + // WARNING:LEADING_SPACE: please, no spaces at the start of a line #1131: FILE: kernel/windows/netuio/netuio_queue.c:246: + // For example, if the request is held in a shared context, the EvtIoStop callback$ ERROR:C99_COMMENTS: do not use C99 // comments #1131: FILE: kernel/windows/netuio/netuio_queue.c:246: + // For example, if the request is held in a shared context, the EvtIoStop callback WARNING:LEADING_SPACE: please, no spaces at the start of a line #1132: FILE: kernel/windows/netuio/netuio_queue.c:247: + // might acquire an internal driver lock, take the request from the shared context,$ ERROR:C99_COMMENTS: do not use C99 // comments #1132: FILE: kernel/windows/netuio/netuio_queue.c:247: + // might acquire an internal driver lock, take the request from the shared context, WARNING:LEADING_SPACE: please, no spaces at the start of a line #1133: FILE: kernel/windows/netuio/netuio_queue.c:248: + // and then release the lock. At this point, the EvtIoStop callback owns the request$ ERROR:C99_COMMENTS: do not use C99 // comments #1133: FILE: kernel/windows/netuio/netuio_queue.c:248: + // and then release the lock. At this point, the EvtIoStop callback owns the request WARNING:LEADING_SPACE: please, no spaces at the start of a line #1134: FILE: kernel/windows/netuio/netuio_queue.c:249: + // and can safely complete or requeue the request.$ ERROR:C99_COMMENTS: do not use C99 // comments #1134: FILE: kernel/windows/netuio/netuio_queue.c:249: + // and can safely complete or requeue the request. WARNING:LEADING_SPACE: please, no spaces at the start of a line #1135: FILE: kernel/windows/netuio/netuio_queue.c:250: + //$ ERROR:C99_COMMENTS: do not use C99 // comments #1135: FILE: kernel/windows/netuio/netuio_queue.c:250: + // WARNING:LEADING_SPACE: please, no spaces at the start of a line #1136: FILE: kernel/windows/netuio/netuio_queue.c:251: + // - If the driver has forwarded the I/O request to an I/O target, it either calls$ ERROR:C99_COMMENTS: do not use C99 // comments #1136: FILE: kernel/windows/netuio/netuio_queue.c:251: + // - If the driver has forwarded the I/O request to an I/O target, it either calls WARNING:LEADING_SPACE: please, no spaces at the start of a line #1137: FILE: kernel/windows/netuio/netuio_queue.c:252: + // WdfRequestCancelSentRequest to attempt to cancel the request, or it postpones$ ERROR:C99_COMMENTS: do not use C99 // comments #1137: FILE: kernel/windows/netuio/netuio_queue.c:252: + // WdfRequestCancelSentRequest to attempt to cancel the request, or it postpones WARNING:LEADING_SPACE: please, no spaces at the start of a line #1138: FILE: kernel/windows/netuio/netuio_queue.c:253: + // further processing of the request and calls WdfRequestStopAcknowledge with$ ERROR:C99_COMMENTS: do not use C99 // comments #1138: FILE: kernel/windows/netuio/netuio_queue.c:253: + // further processing of the request and calls WdfRequestStopAcknowledge with WARNING:LEADING_SPACE: please, no spaces at the start of a line #1139: FILE: kernel/windows/netuio/netuio_queue.c:254: + // a Requeue value of FALSE.$ ERROR:C99_COMMENTS: do not use C99 // comments #1139: FILE: kernel/windows/netuio/netuio_queue.c:254: + // a Requeue value of FALSE. WARNING:LEADING_SPACE: please, no spaces at the start of a line #1140: FILE: kernel/windows/netuio/netuio_queue.c:255: + //$ ERROR:C99_COMMENTS: do not use C99 // comments #1140: FILE: kernel/windows/netuio/netuio_queue.c:255: + // WARNING:LEADING_SPACE: please, no spaces at the start of a line #1141: FILE: kernel/windows/netuio/netuio_queue.c:256: + // A driver might choose to take no action in EvtIoStop for requests that are$ ERROR:C99_COMMENTS: do not use C99 // comments #1141: FILE: kernel/windows/netuio/netuio_queue.c:256: + // A driver might choose to take no action in EvtIoStop for requests that are WARNING:LEADING_SPACE: please, no spaces at the start of a line #1142: FILE: kernel/windows/netuio/netuio_queue.c:257: + // guaranteed to complete in a small amount of time.$ ERROR:C99_COMMENTS: do not use C99 // comments #1142: FILE: kernel/windows/netuio/netuio_queue.c:257: + // guaranteed to complete in a small amount of time. WARNING:LEADING_SPACE: please, no spaces at the start of a line #1143: FILE: kernel/windows/netuio/netuio_queue.c:258: + //$ ERROR:C99_COMMENTS: do not use C99 // comments #1143: FILE: kernel/windows/netuio/netuio_queue.c:258: + // WARNING:LEADING_SPACE: please, no spaces at the start of a line #1144: FILE: kernel/windows/netuio/netuio_queue.c:259: + // In this case, the framework waits until the specified request is complete$ ERROR:C99_COMMENTS: do not use C99 // comments #1144: FILE: kernel/windows/netuio/netuio_queue.c:259: + // In this case, the framework waits until the specified request is complete WARNING:LEADING_SPACE: please, no spaces at the start of a line #1145: FILE: kernel/windows/netuio/netuio_queue.c:260: + // before moving the device (or system) to a lower power state or removing the device.$ ERROR:C99_COMMENTS: do not use C99 // comments #1145: FILE: kernel/windows/netuio/netuio_queue.c:260: + // before moving the device (or system) to a lower power state or removing the device. WARNING:LEADING_SPACE: please, no spaces at the start of a line #1146: FILE: kernel/windows/netuio/netuio_queue.c:261: + // Potentially, this inaction can prevent a system from entering its hibernation state$ ERROR:C99_COMMENTS: do not use C99 // comments #1146: FILE: kernel/windows/netuio/netuio_queue.c:261: + // Potentially, this inaction can prevent a system from entering its hibernation state WARNING:LEADING_SPACE: please, no spaces at the start of a line #1147: FILE: kernel/windows/netuio/netuio_queue.c:262: + // or another low system power state. In extreme cases, it can cause the system$ ERROR:C99_COMMENTS: do not use C99 // comments #1147: FILE: kernel/windows/netuio/netuio_queue.c:262: + // or another low system power state. In extreme cases, it can cause the system WARNING:LEADING_SPACE: please, no spaces at the start of a line #1148: FILE: kernel/windows/netuio/netuio_queue.c:263: + // to crash with bugcheck code 9F.$ ERROR:C99_COMMENTS: do not use C99 // comments #1148: FILE: kernel/windows/netuio/netuio_queue.c:263: + // to crash with bugcheck code 9F. WARNING:LEADING_SPACE: please, no spaces at the start of a line #1149: FILE: kernel/windows/netuio/netuio_queue.c:264: + //$ ERROR:C99_COMMENTS: do not use C99 // comments #1149: FILE: kernel/windows/netuio/netuio_queue.c:264: + // WARNING:LEADING_SPACE: please, no spaces at the start of a line #1150: FILE: kernel/windows/netuio/netuio_queue.c:265: + UNREFERENCED_PARAMETER(Queue);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1151: FILE: kernel/windows/netuio/netuio_queue.c:266: + UNREFERENCED_PARAMETER(Request);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1152: FILE: kernel/windows/netuio/netuio_queue.c:267: + UNREFERENCED_PARAMETER(ActionFlags);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1154: FILE: kernel/windows/netuio/netuio_queue.c:269: + return;$ WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #1164: FILE: kernel/windows/netuio/netuio_queue.h:2: +/*- +* ERROR:C99_COMMENTS: do not use C99 // comments #1175: FILE: kernel/windows/netuio/netuio_queue.h:13: +// This is the context that can be placed per queue and would contain per queue information. WARNING:LEADING_SPACE: please, no spaces at the start of a line #1177: FILE: kernel/windows/netuio/netuio_queue.h:15: + ULONG PrivateDeviceData; // just a placeholder$ ERROR:C99_COMMENTS: do not use C99 // comments #1177: FILE: kernel/windows/netuio/netuio_queue.h:15: + ULONG PrivateDeviceData; // just a placeholder ERROR:C99_COMMENTS: do not use C99 // comments #1186: FILE: kernel/windows/netuio/netuio_queue.h:24: +// Events from the IoQueue object ERROR:C99_COMMENTS: do not use C99 // comments #1192: FILE: kernel/windows/netuio/netuio_queue.h:30: +#endif // NETUIO_QUEUE_H ERROR:C99_COMMENTS: do not use C99 // comments #1199: FILE: kernel/windows/netuio/resource.h:1: +//{{NO_DEPENDENCIES}} ERROR:C99_COMMENTS: do not use C99 // comments #1200: FILE: kernel/windows/netuio/resource.h:2: +// Microsoft Visual C++ generated include file. ERROR:C99_COMMENTS: do not use C99 // comments #1201: FILE: kernel/windows/netuio/resource.h:3: +// Used by netuio.rc ERROR:C99_COMMENTS: do not use C99 // comments #1203: FILE: kernel/windows/netuio/resource.h:5: +// Next default values for new objects ERROR:TRAILING_WHITESPACE: trailing whitespace #1204: FILE: kernel/windows/netuio/resource.h:6: +// $ ERROR:C99_COMMENTS: do not use C99 // comments #1204: FILE: kernel/windows/netuio/resource.h:6: +// ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s) total: 330 errors, 523 warnings, 1048 lines checked