automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [dpdk-test-report] |WARNING| pw76223 [PATCH v1 20/42] net/txgbe: add RX and TX stop
Date: Wed,  9 Sep 2020 01:27:48 +0200 (CEST)	[thread overview]
Message-ID: <20200908232748.DF4101BEAC@dpdk.org> (raw)
In-Reply-To: <20200901115113.1529675-20-jiawenwu@trustnetic.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76223

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#58: 
Add receive and transmit units stop for specified queue, release mbufs and free queues.

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#222: FILE: drivers/net/txgbe/txgbe_rxtx.c:178:
+	unsigned i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#272: FILE: drivers/net/txgbe/txgbe_rxtx.c:228:
+	unsigned i;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#289: FILE: drivers/net/txgbe/txgbe_rxtx.c:245:
+	for (i = 0; i < len; i++) {
+		rxq->rx_ring[i] = zeroed_desc;
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#298: FILE: drivers/net/txgbe/txgbe_rxtx.c:254:
+	for (i = rxq->nb_rx_desc; i < len; ++i) {
+		rxq->sw_ring[i].mbuf = &rxq->fake_mbuf;
+	}

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#310: FILE: drivers/net/txgbe/txgbe_rxtx.c:266:
+
+}

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#315: FILE: drivers/net/txgbe/txgbe_rxtx.c:271:
+	unsigned i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#343: FILE: drivers/net/txgbe/txgbe_rxtx.c:298:
+	unsigned i;

CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#552: FILE: drivers/net/txgbe/txgbe_rxtx.h:98:
+	struct rte_mbuf *rx_stage[RTE_PMD_TXGBE_RX_MAX_BURST*2];
 	                                                    ^

total: 0 errors, 7 warnings, 2 checks, 468 lines checked

           reply	other threads:[~2020-09-08 23:27 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20200901115113.1529675-20-jiawenwu@trustnetic.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200908232748.DF4101BEAC@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=jiawenwu@trustnetic.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).